From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD1BDC433B4 for ; Mon, 26 Apr 2021 09:50:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF75A610A5 for ; Mon, 26 Apr 2021 09:50:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232922AbhDZJvb (ORCPT ); Mon, 26 Apr 2021 05:51:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:35660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232239AbhDZJv3 (ORCPT ); Mon, 26 Apr 2021 05:51:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3EE98610A5; Mon, 26 Apr 2021 09:50:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619430647; bh=5HK7sHxtSNFTvEowRYNk3JfWcvB1OJlsfiq4lhdMea4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VwlwhaKhG0Sib4seccmy6Azz+GwQS6EmVmoqM5RFbKA13KYdW/XtmANzxcPc9ef55 NUU8ahsJp80dYw9dxvItK9tCdaSZq9du+Q5Anh95xOoT06Qz/9Z7al9sie7sX5gfUh 9n7mQaIGYfEtVN1KICrlKbxZ/SSTOjb8BdxTPzEk= Date: Mon, 26 Apr 2021 11:50:44 +0200 From: Greg Kroah-Hartman To: Johan Hovold Cc: Leonardo Antoniazzi , linux-usb@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Anirudh Rayabharam , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: hso: fix NULL-deref on disconnect regression Message-ID: References: <20210426081149.10498-1-johan@kernel.org> <20210426112911.fb3593c3a9ecbabf98a13313@aruba.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 26, 2021 at 11:35:46AM +0200, Johan Hovold wrote: > On Mon, Apr 26, 2021 at 11:29:11AM +0200, Leonardo Antoniazzi wrote: > > On Mon, 26 Apr 2021 10:11:49 +0200 > > Johan Hovold wrote: > > > > > Commit 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device > > > unregistration") fixed the racy minor allocation reported by syzbot, but > > > introduced an unconditional NULL-pointer dereference on every disconnect > > > instead. > > > > > > Specifically, the serial device table must no longer be accessed after > > > the minor has been released by hso_serial_tty_unregister(). > > > > > > Fixes: 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device unregistration") > > > Cc: stable@vger.kernel.org > > > Cc: Anirudh Rayabharam > > > Reported-by: Leonardo Antoniazzi > > > Signed-off-by: Johan Hovold > > > --- > > > the patch fix the problem > > Thanks for confirming. > > Next time, please keep the CC list intact when replying so that everyone > sees that you've tested it. Wonderful. Johan, thanks for the quick fix. netdev maintainers, mind if I take this fix through my tree to Linus this week, or can you all get it to him before -rc1 through the networking tree? thanks, greg k-h