All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Petr Vorel" <petr.vorel@gmail.com>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>,
	Khem Raj <raj.khem@gmail.com>,
	OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] LTP drop MUSL specific patch
Date: Mon, 26 Apr 2021 23:29:30 +0200	[thread overview]
Message-ID: <YIcwurySkHcO7/MY@pevik> (raw)
In-Reply-To: <CAJ86T=VDx=w4FB34BZhsGcFYO8zAJ27kE6t9d_3xbBvkpOPDfg@mail.gmail.com>

Hi Andre,

> On Mon, Apr 26, 2021 at 11:53 AM Petr Vorel <petr.vorel@gmail.com> wrote:

> > Hi Khem, Richard,

> > I'd like to replace MUSL specific patch
> > meta/recipes-extended/ltp/ltp/0001-build-Add-option-to-select-libc-implementation.patch
> > with just removing broken files. We use this in upstream CI for Alpine, I ported
> > it to Buildroot [2], where works well. It's better because it does allow to
> > handle MUSL without rebasing this patch.

> > I was looking into the docs, it looks to me that do_configure [3] might be good hook
> > to add it into. But it looks like by default it contains oe_runmake clean [4].
> > Or should I use different hook? And how to find the default content of chosen
> > hook? (if I need to extend it, I'll have to provide the original as well)

> Changes to source files, including removing them, should be done as
> part of the do_patch task. Since do_patch is implemented in python you
> can't simply _append shell script commands to it, but you can add a
> shell function via do_patch[postfuncs]. If you grep for
> "do_patch[postfuncs]" in oe-core you should find a few examples.

Great, thanks a lot!

Kind regards,
Petr

  reply	other threads:[~2021-04-26 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 18:53 LTP drop MUSL specific patch Petr Vorel
2021-04-26 19:49 ` [OE-core] " Andre McCurdy
2021-04-26 21:29   ` Petr Vorel [this message]
2021-04-27 19:17   ` Petr Vorel
2021-04-27 19:57     ` Andre McCurdy
2021-04-27 20:00       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIcwurySkHcO7/MY@pevik \
    --to=petr.vorel@gmail.com \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.