From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 243A6C433B4 for ; Tue, 27 Apr 2021 03:42:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5640E613AB for ; Tue, 27 Apr 2021 03:42:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5640E613AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbEc2-0006yE-6K for qemu-devel@archiver.kernel.org; Mon, 26 Apr 2021 23:42:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbEZI-00055b-UR; Mon, 26 Apr 2021 23:39:24 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:60103) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbEZF-0005SC-2r; Mon, 26 Apr 2021 23:39:24 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4FTnYw1Qh0z9sXG; Tue, 27 Apr 2021 13:39:16 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1619494756; bh=QtZVxvb9EClUzkzRqeQoNm5/eG8yJU+fPr4QBi/AD8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZbjtFpYAXpWuQ3mARJbOUi62HvLZQmzZLeteIsk6m1ihPjLJ+6aZMsxO7MJSh5PM2 0r0iE4O+pwvALf68jsGAAeUK8Lan15k7bg2ZvilZ8uVHSDMjjilb/7yYAQj3EDveCn hYJR8PsHBlaRwRkYtBY7zM+e+CPN7Ikfka/BAUsc= Date: Tue, 27 Apr 2021 13:16:38 +1000 From: "david@gibson.dropbear.id.au" To: Bruno Piazera Larsen Subject: Re: [RFC PATCH 1/4] target/ppc: move opcode table logic to translate.c Message-ID: References: <20210423191807.77963-1-bruno.larsen@eldorado.org.br> <20210423191807.77963-2-bruno.larsen@eldorado.org.br> <87pmyg3lis.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9ca8z2C9FfvzSDYw" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabiano Rosas , Luis Fernando Fujita Pires , "qemu-devel@nongnu.org" , Lucas Mateus Martins Araujo e Castro , Fernando Eckhardt Valle , "qemu-ppc@nongnu.org" , Matheus Kowalczuk Ferst Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --9ca8z2C9FfvzSDYw Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 26, 2021 at 07:29:54PM +0000, Bruno Piazera Larsen wrote: > > > code motion to remove opcode callback table from > > > translate_init.c.inc to translate.c in preparation > > > to remove #include from > > > translate.c > > > > I'd mention the creation of destroy_ppc_opcodes since this patch is not > > strictly just moving code. >=20 > Sure, will do for v2. >=20 > > > +#if defined(PPC_DUMP_CPU) > > > > The commented out define for this was left behind. >=20 > Good catch! The define is going to still be used by a couple of things in= cpu_init, though. > I'm guessing moving to internal.h is the best solution, but correct > me if I'm wrong Generally LGTM, excepting the things Fabiano pointed out. >=20 >=20 > Bruno Piazera Larsen >=20 > Instituto de Pesquisas ELDORADO >=20 > Departamento Computa=E7=E3o Embarcada >=20 > Analista de Software Trainee >=20 > Aviso Legal - Disclaimer --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --9ca8z2C9FfvzSDYw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmCHghQACgkQbDjKyiDZ s5J8kw//a6O6qzyRJylIBQZhGmQu9ObfwYx9d9HmU6p7O4iGoZWyjCqCmS5Tv9Oa N/TWgyQMllNvBqOk8JiaP7nQphGFfr4GPxxKIHOeXM3cXL21d+flk4hGLWMNW+b0 3kKhM0+1Rh5A07XwDMTXZLOdDW4FVtSAr0OEWc9XNRQusuxst59wB9h2Eq9xkZQo U4fbDtpz2u16g9nkbTSA5DS/bAWNwAm8K/9bLkYHw+p6/ox5eYqL6bN3E3OIazTL Jq6AJURqT1FgWQ13PakgsLndYpEfdhstOAOHAmzQ0lPFtMV7tkuVXTeu+/FXiOpb +fpGzwbJlyLqWcQBAMqKO8O6LfwCCdgKfs7Pk7wfdYCHPgasfNkVKJan45QcG76A CKnUnQerUy6sGLSvt1FsFfzuQBKdHi0hyNXixSw6HgNkNUgoWPKg9RL6TvR16vk+ e5lrJPhRy+hRhS9rXHqj00WBlKWKNJ79WVDWaTjP1JYNDplgihYJApaY4eT1kx5T +9fdxQVCStEY1BtTNg7bB8cyYsio4n3u4FzG19lIjxvLxzb2Vu6KxeERqNofI8g2 qRcJE4/x6fJVPPc8ZJCaMnf1BOlgQK/iJMfUezN8eD7oNE6nNVCPxe55Uy0WSAy4 kgfXkI0KFKyAMrD49QmO56tQTb9BKBiH5Mx4iV92O843RNF9Iww= =+mUx -----END PGP SIGNATURE----- --9ca8z2C9FfvzSDYw--