* [PATCH net-next] net/mlx5: Fix some error messages
@ 2021-04-23 11:42 Dan Carpenter
2021-04-25 6:39 ` Leon Romanovsky
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2021-04-23 11:42 UTC (permalink / raw)
To: Saeed Mahameed, Yevgeny Kliteynik
Cc: Leon Romanovsky, linux-rdma, kernel-janitors
This code was using IS_ERR() instead of PTR_ERR() so it prints 1 instead
of the correct error code.
Fixes: 25cb31768042 ("net/mlx5: E-Switch, Improve error messages in term table creation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
.../mellanox/mlx5/core/eswitch_offloads_termtbl.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
index a81ece94f599..95f5c1a27718 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
@@ -83,16 +83,16 @@ mlx5_eswitch_termtbl_create(struct mlx5_core_dev *dev,
ft_attr.autogroup.max_num_groups = 1;
tt->termtbl = mlx5_create_auto_grouped_flow_table(root_ns, &ft_attr);
if (IS_ERR(tt->termtbl)) {
- esw_warn(dev, "Failed to create termination table (error %d)\n",
- IS_ERR(tt->termtbl));
+ esw_warn(dev, "Failed to create termination table (error %ld)\n",
+ PTR_ERR(tt->termtbl));
return -EOPNOTSUPP;
}
tt->rule = mlx5_add_flow_rules(tt->termtbl, NULL, flow_act,
&tt->dest, 1);
if (IS_ERR(tt->rule)) {
- esw_warn(dev, "Failed to create termination table rule (error %d)\n",
- IS_ERR(tt->rule));
+ esw_warn(dev, "Failed to create termination table rule (error %ld)\n",
+ PTR_ERR(tt->rule));
goto add_flow_err;
}
return 0;
@@ -283,8 +283,8 @@ mlx5_eswitch_add_termtbl_rule(struct mlx5_eswitch *esw,
tt = mlx5_eswitch_termtbl_get_create(esw, &term_tbl_act,
&dest[i], attr);
if (IS_ERR(tt)) {
- esw_warn(esw->dev, "Failed to get termination table (error %d)\n",
- IS_ERR(tt));
+ esw_warn(esw->dev, "Failed to get termination table (error %ld)\n",
+ PTR_ERR(tt));
goto revert_changes;
}
attr->dests[num_vport_dests].termtbl = tt;
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net/mlx5: Fix some error messages
2021-04-23 11:42 [PATCH net-next] net/mlx5: Fix some error messages Dan Carpenter
@ 2021-04-25 6:39 ` Leon Romanovsky
2021-04-26 16:33 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2021-04-25 6:39 UTC (permalink / raw)
To: Dan Carpenter
Cc: Saeed Mahameed, Yevgeny Kliteynik, linux-rdma, kernel-janitors,
linux-netdev
On Fri, Apr 23, 2021 at 02:42:57PM +0300, Dan Carpenter wrote:
> This code was using IS_ERR() instead of PTR_ERR() so it prints 1 instead
> of the correct error code.
>
> Fixes: 25cb31768042 ("net/mlx5: E-Switch, Improve error messages in term table creation")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> .../mellanox/mlx5/core/eswitch_offloads_termtbl.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
It should go through netdev@.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
> index a81ece94f599..95f5c1a27718 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
> @@ -83,16 +83,16 @@ mlx5_eswitch_termtbl_create(struct mlx5_core_dev *dev,
> ft_attr.autogroup.max_num_groups = 1;
> tt->termtbl = mlx5_create_auto_grouped_flow_table(root_ns, &ft_attr);
> if (IS_ERR(tt->termtbl)) {
> - esw_warn(dev, "Failed to create termination table (error %d)\n",
> - IS_ERR(tt->termtbl));
> + esw_warn(dev, "Failed to create termination table (error %ld)\n",
> + PTR_ERR(tt->termtbl));
> return -EOPNOTSUPP;
> }
>
> tt->rule = mlx5_add_flow_rules(tt->termtbl, NULL, flow_act,
> &tt->dest, 1);
> if (IS_ERR(tt->rule)) {
> - esw_warn(dev, "Failed to create termination table rule (error %d)\n",
> - IS_ERR(tt->rule));
> + esw_warn(dev, "Failed to create termination table rule (error %ld)\n",
> + PTR_ERR(tt->rule));
> goto add_flow_err;
> }
> return 0;
> @@ -283,8 +283,8 @@ mlx5_eswitch_add_termtbl_rule(struct mlx5_eswitch *esw,
> tt = mlx5_eswitch_termtbl_get_create(esw, &term_tbl_act,
> &dest[i], attr);
> if (IS_ERR(tt)) {
> - esw_warn(esw->dev, "Failed to get termination table (error %d)\n",
> - IS_ERR(tt));
> + esw_warn(esw->dev, "Failed to get termination table (error %ld)\n",
> + PTR_ERR(tt));
> goto revert_changes;
> }
> attr->dests[num_vport_dests].termtbl = tt;
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net/mlx5: Fix some error messages
2021-04-25 6:39 ` Leon Romanovsky
@ 2021-04-26 16:33 ` Jakub Kicinski
2021-04-26 18:47 ` Saeed Mahameed
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2021-04-26 16:33 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Dan Carpenter, Saeed Mahameed, Yevgeny Kliteynik, linux-rdma,
kernel-janitors, linux-netdev
On Sun, 25 Apr 2021 09:39:29 +0300 Leon Romanovsky wrote:
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
> > index a81ece94f599..95f5c1a27718 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
> > @@ -83,16 +83,16 @@ mlx5_eswitch_termtbl_create(struct mlx5_core_dev *dev,
> > ft_attr.autogroup.max_num_groups = 1;
> > tt->termtbl = mlx5_create_auto_grouped_flow_table(root_ns, &ft_attr);
> > if (IS_ERR(tt->termtbl)) {
> > - esw_warn(dev, "Failed to create termination table (error %d)\n",
> > - IS_ERR(tt->termtbl));
> > + esw_warn(dev, "Failed to create termination table (error %ld)\n",
> > + PTR_ERR(tt->termtbl));
If these are error pointers - perhaps %pe?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net/mlx5: Fix some error messages
2021-04-26 16:33 ` Jakub Kicinski
@ 2021-04-26 18:47 ` Saeed Mahameed
2021-04-27 5:08 ` Leon Romanovsky
0 siblings, 1 reply; 5+ messages in thread
From: Saeed Mahameed @ 2021-04-26 18:47 UTC (permalink / raw)
To: Jakub Kicinski, Leon Romanovsky
Cc: Dan Carpenter, Yevgeny Kliteynik, linux-rdma, kernel-janitors,
linux-netdev
On Mon, 2021-04-26 at 09:33 -0700, Jakub Kicinski wrote:
> On Sun, 25 Apr 2021 09:39:29 +0300 Leon Romanovsky wrote:
> > > diff --git
> > > a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb
> > > l.c
> > > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb
> > > l.c
> > > index a81ece94f599..95f5c1a27718 100644
> > > ---
> > > a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb
> > > l.c
> > > +++
> > > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb
> > > l.c
> > > @@ -83,16 +83,16 @@ mlx5_eswitch_termtbl_create(struct
> > > mlx5_core_dev *dev,
> > > ft_attr.autogroup.max_num_groups = 1;
> > > tt->termtbl =
> > > mlx5_create_auto_grouped_flow_table(root_ns, &ft_attr);
> > > if (IS_ERR(tt->termtbl)) {
> > > - esw_warn(dev, "Failed to create termination table
> > > (error %d)\n",
> > > - IS_ERR(tt->termtbl));
> > > + esw_warn(dev, "Failed to create termination table
> > > (error %ld)\n",
> > > + PTR_ERR(tt->termtbl));
>
> If these are error pointers - perhaps %pe?
no reason to use %pe, we know it is an err ptr at this point so just
report PTR_ERR()
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net/mlx5: Fix some error messages
2021-04-26 18:47 ` Saeed Mahameed
@ 2021-04-27 5:08 ` Leon Romanovsky
0 siblings, 0 replies; 5+ messages in thread
From: Leon Romanovsky @ 2021-04-27 5:08 UTC (permalink / raw)
To: Saeed Mahameed
Cc: Jakub Kicinski, Dan Carpenter, Yevgeny Kliteynik, linux-rdma,
kernel-janitors, linux-netdev
On Mon, Apr 26, 2021 at 11:47:03AM -0700, Saeed Mahameed wrote:
> On Mon, 2021-04-26 at 09:33 -0700, Jakub Kicinski wrote:
> > On Sun, 25 Apr 2021 09:39:29 +0300 Leon Romanovsky wrote:
> > > > diff --git
> > > > a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb
> > > > l.c
> > > > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb
> > > > l.c
> > > > index a81ece94f599..95f5c1a27718 100644
> > > > ---
> > > > a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb
> > > > l.c
> > > > +++
> > > > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb
> > > > l.c
> > > > @@ -83,16 +83,16 @@ mlx5_eswitch_termtbl_create(struct
> > > > mlx5_core_dev *dev,
> > > > ft_attr.autogroup.max_num_groups = 1;
> > > > tt->termtbl =
> > > > mlx5_create_auto_grouped_flow_table(root_ns, &ft_attr);
> > > > if (IS_ERR(tt->termtbl)) {
> > > > - esw_warn(dev, "Failed to create termination table
> > > > (error %d)\n",
> > > > - IS_ERR(tt->termtbl));
> > > > + esw_warn(dev, "Failed to create termination table
> > > > (error %ld)\n",
> > > > + PTR_ERR(tt->termtbl));
> >
> > If these are error pointers - perhaps %pe?
>
> no reason to use %pe, we know it is an err ptr at this point so just
> report PTR_ERR()
Saeed,
%pe prints string "-EINVAL" instead of "22", which is better.
I didn't know about such format specifier.
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-27 5:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 11:42 [PATCH net-next] net/mlx5: Fix some error messages Dan Carpenter
2021-04-25 6:39 ` Leon Romanovsky
2021-04-26 16:33 ` Jakub Kicinski
2021-04-26 18:47 ` Saeed Mahameed
2021-04-27 5:08 ` Leon Romanovsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.