From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 843F2C433B4 for ; Tue, 27 Apr 2021 16:27:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48A81613E8 for ; Tue, 27 Apr 2021 16:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235185AbhD0Q20 (ORCPT ); Tue, 27 Apr 2021 12:28:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:54540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236320AbhD0Q2E (ORCPT ); Tue, 27 Apr 2021 12:28:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DB6EC61164; Tue, 27 Apr 2021 16:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619540839; bh=ADR/oycFqAlI0vF384aDFm+Cf74+XJp7c6izTkkESqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=higNGhzp+lrZFCwn/Kiq+RuyI5Vm9c+mF/xrfxq3hE9gIWxC+2D9b7hFjCJHc93eL eSWxvTwckVRrJtFkuHQQIdfmEVUTs6iJW17t97n6+rWGQZO3rW9b62IyeTga5dkYzX tyjVfPJ/5Y1yF3GDmvwdruWzlRGXRO9Gj55f/+vw= Date: Tue, 27 Apr 2021 18:27:16 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Qiushi Wu , "Michael S . Tsirkin" Subject: Re: [PATCH 015/190] Revert "firmware: Fix a reference count leak." Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-16-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-16-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 02:58:10PM +0200, Greg Kroah-Hartman wrote: > This reverts commit fe3c60684377d5ad9b0569b87ed3e26e12c8173b. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Qiushi Wu > Cc: https > Cc: Michael S. Tsirkin > Signed-off-by: Greg Kroah-Hartman > --- > drivers/firmware/qemu_fw_cfg.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c > index 0078260fbabe..8fa660dde0f6 100644 > --- a/drivers/firmware/qemu_fw_cfg.c > +++ b/drivers/firmware/qemu_fw_cfg.c > @@ -608,10 +608,8 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f) > /* register entry under "/sys/firmware/qemu_fw_cfg/by_key/" */ > err = kobject_init_and_add(&entry->kobj, &fw_cfg_sysfs_entry_ktype, > fw_cfg_sel_ko, "%d", entry->select); > - if (err) { > - kobject_put(&entry->kobj); > - return err; > - } > + if (err) > + goto err_register; > > /* add raw binary content access */ > err = sysfs_create_bin_file(&entry->kobj, &fw_cfg_sysfs_attr_raw); > @@ -627,6 +625,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f) > > err_add_raw: > kobject_del(&entry->kobj); > +err_register: > kfree(entry); > return err; > } > -- > 2.31.1 > Looks correct, dropping. greg k-h