From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E582C433B4 for ; Tue, 27 Apr 2021 13:16:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA0096115C for ; Tue, 27 Apr 2021 13:16:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236210AbhD0NRk (ORCPT ); Tue, 27 Apr 2021 09:17:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:51654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235489AbhD0NRk (ORCPT ); Tue, 27 Apr 2021 09:17:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 36E1D60C3D; Tue, 27 Apr 2021 13:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619529416; bh=peNgo+yuiIkO1SN5wDs3JOHrcrGy/ZYty01XP1BJVdY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HuYN+NG+xhETIpwjRaPV5tpXfgRXNfGHKIDEAoAgv9PTgEsJ2sdnaCA828LDBl6X/ BYtkxlv206bgtxpZuDXfsY4lPXcoxCIJaqLL1At2K5oIrPKtzmiGdnC9bf+XFSLftx 9QV9hLyPMjDkbNuB+dm3Mm9PXRVHB++PoNJI/Qi0= Date: Tue, 27 Apr 2021 15:16:54 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Wenwen Wang , Hans Verkuil , Mauro Carvalho Chehab Subject: Re: [PATCH 183/190] Revert "media: isif: fix a NULL pointer dereference bug" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-184-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-184-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 03:00:58PM +0200, Greg Kroah-Hartman wrote: > This reverts commit a26ac6c1bed951b2066cc4b2257facd919e35c0b. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Wenwen Wang > Cc: Hans Verkuil > Cc: Mauro Carvalho Chehab > Signed-off-by: Greg Kroah-Hartman > --- > drivers/media/platform/davinci/isif.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/platform/davinci/isif.c b/drivers/media/platform/davinci/isif.c > index c53cecd072b1..5355a14c090b 100644 > --- a/drivers/media/platform/davinci/isif.c > +++ b/drivers/media/platform/davinci/isif.c > @@ -1086,8 +1086,7 @@ static int isif_probe(struct platform_device *pdev) > > while (i >= 0) { > res = platform_get_resource(pdev, IORESOURCE_MEM, i); > - if (res) > - release_mem_region(res->start, resource_size(res)); > + release_mem_region(res->start, resource_size(res)); > i--; > } > vpfe_unregister_ccdc_device(&isif_hw_dev); > -- > 2.31.1 > This looks correct, dropping it. greg k-h