From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55389C433B4 for ; Tue, 27 Apr 2021 13:25:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21FDF6105A for ; Tue, 27 Apr 2021 13:25:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236457AbhD0N0a (ORCPT ); Tue, 27 Apr 2021 09:26:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:57044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236078AbhD0N02 (ORCPT ); Tue, 27 Apr 2021 09:26:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5DEB360FD8; Tue, 27 Apr 2021 13:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619529943; bh=s6ZW+NO3VBOj88mkft8uAM3px0yWjQ1xGuMM5Dw1NJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uVwbwpu1OmTcRvezMTVieBQKvUEpbDD+9Y16r1e7c61e12EdM3afvJg/OkBvbwMxk yNkHPyZUXGEItQH9mDGqDEi7sfSuGwqO9xj1yKHwPH/JIOTry9Fm836gdQCfunJGPF EhktXC3U2HuDdCaD8hd6tfWVHXT2tFmvruxjHwlI= Date: Tue, 27 Apr 2021 15:25:41 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Kangjie Lu , Matthias Schwarzott , Sean Young , Mauro Carvalho Chehab Subject: Re: [PATCH 148/190] Revert "media: mt312: fix a missing check of mt312 reset" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-149-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-149-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 03:00:23PM +0200, Greg Kroah-Hartman wrote: > This reverts commit 9502cdf0807058a10029488052b064cecceb7fc9. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu > Cc: Matthias Schwarzott > Cc: Sean Young > Cc: Mauro Carvalho Chehab > Signed-off-by: Greg Kroah-Hartman > --- > drivers/media/dvb-frontends/mt312.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/dvb-frontends/mt312.c b/drivers/media/dvb-frontends/mt312.c > index d43a67045dbe..1dc6adefb8fe 100644 > --- a/drivers/media/dvb-frontends/mt312.c > +++ b/drivers/media/dvb-frontends/mt312.c > @@ -627,9 +627,7 @@ static int mt312_set_frontend(struct dvb_frontend *fe) > if (ret < 0) > return ret; > > - ret = mt312_reset(state, 0); > - if (ret < 0) > - return ret; > + mt312_reset(state, 0); > > return 0; > } > -- > 2.31.1 > This could have been made much simpler: return mt312_reset(state, 0); but as-is, is fine, I'll drop this revert. greg k-h