From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 374AAC433B4 for ; Tue, 27 Apr 2021 15:41:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 084BF61164 for ; Tue, 27 Apr 2021 15:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234932AbhD0Ply (ORCPT ); Tue, 27 Apr 2021 11:41:54 -0400 Received: from foss.arm.com ([217.140.110.172]:54310 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbhD0Ply (ORCPT ); Tue, 27 Apr 2021 11:41:54 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8B1C31B; Tue, 27 Apr 2021 08:41:10 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 86C0C3F73B; Tue, 27 Apr 2021 08:41:10 -0700 (PDT) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id 19D3068393E; Tue, 27 Apr 2021 16:41:09 +0100 (BST) Date: Tue, 27 Apr 2021 16:41:09 +0100 From: Liviu Dudau To: Daniel Vetter Cc: DRI Development , Intel Graphics Development , stable@vger.kernel.org, Pekka Paalanen , Brian Starkey , Daniel Vetter Subject: Re: [PATCH 2/8] drm/arm/malidp: Always list modifiers Message-ID: References: <20210427092018.832258-1-daniel.vetter@ffwll.ch> <20210427092018.832258-2-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210427092018.832258-2-daniel.vetter@ffwll.ch> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 27, 2021 at 11:20:12AM +0200, Daniel Vetter wrote: > Even when all we support is linear, make that explicit. Otherwise the > uapi is rather confusing. :) > > Cc: stable@vger.kernel.org > Cc: Pekka Paalanen > Cc: Liviu Dudau > Cc: Brian Starkey > Signed-off-by: Daniel Vetter Acked-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/arm/malidp_planes.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c > index ddbba67f0283..8c2ab3d653b7 100644 > --- a/drivers/gpu/drm/arm/malidp_planes.c > +++ b/drivers/gpu/drm/arm/malidp_planes.c > @@ -927,6 +927,11 @@ static const struct drm_plane_helper_funcs malidp_de_plane_helper_funcs = { > .atomic_disable = malidp_de_plane_disable, > }; > > +static const uint64_t linear_only_modifiers[] = { > + DRM_FORMAT_MOD_LINEAR, > + DRM_FORMAT_MOD_INVALID > +}; > + > int malidp_de_planes_init(struct drm_device *drm) > { > struct malidp_drm *malidp = drm->dev_private; > @@ -990,8 +995,8 @@ int malidp_de_planes_init(struct drm_device *drm) > */ > ret = drm_universal_plane_init(drm, &plane->base, crtcs, > &malidp_de_plane_funcs, formats, n, > - (id == DE_SMART) ? NULL : modifiers, plane_type, > - NULL); > + (id == DE_SMART) ? linear_only_modifiers : modifiers, > + plane_type, NULL); > > if (ret < 0) > goto cleanup; > -- > 2.31.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD32C433ED for ; Tue, 27 Apr 2021 15:41:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A11F960FD7 for ; Tue, 27 Apr 2021 15:41:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A11F960FD7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 505886E0C8; Tue, 27 Apr 2021 15:41:12 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 250236E0C8; Tue, 27 Apr 2021 15:41:11 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8B1C31B; Tue, 27 Apr 2021 08:41:10 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 86C0C3F73B; Tue, 27 Apr 2021 08:41:10 -0700 (PDT) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id 19D3068393E; Tue, 27 Apr 2021 16:41:09 +0100 (BST) Date: Tue, 27 Apr 2021 16:41:09 +0100 From: Liviu Dudau To: Daniel Vetter Subject: Re: [PATCH 2/8] drm/arm/malidp: Always list modifiers Message-ID: References: <20210427092018.832258-1-daniel.vetter@ffwll.ch> <20210427092018.832258-2-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210427092018.832258-2-daniel.vetter@ffwll.ch> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pekka Paalanen , Intel Graphics Development , stable@vger.kernel.org, DRI Development , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBBcHIgMjcsIDIwMjEgYXQgMTE6MjA6MTJBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBFdmVuIHdoZW4gYWxsIHdlIHN1cHBvcnQgaXMgbGluZWFyLCBtYWtlIHRoYXQgZXhw bGljaXQuIE90aGVyd2lzZSB0aGUKPiB1YXBpIGlzIHJhdGhlciBjb25mdXNpbmcuCgo6KQoKPiAK PiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+IENjOiBQZWtrYSBQYWFsYW5lbiA8cGVra2Eu cGFhbGFuZW5AY29sbGFib3JhLmNvbT4KPiBDYzogTGl2aXUgRHVkYXUgPGxpdml1LmR1ZGF1QGFy bS5jb20+Cj4gQ2M6IEJyaWFuIFN0YXJrZXkgPGJyaWFuLnN0YXJrZXlAYXJtLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KCkFja2Vk LWJ5OiBMaXZpdSBEdWRhdSA8bGl2aXUuZHVkYXVAYXJtLmNvbT4KCkJlc3QgcmVnYXJkcywKTGl2 aXUKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX3BsYW5lcy5jIHwgOSArKysr KysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfcGxhbmVzLmMgYi9k cml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9wbGFuZXMuYwo+IGluZGV4IGRkYmJhNjdmMDI4My4u OGMyYWIzZDY1M2I3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX3Bs YW5lcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfcGxhbmVzLmMKPiBAQCAt OTI3LDYgKzkyNywxMSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9oZWxwZXJfZnVu Y3MgbWFsaWRwX2RlX3BsYW5lX2hlbHBlcl9mdW5jcyA9IHsKPiAgCS5hdG9taWNfZGlzYWJsZSA9 IG1hbGlkcF9kZV9wbGFuZV9kaXNhYmxlLAo+ICB9Owo+ICAKPiArc3RhdGljIGNvbnN0IHVpbnQ2 NF90IGxpbmVhcl9vbmx5X21vZGlmaWVyc1tdID0gewo+ICsJRFJNX0ZPUk1BVF9NT0RfTElORUFS LAo+ICsJRFJNX0ZPUk1BVF9NT0RfSU5WQUxJRAo+ICt9Owo+ICsKPiAgaW50IG1hbGlkcF9kZV9w bGFuZXNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKQo+ICB7Cj4gIAlzdHJ1Y3QgbWFsaWRw X2RybSAqbWFsaWRwID0gZHJtLT5kZXZfcHJpdmF0ZTsKPiBAQCAtOTkwLDggKzk5NSw4IEBAIGlu dCBtYWxpZHBfZGVfcGxhbmVzX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRybSkKPiAgCQkgKi8K PiAgCQlyZXQgPSBkcm1fdW5pdmVyc2FsX3BsYW5lX2luaXQoZHJtLCAmcGxhbmUtPmJhc2UsIGNy dGNzLAo+ICAJCQkJJm1hbGlkcF9kZV9wbGFuZV9mdW5jcywgZm9ybWF0cywgbiwKPiAtCQkJCShp ZCA9PSBERV9TTUFSVCkgPyBOVUxMIDogbW9kaWZpZXJzLCBwbGFuZV90eXBlLAo+IC0JCQkJTlVM TCk7Cj4gKwkJCQkoaWQgPT0gREVfU01BUlQpID8gbGluZWFyX29ubHlfbW9kaWZpZXJzIDogbW9k aWZpZXJzLAo+ICsJCQkJcGxhbmVfdHlwZSwgTlVMTCk7Cj4gIAo+ICAJCWlmIChyZXQgPCAwKQo+ ICAJCQlnb3RvIGNsZWFudXA7Cj4gLS0gCj4gMi4zMS4wCj4gCgotLSAKPT09PT09PT09PT09PT09 PT09PT0KfCBJIHdvdWxkIGxpa2UgdG8gfAp8IGZpeCB0aGUgd29ybGQsICB8CnwgYnV0IHRoZXkn cmUgbm90IHwKfCBnaXZpbmcgbWUgdGhlICAgfAogXCBzb3VyY2UgY29kZSEgIC8KICAtLS0tLS0t LS0tLS0tLS0KICAgIMKvXF8o44OEKV8vwq8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B5ECC43460 for ; Tue, 27 Apr 2021 15:41:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B2056115C for ; Tue, 27 Apr 2021 15:41:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B2056115C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FBE36E987; Tue, 27 Apr 2021 15:41:13 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 250236E0C8; Tue, 27 Apr 2021 15:41:11 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8B1C31B; Tue, 27 Apr 2021 08:41:10 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 86C0C3F73B; Tue, 27 Apr 2021 08:41:10 -0700 (PDT) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id 19D3068393E; Tue, 27 Apr 2021 16:41:09 +0100 (BST) Date: Tue, 27 Apr 2021 16:41:09 +0100 From: Liviu Dudau To: Daniel Vetter Message-ID: References: <20210427092018.832258-1-daniel.vetter@ffwll.ch> <20210427092018.832258-2-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210427092018.832258-2-daniel.vetter@ffwll.ch> Subject: Re: [Intel-gfx] [PATCH 2/8] drm/arm/malidp: Always list modifiers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pekka Paalanen , Intel Graphics Development , stable@vger.kernel.org, DRI Development , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gVHVlLCBBcHIgMjcsIDIwMjEgYXQgMTE6MjA6MTJBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBFdmVuIHdoZW4gYWxsIHdlIHN1cHBvcnQgaXMgbGluZWFyLCBtYWtlIHRoYXQgZXhw bGljaXQuIE90aGVyd2lzZSB0aGUKPiB1YXBpIGlzIHJhdGhlciBjb25mdXNpbmcuCgo6KQoKPiAK PiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+IENjOiBQZWtrYSBQYWFsYW5lbiA8cGVra2Eu cGFhbGFuZW5AY29sbGFib3JhLmNvbT4KPiBDYzogTGl2aXUgRHVkYXUgPGxpdml1LmR1ZGF1QGFy bS5jb20+Cj4gQ2M6IEJyaWFuIFN0YXJrZXkgPGJyaWFuLnN0YXJrZXlAYXJtLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KCkFja2Vk LWJ5OiBMaXZpdSBEdWRhdSA8bGl2aXUuZHVkYXVAYXJtLmNvbT4KCkJlc3QgcmVnYXJkcywKTGl2 aXUKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX3BsYW5lcy5jIHwgOSArKysr KysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfcGxhbmVzLmMgYi9k cml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9wbGFuZXMuYwo+IGluZGV4IGRkYmJhNjdmMDI4My4u OGMyYWIzZDY1M2I3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX3Bs YW5lcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfcGxhbmVzLmMKPiBAQCAt OTI3LDYgKzkyNywxMSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9oZWxwZXJfZnVu Y3MgbWFsaWRwX2RlX3BsYW5lX2hlbHBlcl9mdW5jcyA9IHsKPiAgCS5hdG9taWNfZGlzYWJsZSA9 IG1hbGlkcF9kZV9wbGFuZV9kaXNhYmxlLAo+ICB9Owo+ICAKPiArc3RhdGljIGNvbnN0IHVpbnQ2 NF90IGxpbmVhcl9vbmx5X21vZGlmaWVyc1tdID0gewo+ICsJRFJNX0ZPUk1BVF9NT0RfTElORUFS LAo+ICsJRFJNX0ZPUk1BVF9NT0RfSU5WQUxJRAo+ICt9Owo+ICsKPiAgaW50IG1hbGlkcF9kZV9w bGFuZXNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKQo+ICB7Cj4gIAlzdHJ1Y3QgbWFsaWRw X2RybSAqbWFsaWRwID0gZHJtLT5kZXZfcHJpdmF0ZTsKPiBAQCAtOTkwLDggKzk5NSw4IEBAIGlu dCBtYWxpZHBfZGVfcGxhbmVzX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRybSkKPiAgCQkgKi8K PiAgCQlyZXQgPSBkcm1fdW5pdmVyc2FsX3BsYW5lX2luaXQoZHJtLCAmcGxhbmUtPmJhc2UsIGNy dGNzLAo+ICAJCQkJJm1hbGlkcF9kZV9wbGFuZV9mdW5jcywgZm9ybWF0cywgbiwKPiAtCQkJCShp ZCA9PSBERV9TTUFSVCkgPyBOVUxMIDogbW9kaWZpZXJzLCBwbGFuZV90eXBlLAo+IC0JCQkJTlVM TCk7Cj4gKwkJCQkoaWQgPT0gREVfU01BUlQpID8gbGluZWFyX29ubHlfbW9kaWZpZXJzIDogbW9k aWZpZXJzLAo+ICsJCQkJcGxhbmVfdHlwZSwgTlVMTCk7Cj4gIAo+ICAJCWlmIChyZXQgPCAwKQo+ ICAJCQlnb3RvIGNsZWFudXA7Cj4gLS0gCj4gMi4zMS4wCj4gCgotLSAKPT09PT09PT09PT09PT09 PT09PT0KfCBJIHdvdWxkIGxpa2UgdG8gfAp8IGZpeCB0aGUgd29ybGQsICB8CnwgYnV0IHRoZXkn cmUgbm90IHwKfCBnaXZpbmcgbWUgdGhlICAgfAogXCBzb3VyY2UgY29kZSEgIC8KICAtLS0tLS0t LS0tLS0tLS0KICAgIMKvXF8o44OEKV8vwq8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==