From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0510AC433B4 for ; Tue, 27 Apr 2021 16:50:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF48B613EB for ; Tue, 27 Apr 2021 16:50:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237715AbhD0QvO (ORCPT ); Tue, 27 Apr 2021 12:51:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:39340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236405AbhD0QvN (ORCPT ); Tue, 27 Apr 2021 12:51:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2D9DA613D9; Tue, 27 Apr 2021 16:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619542229; bh=Rp3gOPPwFf3EOQNq77Ku+vQ5D/s8YJR3r46OhoSn6TE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eE6sE5zVPxxXw7tz0MyS0diFqLULPzrPskTO4stOvboH0PgUfqhlm/FmFxdt6BbWZ e5pqsGV8UNqCsaNMd0rq0OtQ3N7OZXfspguoS5RvMKm2K40tF+EIN0aLxba1I83ySn zAZpE3DnfCjI7D/Fi9suo7EtJweMnKvHjqrIsrwI= Date: Tue, 27 Apr 2021 18:50:27 +0200 From: Greg Kroah-Hartman To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, Kangjie Lu , "David S . Miller" Subject: Re: [PATCH 170/190] Revert "net: dsa: bcm_sf2: Propagate error value from mdio_write" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-171-gregkh@linuxfoundation.org> <30b2efa4-f873-a391-00c7-f1eb278a3db1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30b2efa4-f873-a391-00c7-f1eb278a3db1@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 04:20:24PM -0700, Florian Fainelli wrote: > > > On 4/21/2021 6:00 AM, Greg Kroah-Hartman wrote: > > This reverts commit e49505f7255be8ced695919c08a29bf2c3d79616. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu > > Cc: David S. Miller > > Signed-off-by: Greg Kroah-Hartman > > While this commit does not fix a known problem, the driver should have > arguably propagated the return values and it did not, so I would be > inclined to keep it. Looks good, I'll drop my revert, thanks for the review. greg k-h