From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1871C43460 for ; Tue, 27 Apr 2021 17:20:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93134613D0 for ; Tue, 27 Apr 2021 17:20:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236599AbhD0RUz (ORCPT ); Tue, 27 Apr 2021 13:20:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:34246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235647AbhD0RUy (ORCPT ); Tue, 27 Apr 2021 13:20:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BFF80613DC; Tue, 27 Apr 2021 17:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619544009; bh=zTDfkBlhzaw3mRPFZOF8YBGAy6SJ6egNfmcUdq7dV7E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r/A22uVISgT59GGjSXX5oORcYXIWLPfUzpCb1ND+S5HVrjtZJcAyYJm7CUZZLx6QJ y1zERveu++1+6qbdNnjDcBmxUVaYxh3PyR5ULG0I0YNT5Qm1zBesvF6tj0gCeXQ5v8 HqP0ROUfcYTv0pr4uavOlR5idc6Wgy8NqAfcYwLw= Date: Tue, 27 Apr 2021 19:20:07 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Kangjie Lu , Manish Rangankar , Mukesh Ojha , "Martin K . Petersen" Subject: Re: [PATCH 110/190] Revert "scsi: qla4xxx: fix a potential NULL pointer dereference" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-111-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-111-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 02:59:45PM +0200, Greg Kroah-Hartman wrote: > This reverts commit fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu > Cc: Manish Rangankar > Cc: Mukesh Ojha > Cc: Martin K. Petersen > Signed-off-by: Greg Kroah-Hartman > --- > drivers/scsi/qla4xxx/ql4_os.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c > index 7bd9a4a04ad5..5cb0dfe7a83b 100644 > --- a/drivers/scsi/qla4xxx/ql4_os.c > +++ b/drivers/scsi/qla4xxx/ql4_os.c > @@ -3229,8 +3229,6 @@ static int qla4xxx_conn_bind(struct iscsi_cls_session *cls_session, > if (iscsi_conn_bind(cls_session, cls_conn, is_leading)) > return -EINVAL; > ep = iscsi_lookup_endpoint(transport_fd); > - if (!ep) > - return -EINVAL; > conn = cls_conn->dd_data; > qla_conn = conn->dd_data; > qla_conn->qla_ep = ep->dd_data; > -- > 2.31.1 > Looks to be correct. Odd that you do not have to "unbind" after calling iscsi_conn_bind(), but hey, it's scsi functions, they are always odd :) I'll drop this revert. greg k-h