From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC41C433B4 for ; Tue, 27 Apr 2021 18:14:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D17861153 for ; Tue, 27 Apr 2021 18:14:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238416AbhD0SPd (ORCPT ); Tue, 27 Apr 2021 14:15:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:39910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230219AbhD0SPb (ORCPT ); Tue, 27 Apr 2021 14:15:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3B99F613EA; Tue, 27 Apr 2021 18:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619547286; bh=p9VYaptoIh7qUXpbZLLRQsuXGmczzPkzM8cN3UCnuUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JgmIMoHUa6FeBEEZtPQkp101shNytCAmGV4+18SLe9AmN00KNbL8RV30emx+P6osY o/dnGgyKngAoxIta1rage2Vqoo542Oz+iPHwz0ZYg2cYrAdK0ih7bo9shfynR0GQg+ vPC6BxdbWSBwORfdPzZGSPnaoNB597PJ+07Ooeu4= Date: Tue, 27 Apr 2021 20:14:44 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Aditya Pakki , Vinod Koul Subject: Re: [PATCH 163/190] Revert "dmaengine: mv_xor: Fix a missing check in mv_xor_channel_add" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-164-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-164-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 03:00:38PM +0200, Greg Kroah-Hartman wrote: > This reverts commit 7c97381e7a9a5ec359007c0d491a143e3d9f787c. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Aditya Pakki > Cc: Vinod Koul > Signed-off-by: Greg Kroah-Hartman > --- > drivers/dma/mv_xor.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c > index 23b232b57518..78bd52565571 100644 > --- a/drivers/dma/mv_xor.c > +++ b/drivers/dma/mv_xor.c > @@ -1144,10 +1144,7 @@ mv_xor_channel_add(struct mv_xor_device *xordev, > dma_has_cap(DMA_MEMCPY, dma_dev->cap_mask) ? "cpy " : "", > dma_has_cap(DMA_INTERRUPT, dma_dev->cap_mask) ? "intr " : ""); > > - ret = dma_async_device_register(dma_dev); > - if (ret) > - goto err_free_irq; > - > + dma_async_device_register(dma_dev); > return mv_chan; > > err_free_irq: > -- > 2.31.1 > The original commit here is correct, I will drop this revert. greg k-h