From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB9BC433ED for ; Wed, 28 Apr 2021 07:13:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C736E601FC for ; Wed, 28 Apr 2021 07:13:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236577AbhD1HOm (ORCPT ); Wed, 28 Apr 2021 03:14:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:60516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233399AbhD1HOi (ORCPT ); Wed, 28 Apr 2021 03:14:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 45DF3601FC; Wed, 28 Apr 2021 07:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619594032; bh=w/W3vrIM8knPgW8Hlp2cfjO6vK2wDnkWqpxPicgzPEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UL2AJEoIAUVyl2bYbXiV+LZxKoNVgBjC75cGqnkETWQD/9Zwp8XeC0L1YW7iV8LiH NHidH1tL8gj7kEHt6i9PGJvPDubl2YMDhQMYD93eQMi1ZThez9dLF8j+9cmYlsekAA S2KnvZzFZuKd0bSiEJtoChyV0Q9Ddh46ZYR48lxI= Date: Wed, 28 Apr 2021 09:13:50 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Qiushi Wu , "David S . Miller" Subject: Re: [PATCH 043/190] Revert "qlcnic: fix missing release in qlcnic_83xx_interrupt_test." Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-44-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-44-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 02:58:38PM +0200, Greg Kroah-Hartman wrote: > This reverts commit 15c973858903009e995b2037683de29dfe968621. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Qiushi Wu > Cc: David S. Miller > Signed-off-by: Greg Kroah-Hartman > --- > drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c > index d8882d0b6b49..edefeeff60f4 100644 > --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c > +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c > @@ -3649,7 +3649,7 @@ int qlcnic_83xx_interrupt_test(struct net_device *netdev) > ahw->diag_cnt = 0; > ret = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_INTRPT_TEST); > if (ret) > - goto fail_mbx_args; > + goto fail_diag_irq; > > if (adapter->flags & QLCNIC_MSIX_ENABLED) > intrpt_id = ahw->intr_tbl[0].id; > @@ -3679,8 +3679,6 @@ int qlcnic_83xx_interrupt_test(struct net_device *netdev) > > done: > qlcnic_free_mbx_args(&cmd); > - > -fail_mbx_args: > qlcnic_83xx_diag_free_res(netdev, drv_sds_rings); > > fail_diag_irq: > -- > 2.31.1 > The original change here looks correct, I will drop the revert. greg k-h