From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 962CDC433B4 for ; Wed, 28 Apr 2021 08:42:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A29D613B1 for ; Wed, 28 Apr 2021 08:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237666AbhD1Imz (ORCPT ); Wed, 28 Apr 2021 04:42:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237143AbhD1Imx (ORCPT ); Wed, 28 Apr 2021 04:42:53 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D897C061574 for ; Wed, 28 Apr 2021 01:42:09 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2791C2C1; Wed, 28 Apr 2021 10:42:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1619599326; bh=eIKOtb0EwVMW8rF2TDb6io7j7TuJD3/NY/qCSlvVNG0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eGkxOVmepCbC4IZxdYxGlmJ7HbfiujAcvbwCqAFEvboBnePzCLqgK6rzhZc2Y1vyr KOK4ViLGV2Gt7OhlF0C/35k03V5lExNQ9U+S9PmF+UGhTq+1cerGRTU9KkeSXOv2sX GsWZ4cE7PDt0LeF80ZymrtJcoNYa10zcbZXDS3Hw= Date: Wed, 28 Apr 2021 11:42:00 +0300 From: Laurent Pinchart To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Kangjie Lu , Ulf Hansson Subject: Re: [PATCH 088/190] Revert "mmc_spi: add a status check for spi_sync_locked" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-89-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Wed, Apr 28, 2021 at 09:18:18AM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 21, 2021 at 04:19:07PM +0300, Laurent Pinchart wrote: > > On Wed, Apr 21, 2021 at 02:59:23PM +0200, Greg Kroah-Hartman wrote: > > > This reverts commit 611025983b7976df0183390a63a2166411d177f1. > > > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > > faith" to try to test the kernel community's ability to review "known > > > malicious" changes. The result of these submissions can be found in a > > > paper published at the 42nd IEEE Symposium on Security and Privacy > > > entitled, "Open Source Insecurity: Stealthily Introducing > > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > > > Because of this, all submissions from this group must be reverted from > > > the kernel tree and will need to be re-reviewed again to determine if > > > they actually are a valid fix. Until that work is complete, remove this > > > change to ensure that no problems are being introduced into the > > > codebase. > > > > > > Cc: Kangjie Lu > > > Cc: Laurent Pinchart > > > Cc: Ulf Hansson > > > Signed-off-by: Greg Kroah-Hartman > > > > Acked-by: Laurent Pinchart > > Thanks for the review! > > > I don't spot an obvious issue with the original patch though. > > Ulf did :) I've replied separately, I still think it's not an issue :-) -- Regards, Laurent Pinchart