From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412E5C433B4 for ; Wed, 28 Apr 2021 12:22:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2F3E61419 for ; Wed, 28 Apr 2021 12:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234674AbhD1MWr (ORCPT ); Wed, 28 Apr 2021 08:22:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:55058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234356AbhD1MWr (ORCPT ); Wed, 28 Apr 2021 08:22:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8375961413; Wed, 28 Apr 2021 12:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619612522; bh=0yfljeWZf/as7id/4Rzh3FTtgepJ+ZlD02AKERVNKqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jVifndFDWJO/+GH5bcXQ7bxdkv+S5kJ0UicYordngtWO8yRrwI5QdlRCBukK9sZ2N OC4ggMRYH8P5ie9AhCiHcXA8UdgLcbXDd3q6O0HIfyoDSGYgg7LBcipPYo9DPjePr7 0i+H4JblAAfSDDa9GHI/K35unnKX6mDtzZq5mXixEnCMqy/vT9FF83FxwOfwKc6i09 hLQ/iewqS/9TZNYrQY0rjRya6nVhQ0IvncI6C3dHZ+eJka8vUx0I9IkosoYuPAmXkQ bZDGUbiSjiv/hBhnR4Uij06meZ4UnS9ta4hFLBCuQ5f8axNt+Mf59nl0a5edWMh2oh QoAZFs/DMnXSw== Date: Wed, 28 Apr 2021 15:21:55 +0300 From: Leon Romanovsky To: Jaroslav Kysela Cc: bkkarthik , Anupama K Patil , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, gregkh@linuxfoundation.org, kernelnewbies@kernelnewbies.org Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices Message-ID: References: <20210424194301.jmsqpycvsm7izbk3@ubuntu> <20210426175031.w26ovnffjiow346h@burgerking> <59a5d631-6658-2034-06c4-467520b5b9f7@perex.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59a5d631-6658-2034-06c4-467520b5b9f7@perex.cz> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Apr 28, 2021 at 02:04:49PM +0200, Jaroslav Kysela wrote: > Dne 26. 04. 21 v 19:50 bkkarthik napsal(a): > > On 21/04/26 08:04AM, Leon Romanovsky wrote: > >> On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote: > >>> isapnp_proc_init() does not look at the return value from > >>> isapnp_proc_attach_device(). Check for this return value in > >>> isapnp_proc_detach_device(). > >>> > >>> Cleanup in isapnp_proc_detach_device and > >>> isapnp_proc_detach_bus() for cleanup. > >>> > >>> Changed sprintf() to the kernel-space function scnprintf() as it returns > >>> the actual number of bytes written. > >>> > >>> Removed unnecessary variables de, e of type 'struct proc_dir_entry' to > >>> save memory. > >> > >> What exactly do you fix for such an old code? > > > > I was not aware that this code is so old. This fix was made after checkpatch reported assignment inside an if-statement. > > Please ignore this patch if th change is not necessary as the code is probably not being used anywhere :) > > > > Maybe the code has to be marked as obsolete in the MAINTAINERS file to prevent patches being sent? > > > >> > >>> > >>> Suggested-by: Shuah Khan > >>> Co-developed-by: B K Karthik > >>> Signed-off-by: B K Karthik > >>> Signed-off-by: Anupama K Patil > >>> --- > >>> drivers/pnp/isapnp/proc.c | 40 +++++++++++++++++++++++++++++---------- > >>> 1 file changed, 30 insertions(+), 10 deletions(-) > >>> > >>> diff --git a/drivers/pnp/isapnp/proc.c b/drivers/pnp/isapnp/proc.c > >>> index 785a796430fa..46ebc24175b7 100644 > >>> --- a/drivers/pnp/isapnp/proc.c > >>> +++ b/drivers/pnp/isapnp/proc.c > >>> @@ -54,34 +54,54 @@ static const struct proc_ops isapnp_proc_bus_proc_ops = { > >>> .proc_read = isapnp_proc_bus_read, > >>> }; > >>> > >>> +static int isapnp_proc_detach_device(struct pnp_dev *dev) > >>> +{ > >>> + proc_remove(dev->procent); > >>> + dev->procent = NULL; > >>> + return 0; > >>> +} > >>> + > >>> +static int isapnp_proc_detach_bus(struct pnp_card *bus) > >>> +{ > >>> + proc_remove(bus->procdir); > >>> + return 0; > >>> +} > >> > >> Please don't add one line functions that are called only once and have > >> return value that no one care about it. > > > > These were only intended for a clean-up job, the idea of this function came from how PCI handles procfs. > > Maybe those should be changed? > > Which code you refer? I see: > > for_each_pci_dev(dev) > pci_proc_attach_device(dev); He talks about isapnp_proc_detach_*() functions. > > > The error codes are ignored, too. It does not harm, if proc entries are not > created (in this case - the system is unstable anyway). We should concentrate > only to the wrong pointers usage. > > Jaroslav > > -- > Jaroslav Kysela > Linux Sound Maintainer; ALSA Project; Red Hat, Inc. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D499C43460 for ; Wed, 28 Apr 2021 12:22:10 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B523261419 for ; Wed, 28 Apr 2021 12:22:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B523261419 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1lbjCh-0002yQ-DL; Wed, 28 Apr 2021 08:22:07 -0400 Received: from mail.kernel.org ([198.145.29.99]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lbjCf-0002y4-H4 for kernelnewbies@kernelnewbies.org; Wed, 28 Apr 2021 08:22:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8375961413; Wed, 28 Apr 2021 12:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619612522; bh=0yfljeWZf/as7id/4Rzh3FTtgepJ+ZlD02AKERVNKqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jVifndFDWJO/+GH5bcXQ7bxdkv+S5kJ0UicYordngtWO8yRrwI5QdlRCBukK9sZ2N OC4ggMRYH8P5ie9AhCiHcXA8UdgLcbXDd3q6O0HIfyoDSGYgg7LBcipPYo9DPjePr7 0i+H4JblAAfSDDa9GHI/K35unnKX6mDtzZq5mXixEnCMqy/vT9FF83FxwOfwKc6i09 hLQ/iewqS/9TZNYrQY0rjRya6nVhQ0IvncI6C3dHZ+eJka8vUx0I9IkosoYuPAmXkQ bZDGUbiSjiv/hBhnR4Uij06meZ4UnS9ta4hFLBCuQ5f8axNt+Mf59nl0a5edWMh2oh QoAZFs/DMnXSw== Date: Wed, 28 Apr 2021 15:21:55 +0300 From: Leon Romanovsky To: Jaroslav Kysela Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices Message-ID: References: <20210424194301.jmsqpycvsm7izbk3@ubuntu> <20210426175031.w26ovnffjiow346h@burgerking> <59a5d631-6658-2034-06c4-467520b5b9f7@perex.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <59a5d631-6658-2034-06c4-467520b5b9f7@perex.cz> Cc: gregkh@linuxfoundation.org, Anupama K Patil , "Rafael J. Wysocki" , bkkarthik , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, kernelnewbies@kernelnewbies.org, skhan@linuxfoundation.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Wed, Apr 28, 2021 at 02:04:49PM +0200, Jaroslav Kysela wrote: > Dne 26. 04. 21 v 19:50 bkkarthik napsal(a): > > On 21/04/26 08:04AM, Leon Romanovsky wrote: > >> On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote: > >>> isapnp_proc_init() does not look at the return value from > >>> isapnp_proc_attach_device(). Check for this return value in > >>> isapnp_proc_detach_device(). > >>> > >>> Cleanup in isapnp_proc_detach_device and > >>> isapnp_proc_detach_bus() for cleanup. > >>> > >>> Changed sprintf() to the kernel-space function scnprintf() as it returns > >>> the actual number of bytes written. > >>> > >>> Removed unnecessary variables de, e of type 'struct proc_dir_entry' to > >>> save memory. > >> > >> What exactly do you fix for such an old code? > > > > I was not aware that this code is so old. This fix was made after checkpatch reported assignment inside an if-statement. > > Please ignore this patch if th change is not necessary as the code is probably not being used anywhere :) > > > > Maybe the code has to be marked as obsolete in the MAINTAINERS file to prevent patches being sent? > > > >> > >>> > >>> Suggested-by: Shuah Khan > >>> Co-developed-by: B K Karthik > >>> Signed-off-by: B K Karthik > >>> Signed-off-by: Anupama K Patil > >>> --- > >>> drivers/pnp/isapnp/proc.c | 40 +++++++++++++++++++++++++++++---------- > >>> 1 file changed, 30 insertions(+), 10 deletions(-) > >>> > >>> diff --git a/drivers/pnp/isapnp/proc.c b/drivers/pnp/isapnp/proc.c > >>> index 785a796430fa..46ebc24175b7 100644 > >>> --- a/drivers/pnp/isapnp/proc.c > >>> +++ b/drivers/pnp/isapnp/proc.c > >>> @@ -54,34 +54,54 @@ static const struct proc_ops isapnp_proc_bus_proc_ops = { > >>> .proc_read = isapnp_proc_bus_read, > >>> }; > >>> > >>> +static int isapnp_proc_detach_device(struct pnp_dev *dev) > >>> +{ > >>> + proc_remove(dev->procent); > >>> + dev->procent = NULL; > >>> + return 0; > >>> +} > >>> + > >>> +static int isapnp_proc_detach_bus(struct pnp_card *bus) > >>> +{ > >>> + proc_remove(bus->procdir); > >>> + return 0; > >>> +} > >> > >> Please don't add one line functions that are called only once and have > >> return value that no one care about it. > > > > These were only intended for a clean-up job, the idea of this function came from how PCI handles procfs. > > Maybe those should be changed? > > Which code you refer? I see: > > for_each_pci_dev(dev) > pci_proc_attach_device(dev); He talks about isapnp_proc_detach_*() functions. > > > The error codes are ignored, too. It does not harm, if proc entries are not > created (in this case - the system is unstable anyway). We should concentrate > only to the wrong pointers usage. > > Jaroslav > > -- > Jaroslav Kysela > Linux Sound Maintainer; ALSA Project; Red Hat, Inc. _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies