From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FEB6C433ED for ; Thu, 29 Apr 2021 01:45:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0293761456 for ; Thu, 29 Apr 2021 01:45:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232702AbhD2Bq3 (ORCPT ); Wed, 28 Apr 2021 21:46:29 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:41416 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231564AbhD2Bq3 (ORCPT ); Wed, 28 Apr 2021 21:46:29 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D3FAABC0; Thu, 29 Apr 2021 03:45:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1619660743; bh=ghGPA7bLKWBj8eAZ1z2kTg/MH2bN8pJIyC0ohrv5qe0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b4rwszH237F+CJCKE+Db6ZzJQUzmi/PRRgk8viPK+JvJwZwXC1Zh1XsFrmjIn7H24 lFBa7RFNW81T4sOxDsxkef39lR5oSXnyNer7FTDVaOF81FzijAqVr7F6yjq1pyOWQT WpgOH1grbbwV8/46/B2vUPfVMxPm+/eDEgznvwwM= Date: Thu, 29 Apr 2021 04:45:37 +0300 From: Laurent Pinchart To: Marco Felsch Cc: p.zabel@pengutronix.de, mchehab@kernel.org, slongerbeam@gmail.com, hverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 2/6] media: v4l: Add definition for bayered IR formats Message-ID: References: <20210427120701.21809-1-m.felsch@pengutronix.de> <20210427120701.21809-3-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210427120701.21809-3-m.felsch@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Marco, Thank you for the patch. On Tue, Apr 27, 2021 at 02:06:57PM +0200, Marco Felsch wrote: > Add special 8/12bit bayer media bus format for the OnSemi AR0237IR > camera sensor [1]. OnSemi calls this format RGB-IR, the pixel array > with the interleaved IR pixels looks like: > > | G | R | G | B | ... > +----+----+----+----+--- > | IR | G | IR | G | ... > +----+----+----+----+--- > | G | B | G | R | ... > +----+----+----+----+--- > | IR | G | IR | G | ... > +----+----+----+----+--- > | .. | .. | .. | .. | .. > > [1] https://www.framos.com/media/pdf/96/ac/8f/AR0237CS-D-PDF-framos.pdf > > Signed-off-by: Marco Felsch > Reviewed-by: Philipp Zabel > --- > include/uapi/linux/videodev2.h | 4 ++++ The documentation is missing. > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 311a01cc5775..45ffd3867394 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -632,6 +632,8 @@ struct v4l2_pix_format { > #define V4L2_PIX_FMT_SGBRG8 v4l2_fourcc('G', 'B', 'R', 'G') /* 8 GBGB.. RGRG.. */ > #define V4L2_PIX_FMT_SGRBG8 v4l2_fourcc('G', 'R', 'B', 'G') /* 8 GRGR.. BGBG.. */ > #define V4L2_PIX_FMT_SRGGB8 v4l2_fourcc('R', 'G', 'G', 'B') /* 8 RGRG.. GBGB.. */ > + /* 8bit infrared interleaved bayer format */ > +#define V4L2_PIX_FMT_SGRGB_IGIG_GBGR_IGIG8 v4l2_fourcc('I', 'R', '0', '8') /* 8 GRGB.. IGIG.. GBGR.. IGIG.. */ > #define V4L2_PIX_FMT_SBGGR10 v4l2_fourcc('B', 'G', '1', '0') /* 10 BGBG.. GRGR.. */ > #define V4L2_PIX_FMT_SGBRG10 v4l2_fourcc('G', 'B', '1', '0') /* 10 GBGB.. RGRG.. */ > #define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10 GRGR.. BGBG.. */ > @@ -673,6 +675,8 @@ struct v4l2_pix_format { > #define V4L2_PIX_FMT_SGBRG16 v4l2_fourcc('G', 'B', '1', '6') /* 16 GBGB.. RGRG.. */ > #define V4L2_PIX_FMT_SGRBG16 v4l2_fourcc('G', 'R', '1', '6') /* 16 GRGR.. BGBG.. */ > #define V4L2_PIX_FMT_SRGGB16 v4l2_fourcc('R', 'G', '1', '6') /* 16 RGRG.. GBGB.. */ > + /* 16bit infrared interleaved bayer format */ > +#define V4L2_PIX_FMT_SGRGB_IGIG_GBGR_IGIG16 v4l2_fourcc('I', 'R', '1', '6') /* 16 GRGB.. IGIG.. GBGR.. IGIG.. */ > > /* HSV formats */ > #define V4L2_PIX_FMT_HSV24 v4l2_fourcc('H', 'S', 'V', '3') -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB676C433B4 for ; Thu, 29 Apr 2021 01:48:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4777461412 for ; Thu, 29 Apr 2021 01:48:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4777461412 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4wJSYifacB2xc7PEBGrs6YldPx4jngvd93xTaCgppqs=; b=m8z98OaHNTqbQ6bHUoRZwVT0L G3tkhmFz8fmMft4qCMk0n8F357T7zhsq7108pIrJl9c+QaPjBOB1w/A8NDfoVVLxmiT7jl5PyjWro spg5rPZiyN9wIh0U1LCyw4bbK+2zSR1Gel2mXrz6vzncIrUJflyDEBBeFytgPqBVS0tTrL328ARL1 9zNKnSdqIeRqOh/DyeZRW6hF999R4W2hJKGVn+T+DGOU9Pz3RoejWViKMntrqM8kxQvhhR3KeBfqg jTjdCOoWyJEj4hYIctjCsvtJ0gByU407XIn4dReYqJS26lFCmJhbyMwJ23mW4a6y3nJOQUDBegWo1 CJMhe5fzQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbvke-004e4D-K8; Thu, 29 Apr 2021 01:46:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbvkb-004e3o-TD for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 01:45:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Yc9mM4pMralGG0s+RW2EXhFaRTQjuSZ7mXhhYKKctHg=; b=SEneeZPz69gZWZfXBMyj3AfSzn u6qGXzbvRPWet7Q0pgcph6Sbr3vBmjb1crt7Ul95ghYlBME0U1KXWM/y/nCKsthH+QZQOkCTAjtbg Plky7kjQosh+GkpJoqtzMhUqbhiDVWFKpRhRoyxLGBLSWFfK9pXv9sb6J8DlKsTIcnRXCbRRs++bU 5ciVWaQuYtrP5JxxSF20Cw7U4ihEUeuRPvXzAhtgLr3rdCGo62djk/TJhirn6NUFVSd0xAc+eRfZi dfpspZDqt4G/VE5DEnS38AivjbDqg+bBfeo6V3G7QMlttr5eVoe/xPefg1BbFyrlbkU0+TJLOGDrV CvuVyC7Q==; Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbvkZ-000JbM-1B for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 01:45:56 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D3FAABC0; Thu, 29 Apr 2021 03:45:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1619660743; bh=ghGPA7bLKWBj8eAZ1z2kTg/MH2bN8pJIyC0ohrv5qe0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b4rwszH237F+CJCKE+Db6ZzJQUzmi/PRRgk8viPK+JvJwZwXC1Zh1XsFrmjIn7H24 lFBa7RFNW81T4sOxDsxkef39lR5oSXnyNer7FTDVaOF81FzijAqVr7F6yjq1pyOWQT WpgOH1grbbwV8/46/B2vUPfVMxPm+/eDEgznvwwM= Date: Thu, 29 Apr 2021 04:45:37 +0300 From: Laurent Pinchart To: Marco Felsch Cc: p.zabel@pengutronix.de, mchehab@kernel.org, slongerbeam@gmail.com, hverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 2/6] media: v4l: Add definition for bayered IR formats Message-ID: References: <20210427120701.21809-1-m.felsch@pengutronix.de> <20210427120701.21809-3-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210427120701.21809-3-m.felsch@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_184555_252862_1FFCF263 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marco, Thank you for the patch. On Tue, Apr 27, 2021 at 02:06:57PM +0200, Marco Felsch wrote: > Add special 8/12bit bayer media bus format for the OnSemi AR0237IR > camera sensor [1]. OnSemi calls this format RGB-IR, the pixel array > with the interleaved IR pixels looks like: > > | G | R | G | B | ... > +----+----+----+----+--- > | IR | G | IR | G | ... > +----+----+----+----+--- > | G | B | G | R | ... > +----+----+----+----+--- > | IR | G | IR | G | ... > +----+----+----+----+--- > | .. | .. | .. | .. | .. > > [1] https://www.framos.com/media/pdf/96/ac/8f/AR0237CS-D-PDF-framos.pdf > > Signed-off-by: Marco Felsch > Reviewed-by: Philipp Zabel > --- > include/uapi/linux/videodev2.h | 4 ++++ The documentation is missing. > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 311a01cc5775..45ffd3867394 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -632,6 +632,8 @@ struct v4l2_pix_format { > #define V4L2_PIX_FMT_SGBRG8 v4l2_fourcc('G', 'B', 'R', 'G') /* 8 GBGB.. RGRG.. */ > #define V4L2_PIX_FMT_SGRBG8 v4l2_fourcc('G', 'R', 'B', 'G') /* 8 GRGR.. BGBG.. */ > #define V4L2_PIX_FMT_SRGGB8 v4l2_fourcc('R', 'G', 'G', 'B') /* 8 RGRG.. GBGB.. */ > + /* 8bit infrared interleaved bayer format */ > +#define V4L2_PIX_FMT_SGRGB_IGIG_GBGR_IGIG8 v4l2_fourcc('I', 'R', '0', '8') /* 8 GRGB.. IGIG.. GBGR.. IGIG.. */ > #define V4L2_PIX_FMT_SBGGR10 v4l2_fourcc('B', 'G', '1', '0') /* 10 BGBG.. GRGR.. */ > #define V4L2_PIX_FMT_SGBRG10 v4l2_fourcc('G', 'B', '1', '0') /* 10 GBGB.. RGRG.. */ > #define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10 GRGR.. BGBG.. */ > @@ -673,6 +675,8 @@ struct v4l2_pix_format { > #define V4L2_PIX_FMT_SGBRG16 v4l2_fourcc('G', 'B', '1', '6') /* 16 GBGB.. RGRG.. */ > #define V4L2_PIX_FMT_SGRBG16 v4l2_fourcc('G', 'R', '1', '6') /* 16 GRGR.. BGBG.. */ > #define V4L2_PIX_FMT_SRGGB16 v4l2_fourcc('R', 'G', '1', '6') /* 16 RGRG.. GBGB.. */ > + /* 16bit infrared interleaved bayer format */ > +#define V4L2_PIX_FMT_SGRGB_IGIG_GBGR_IGIG16 v4l2_fourcc('I', 'R', '1', '6') /* 16 GRGB.. IGIG.. GBGR.. IGIG.. */ > > /* HSV formats */ > #define V4L2_PIX_FMT_HSV24 v4l2_fourcc('H', 'S', 'V', '3') -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel