From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Thu, 29 Apr 2021 08:52:49 +0200 Subject: [LTP] [PATCH v3] commands/lsmod01.sh: Replace tst_res with tst_brk In-Reply-To: <20210429020922.24085-1-zhaogongyi@huawei.com> References: <20210429020922.24085-1-zhaogongyi@huawei.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi, > We need replace tst_res with tst_brk to terminate the test immediately since > there is no sence to go on. > Signed-off-by: Zhao Gongyi > --- > v2->v3: split into two separate commits > testcases/commands/lsmod/lsmod01.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/testcases/commands/lsmod/lsmod01.sh b/testcases/commands/lsmod/lsmod01.sh > index 2e044c718..4ed91eca5 100755 > --- a/testcases/commands/lsmod/lsmod01.sh > +++ b/testcases/commands/lsmod/lsmod01.sh > @@ -23,7 +23,7 @@ setup() > tst_require_cmds insmod > insmod "$TST_MODPATH" > if [ $? -ne 0 ]; then > - tst_res TBROK "insmod failed" > + tst_brk TBROK "insmod failed" > return There does not need to be return (in cleanup function tst_brk just prints warning and continues, but elsewhere it just quits). I'll fix that during merge. Reviewed-by: Petr Vorel Kind regards, Petr