From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97EA7C433ED for ; Thu, 29 Apr 2021 07:05:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CF7960241 for ; Thu, 29 Apr 2021 07:05:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239583AbhD2HGI (ORCPT ); Thu, 29 Apr 2021 03:06:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:60634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239591AbhD2HGD (ORCPT ); Thu, 29 Apr 2021 03:06:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8D0036141E; Thu, 29 Apr 2021 07:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619679917; bh=GCQlMJMfukGtOitamxhM95nYZIGfkCAILI+JTYjvq54=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hq9y3u89XB8wff9zbfx+aYL0qQ3C1HiyviyZwZnh158O+ObPtXCcwUTso3/eI/av5 LJ3Nd+yRNy0UMHqKLJdcKJ9oTPIT5Y54nXVC8JQDhpAQlKxS/neJf3Sca5Xjr2YIw5 r0q/TSv2ijoUQEPEvc3Q9pnbWx7bWvd4CUNOSpCoYyAosVTSDJOAlPO4Mp+IF+3BOM Eph42q03aTR/iDP9vuC9CewSSsBgMV6UMyy+Gxdjo/2qX/QrnVuQ4kLd+Z3NJl1HGB icHODrlhj/LZY2k1QY5c0miDpqHDbeAHzj87jUMVYKG697waBg+RgUQec2bD3Rae/v Xoi4mtHXTqz0Q== Date: Thu, 29 Apr 2021 10:05:13 +0300 From: Leon Romanovsky To: Valdis =?utf-8?Q?Kl=C4=93tnieks?= Cc: bkkarthik , Anupama K Patil , Jaroslav Kysela , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, gregkh@linuxfoundation.org, kernelnewbies@kernelnewbies.org Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices Message-ID: References: <20210424194301.jmsqpycvsm7izbk3@ubuntu> <20210426175031.w26ovnffjiow346h@burgerking> <210271.1619670673@turing-police> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <210271.1619670673@turing-police> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Apr 29, 2021 at 12:31:13AM -0400, Valdis Kl=C4=93tnieks wrote: > On Tue, 27 Apr 2021 07:26:27 +0300, Leon Romanovsky said: > > On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote: > > > These were only intended for a clean-up job, the idea of this functio= n came from how PCI handles procfs. > > > Maybe those should be changed? > > > > Probably, the CONFIG_PROC_FS around pci_proc_*() is not needed too. >=20 > Will that actually build correctly if it's an embedded system or somethin= g build with > CONFIG_PROC_FS=3Dn? I'd expect that to die a horrid death while linking = vmlinx due > to stuff inside that #ifdef calling symbols only present with PROC_FS=3Dm= /y. We are talking about pci_proc_detach_device() and pci_proc_detach_bus() her= e. They will build perfectly without CONFIG_PROC_FS. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6395C433ED for ; Thu, 29 Apr 2021 07:05:46 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C63161449 for ; Thu, 29 Apr 2021 07:05:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C63161449 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1lc0jh-0006Ro-CS; Thu, 29 Apr 2021 03:05:21 -0400 Received: from mail.kernel.org ([198.145.29.99]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lc0je-0006Qx-Nt for kernelnewbies@kernelnewbies.org; Thu, 29 Apr 2021 03:05:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8D0036141E; Thu, 29 Apr 2021 07:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619679917; bh=GCQlMJMfukGtOitamxhM95nYZIGfkCAILI+JTYjvq54=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hq9y3u89XB8wff9zbfx+aYL0qQ3C1HiyviyZwZnh158O+ObPtXCcwUTso3/eI/av5 LJ3Nd+yRNy0UMHqKLJdcKJ9oTPIT5Y54nXVC8JQDhpAQlKxS/neJf3Sca5Xjr2YIw5 r0q/TSv2ijoUQEPEvc3Q9pnbWx7bWvd4CUNOSpCoYyAosVTSDJOAlPO4Mp+IF+3BOM Eph42q03aTR/iDP9vuC9CewSSsBgMV6UMyy+Gxdjo/2qX/QrnVuQ4kLd+Z3NJl1HGB icHODrlhj/LZY2k1QY5c0miDpqHDbeAHzj87jUMVYKG697waBg+RgUQec2bD3Rae/v Xoi4mtHXTqz0Q== Date: Thu, 29 Apr 2021 10:05:13 +0300 From: Leon Romanovsky To: Valdis =?utf-8?Q?Kl=C4=93tnieks?= Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices Message-ID: References: <20210424194301.jmsqpycvsm7izbk3@ubuntu> <20210426175031.w26ovnffjiow346h@burgerking> <210271.1619670673@turing-police> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <210271.1619670673@turing-police> Cc: gregkh@linuxfoundation.org, Anupama K Patil , "Rafael J. Wysocki" , bkkarthik , linux-kernel@vger.kernel.org, Jaroslav Kysela , linux-acpi@vger.kernel.org, kernelnewbies@kernelnewbies.org, skhan@linuxfoundation.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kernelnewbies-bounces@kernelnewbies.org T24gVGh1LCBBcHIgMjksIDIwMjEgYXQgMTI6MzE6MTNBTSAtMDQwMCwgVmFsZGlzIEtsxJN0bmll a3Mgd3JvdGU6Cj4gT24gVHVlLCAyNyBBcHIgMjAyMSAwNzoyNjoyNyArMDMwMCwgTGVvbiBSb21h bm92c2t5IHNhaWQ6Cj4gPiBPbiBNb24sIEFwciAyNiwgMjAyMSBhdCAxMToyMDozMlBNICswNTMw LCBia2thcnRoaWsgd3JvdGU6Cj4gPiA+IFRoZXNlIHdlcmUgb25seSBpbnRlbmRlZCBmb3IgYSBj bGVhbi11cCBqb2IsIHRoZSBpZGVhIG9mIHRoaXMgZnVuY3Rpb24gY2FtZSBmcm9tIGhvdyBQQ0kg aGFuZGxlcyBwcm9jZnMuCj4gPiA+IE1heWJlIHRob3NlIHNob3VsZCBiZSBjaGFuZ2VkPwo+ID4K PiA+IFByb2JhYmx5LCB0aGUgQ09ORklHX1BST0NfRlMgYXJvdW5kIHBjaV9wcm9jXyooKSBpcyBu b3QgbmVlZGVkIHRvby4KPiAKPiBXaWxsIHRoYXQgYWN0dWFsbHkgYnVpbGQgY29ycmVjdGx5IGlm IGl0J3MgYW4gZW1iZWRkZWQgc3lzdGVtIG9yIHNvbWV0aGluZyBidWlsZCB3aXRoCj4gQ09ORklH X1BST0NfRlM9bj8gIEknZCBleHBlY3QgdGhhdCB0byBkaWUgYSBob3JyaWQgZGVhdGggd2hpbGUg bGlua2luZyB2bWxpbnggZHVlCj4gdG8gc3R1ZmYgaW5zaWRlIHRoYXQgI2lmZGVmIGNhbGxpbmcg c3ltYm9scyBvbmx5IHByZXNlbnQgd2l0aCBQUk9DX0ZTPW0veS4KCldlIGFyZSB0YWxraW5nIGFi b3V0IHBjaV9wcm9jX2RldGFjaF9kZXZpY2UoKSBhbmQgcGNpX3Byb2NfZGV0YWNoX2J1cygpIGhl cmUuClRoZXkgd2lsbCBidWlsZCBwZXJmZWN0bHkgd2l0aG91dCBDT05GSUdfUFJPQ19GUy4KClRo YW5rcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2Vy bmVsbmV3YmllcyBtYWlsaW5nIGxpc3QKS2VybmVsbmV3Ymllc0BrZXJuZWxuZXdiaWVzLm9yZwpo dHRwczovL2xpc3RzLmtlcm5lbG5ld2JpZXMub3JnL21haWxtYW4vbGlzdGluZm8va2VybmVsbmV3 Ymllcwo=