From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06DF872 for ; Thu, 29 Apr 2021 11:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1619695910; bh=d3uPdEXE1jNAZ54QKIFbLqD5wKoRL+q+9gPNpRFnQIw=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=LZsok5TotTifFAujfAN9dRlgA5JB2P4OgCNd1ghlSOEPrPBi5IQxxRCdW3Zb3boz7 GNxdyI9hLomBtSVKS7SrKLwpwmzY2HjcW5AS+WkWECPrZAhV5NKzMGkAkeEDDq6P5i 0Uko0t8E4OwpwctefKBpb8oN+hpXDrKJuLHn2wQM= Received: by 192.168.90.16 [192.168.90.16] with ESMTP via ip-206.mailobj.net [213.182.55.206] Thu, 29 Apr 2021 13:31:50 +0200 (CEST) X-EA-Auth: CX0bTBDMWFCx2SMkg6z9D2BIwVUjGxNmB0nEYowyJhWVMQ6M3qPxHOtdCEn3sTk1EckjJk8FvCJTxXNGgQMUroIbvLmS2QJE Date: Thu, 29 Apr 2021 17:01:41 +0530 From: Deepak R Varma To: Dan Carpenter Cc: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mh12gx2825@gmail.com Subject: Re: [PATCH v1 4/6] staging: media: atomisp: reformat code comment blocks Message-ID: References: <20210429100808.GZ1981@kadam> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210429100808.GZ1981@kadam> On Thu, Apr 29, 2021 at 01:08:09PM +0300, Dan Carpenter wrote: > On Wed, Apr 21, 2021 at 10:26:09PM +0530, Deepak R Varma wrote: > > @@ -1044,7 +1048,7 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, > > } > > > > /* > > - // set analog/digital gain > > + * set analog/digital gain > > switch(AnalogGain) > > { > > case 0: > > How on earth does this compile? There is a closing */ down under after the entire switch block. The change I made is within the comment block. I have compiled the built the driver successfully. Please let me know if you are seeing a different issue here. Thank you, deepak. > > > @@ -1069,8 +1073,10 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, > > > regards, > dan carpenter >