From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3128C433ED for ; Thu, 29 Apr 2021 18:56:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F9A56143B for ; Thu, 29 Apr 2021 18:56:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F9A56143B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6716A6F446; Thu, 29 Apr 2021 18:56:14 +0000 (UTC) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by gabe.freedesktop.org (Postfix) with ESMTPS id A42246F448 for ; Thu, 29 Apr 2021 18:56:13 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id m5so9712418wmf.1 for ; Thu, 29 Apr 2021 11:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7nfKYP7lOOGrHT5NYTqOPuzxqA4uplX7W6GpZa8VmZY=; b=f5VU76dw5tdcjJsR/V5kqIK69jNOSgkGJRgMv/AB5mLtqChg8HEWidRWmOo1+A0pfK WjgNMEvI2Z/x/qJUEWR8sr61ArvFU/fRvFLTOLg2D7b9uQw7mRW+Q79js6H828K5m7Xz c9t7t1e16ooO/JUKTXl4BoWEdS2f2wjd/Hzgo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7nfKYP7lOOGrHT5NYTqOPuzxqA4uplX7W6GpZa8VmZY=; b=bik4lK9K4K+9W1i8YVicJlPNwc9+XZaCoad5PRdg+ddez+Jrh6rxa1jWtZaStElTt/ G4LG9UV/M0o2xNi0wKlJrf98xvzvEGWRn8rurtk2MJXoL/1dwHmtVAgUZ+sLFE4Cz1dl Uqo4X32DPCDwObrhHf83HgEAFw5JpAEeODmbIFtUyxieHSQVT1A0RrlaUVutgm3XbRYK m+3ylhdWnPttVDGUcHN50KiYVbxiG7m8Ok0mi0ZOEBqhcvNstkgpxsg3nvBDorqFRlgS hbwm5+bK2uexFPEwKsT7Fig0W2hCbguEiYEXwmtHO7sgwsQmLhsLjVV0HR3TUWeg9QS1 5ZfQ== X-Gm-Message-State: AOAM533mus3cy/SMf7iH4Aa0XE5Z36QEXF6/z7E3DwOT6OlbFoFf73JN tAghQuLZpnpNwPuXgF6SDtDMVQ== X-Google-Smtp-Source: ABdhPJwv6YaTPL++4UXIUupOqgNBPFZAiN96UWrLjfPKFQ/poI7xzb6nYBMcovKf8suPwR6z1NO0+Q== X-Received: by 2002:a1c:7e82:: with SMTP id z124mr12353520wmc.51.1619722572315; Thu, 29 Apr 2021 11:56:12 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h63sm1004410wmh.13.2021.04.29.11.56.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Apr 2021 11:56:11 -0700 (PDT) Date: Thu, 29 Apr 2021 20:56:09 +0200 From: Daniel Vetter To: Jason Ekstrand Subject: Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation Message-ID: References: <20210423223131.879208-1-jason@jlekstrand.net> <20210423223131.879208-17-jason@jlekstrand.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.32scarlett+ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel GFX , Maling list - DRI developers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > + ret = set_proto_ctx_param(file_priv, pc, args); > > > > I think we should have a FIXME here of not allowing this on some future > > platforms because just use CTX_CREATE_EXT. > > Done. > > > > + if (ret == -ENOTSUPP) { > > > + /* Some params, specifically SSEU, can only be set on fully > > > > I think this needs a FIXME: that this only holds during the conversion? > > Otherwise we kinda have a bit a problem me thinks ... > > I'm not sure what you mean by that. Well I'm at least assuming that we wont have this case anymore, i.e. there's only two kinds of parameters: - those which are valid only on proto context - those which are valid on both (like priority) This SSEU thing looks like a 3rd parameter, which is only valid on finalized context. That feels all kinds of wrong. Will it stay? If yes *ugh* and why? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 690F3C433B4 for ; Thu, 29 Apr 2021 18:56:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC4426143B for ; Thu, 29 Apr 2021 18:56:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC4426143B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 03AE66F449; Thu, 29 Apr 2021 18:56:15 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FC816F446 for ; Thu, 29 Apr 2021 18:56:13 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id p6-20020a05600c3586b029014131bbe5c7so338749wmq.3 for ; Thu, 29 Apr 2021 11:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7nfKYP7lOOGrHT5NYTqOPuzxqA4uplX7W6GpZa8VmZY=; b=f5VU76dw5tdcjJsR/V5kqIK69jNOSgkGJRgMv/AB5mLtqChg8HEWidRWmOo1+A0pfK WjgNMEvI2Z/x/qJUEWR8sr61ArvFU/fRvFLTOLg2D7b9uQw7mRW+Q79js6H828K5m7Xz c9t7t1e16ooO/JUKTXl4BoWEdS2f2wjd/Hzgo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7nfKYP7lOOGrHT5NYTqOPuzxqA4uplX7W6GpZa8VmZY=; b=SANafzMFgE0Fq3MEa4/CT0apsj6ZUzjbj+kVS2lsZIZ8dUGfQodOVZ6FTA9gcYnM+5 7ezuSUcQIOncunzOhHrCuLIOfi8oy5MMaCdUa0f+TBXhAp1soHTwIMSJzoaq+WdAVBAK s/3aGFllK5gAwr2eVntrRiTvk3t1++7vTI+d6aCk/LpepAUDxBDa4qmy0m+zFoKcMaCy iAnzhKC23g/swRYP8RegGMfrNmwI1DpctoXJOyVEMQxY6mLAwG0rWCl5N2aCepRjj4bD mSHpV8a/jfsx+UBrDwHE0l1oGSimv4SC1slI5IOq3287bbB0XJkBoT9QWocFfmCtNFeO jW3w== X-Gm-Message-State: AOAM5322aakj5FnaARUTC10SrujzF8uplYPy4Y7Q9MSFc2q6PuDsTKw9 LLsb4G1aFLh4CqHbde+TnDCevhHttVjwFQ== X-Google-Smtp-Source: ABdhPJwv6YaTPL++4UXIUupOqgNBPFZAiN96UWrLjfPKFQ/poI7xzb6nYBMcovKf8suPwR6z1NO0+Q== X-Received: by 2002:a1c:7e82:: with SMTP id z124mr12353520wmc.51.1619722572315; Thu, 29 Apr 2021 11:56:12 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h63sm1004410wmh.13.2021.04.29.11.56.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Apr 2021 11:56:11 -0700 (PDT) Date: Thu, 29 Apr 2021 20:56:09 +0200 From: Daniel Vetter To: Jason Ekstrand Message-ID: References: <20210423223131.879208-1-jason@jlekstrand.net> <20210423223131.879208-17-jason@jlekstrand.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.32scarlett+ Subject: Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel GFX , Maling list - DRI developers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Apr 29, 2021 at 01:16:04PM -0500, Jason Ekstrand wrote: > On Thu, Apr 29, 2021 at 10:51 AM Daniel Vetter wrote: > > > + ret = set_proto_ctx_param(file_priv, pc, args); > > > > I think we should have a FIXME here of not allowing this on some future > > platforms because just use CTX_CREATE_EXT. > > Done. > > > > + if (ret == -ENOTSUPP) { > > > + /* Some params, specifically SSEU, can only be set on fully > > > > I think this needs a FIXME: that this only holds during the conversion? > > Otherwise we kinda have a bit a problem me thinks ... > > I'm not sure what you mean by that. Well I'm at least assuming that we wont have this case anymore, i.e. there's only two kinds of parameters: - those which are valid only on proto context - those which are valid on both (like priority) This SSEU thing looks like a 3rd parameter, which is only valid on finalized context. That feels all kinds of wrong. Will it stay? If yes *ugh* and why? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx