From: Andrew Lunn <andrew@lunn.ch>
To: Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"Jisheng.Zhang@synaptics.com" <Jisheng.Zhang@synaptics.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V3 net] net: stmmac: fix MAC WoL unwork if PHY doesn't support WoL
Date: Thu, 29 Apr 2021 23:32:33 +0200 [thread overview]
Message-ID: <YIsl8TRuVkU5B2kD@lunn.ch> (raw)
In-Reply-To: <DB8PR04MB6795286E3C03699616C8C5C4E65F9@DB8PR04MB6795.eurprd04.prod.outlook.com>
> > > - if (!priv->plat->pmt) {
> > > + /* First check if can WoL from PHY */
> > > + phylink_ethtool_get_wol(priv->phylink, &wol_phy);
> >
> > This could return an error. In which case, you probably should not trust
> > wol_phy.
> phylink_ethtool_get_wol() is a void function
Upps. Yes, you are correct. Ignore what i said!
Andre
prev parent reply other threads:[~2021-04-29 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 7:41 [PATCH V3 net] net: stmmac: fix MAC WoL unwork if PHY doesn't support WoL Joakim Zhang
2021-04-28 12:26 ` Andrew Lunn
2021-04-28 16:22 ` Florian Fainelli
2021-04-29 7:11 ` Joakim Zhang
2021-04-29 7:09 ` Joakim Zhang
2021-04-29 21:32 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIsl8TRuVkU5B2kD@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jisheng.Zhang@synaptics.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.