From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BA76C433B4 for ; Fri, 30 Apr 2021 17:42:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D678B61468 for ; Fri, 30 Apr 2021 17:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230486AbhD3RnQ (ORCPT ); Fri, 30 Apr 2021 13:43:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbhD3RnO (ORCPT ); Fri, 30 Apr 2021 13:43:14 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6702DC06174A for ; Fri, 30 Apr 2021 10:42:24 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id n2so106450051ejy.7 for ; Fri, 30 Apr 2021 10:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=m6XRCfyd1sWEB+fFN+giyD+trqUKGzlWK2yo8Go96QU=; b=SLpmW4OTB3LG+4ygGNIuhVDWx1yiktvAKSGgTwm+rDfLZSUffW5kUQrs4/QCo7rmpL 98ERI1r2BbIFBPXLoHDIkNeonzKH4XIAyoH/Yfnzo+vuXW9sOqXyC9XNIfKR23wnCXXB 2GcnNPlPHH0RaZujrIibm7QhPbiZpSlkALgCE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=m6XRCfyd1sWEB+fFN+giyD+trqUKGzlWK2yo8Go96QU=; b=gyvJZ2VdRW5m5LQm99mIh0qbL+U1pgSwIeW1j149HZDTh5ScFB7cOfi9itZiZGRhhg 2P2lzaPVQEB9qvVn0XENIT9bySCzkqEeKKQjEiQOePG0L6eYC92q24LwktEKRv6Ppu5e /jC/J1CAh/5ZmItC5uqR1HN8es1Ay33KjzFfiYsaW1vKhTDq1YcdXLrqxz5Eox/onUxK MaDRQv7U0cXx3ktNy0MiGGEEQtHGSl6fFTVu7UBC8+Rn/jOrXhpE0XscZt73CRPsXphY qi44uZv2eXhYnRX+wj4E1G3lSKdOF4G3OI6bawqJUFHfCNTN667U4W97kO+MGuINq7VL Xh4w== X-Gm-Message-State: AOAM533mRicDhyx5kKeVAFE4Ewsag9mJp5EaU77JpRikHia1FA5LEF1O qGv6aOBJVP1yqwe+J2jjIB9qsA== X-Google-Smtp-Source: ABdhPJyG/LGvN/gXpgR1joI/FT5exj2RMZlCjVCMRiv6H1m9f0mh6m55PbrKcqLw14tRZSsGhLYd3Q== X-Received: by 2002:a17:907:174a:: with SMTP id lf10mr5876970ejc.433.1619804543070; Fri, 30 Apr 2021 10:42:23 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u1sm1864523edv.90.2021.04.30.10.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 10:42:22 -0700 (PDT) Date: Fri, 30 Apr 2021 19:42:20 +0200 From: Daniel Vetter To: kernel test robot Cc: Bernard Zhao , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org Subject: Re: [PATCH] drm/i915: Use might_alloc() Message-ID: Mail-Followup-To: kernel test robot , Bernard Zhao , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org References: <20210429024211.58245-1-bernard@vivo.com> <202104300054.AZxXGIKu-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202104300054.AZxXGIKu-lkp@intel.com> X-Operating-System: Linux phenom 5.10.32scarlett+ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 30, 2021 at 12:31:27AM +0800, kernel test robot wrote: > Hi Bernard, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on v5.12 next-20210429] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: x86_64-rhel-8.3-kselftests (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d753ff3432ab55f3e94a > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a > # save the attached .config to linux build tree > make W=1 W=1 ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_await_sw_fence': > >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration] > 344 | might_alloc(gfp); > | ^~~~~~~~~~~ > | might_lock > cc1: some warnings being treated as errors I think you're missing an include or something. The other patch you've done seems good, I queued that up in drm-intel-gt-next for 5.14. Thanks, Daniel > > > vim +344 drivers/gpu/drm/i915/i915_sw_fence.c > > 335 > 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, > 337 struct i915_sw_fence *signaler, > 338 wait_queue_entry_t *wq, gfp_t gfp) > 339 { > 340 unsigned int pending; > 341 unsigned long flags; > 342 > 343 debug_fence_assert(fence); > > 344 might_alloc(gfp); > 345 > 346 if (i915_sw_fence_done(signaler)) { > 347 i915_sw_fence_set_error_once(fence, signaler->error); > 348 return 0; > 349 } > 350 > 351 debug_fence_assert(signaler); > 352 > 353 /* The dependency graph must be acyclic. */ > 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) > 355 return -EINVAL; > 356 > 357 pending = I915_SW_FENCE_FLAG_FENCE; > 358 if (!wq) { > 359 wq = kmalloc(sizeof(*wq), gfp); > 360 if (!wq) { > 361 if (!gfpflags_allow_blocking(gfp)) > 362 return -ENOMEM; > 363 > 364 i915_sw_fence_wait(signaler); > 365 i915_sw_fence_set_error_once(fence, signaler->error); > 366 return 0; > 367 } > 368 > 369 pending |= I915_SW_FENCE_FLAG_ALLOC; > 370 } > 371 > 372 INIT_LIST_HEAD(&wq->entry); > 373 wq->flags = pending; > 374 wq->func = i915_sw_fence_wake; > 375 wq->private = fence; > 376 > 377 i915_sw_fence_await(fence); > 378 > 379 spin_lock_irqsave(&signaler->wait.lock, flags); > 380 if (likely(!i915_sw_fence_done(signaler))) { > 381 __add_wait_queue_entry_tail(&signaler->wait, wq); > 382 pending = 1; > 383 } else { > 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); > 385 pending = 0; > 386 } > 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); > 388 > 389 return pending; > 390 } > 391 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6880BC433ED for ; Fri, 30 Apr 2021 17:42:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A70BF61407 for ; Fri, 30 Apr 2021 17:42:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A70BF61407 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 63BBE6F57D; Fri, 30 Apr 2021 17:42:26 +0000 (UTC) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88E7B6F57B for ; Fri, 30 Apr 2021 17:42:24 +0000 (UTC) Received: by mail-ej1-x62e.google.com with SMTP id l4so106429988ejc.10 for ; Fri, 30 Apr 2021 10:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=m6XRCfyd1sWEB+fFN+giyD+trqUKGzlWK2yo8Go96QU=; b=SLpmW4OTB3LG+4ygGNIuhVDWx1yiktvAKSGgTwm+rDfLZSUffW5kUQrs4/QCo7rmpL 98ERI1r2BbIFBPXLoHDIkNeonzKH4XIAyoH/Yfnzo+vuXW9sOqXyC9XNIfKR23wnCXXB 2GcnNPlPHH0RaZujrIibm7QhPbiZpSlkALgCE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=m6XRCfyd1sWEB+fFN+giyD+trqUKGzlWK2yo8Go96QU=; b=cUeZUR4TfJeoVDkX28hhOS36t8hzn6sYObEZ86yGyBVM2+X4cwBVPcgBQmDKcXDBj6 rhwJJWQ/YmbaKI9VPepEc9RZuA1fyhITE8iAEphpLt3F39RIeumEkLrVvXipltdchGti 901NaO0jYQU8x2SVn8w8SvxSrEaQ9LC68XTJtpNr8SlKJVgTbYlJwb/Lb7o08MBnN11c DBWXOC0Gbluya3AOnH+OzkmBhrDf0XfR8jtJOHbGcxKKNVPc/D7BCqBf/Ut3MYCTGe1z HuAneIFUZt8pExwQwH6dPL1de5WEBYRVf93TcCrO6fpogdMLsMkIDiuJq/duWuM8TtSt CiVQ== X-Gm-Message-State: AOAM530IWi5IpjGKz+rIzGMqZzTuq1PrRqGMsQHwa5XVy4poUmQsqIkc NN18h+qlRIbejkJw8zcWGJn6nA== X-Google-Smtp-Source: ABdhPJyG/LGvN/gXpgR1joI/FT5exj2RMZlCjVCMRiv6H1m9f0mh6m55PbrKcqLw14tRZSsGhLYd3Q== X-Received: by 2002:a17:907:174a:: with SMTP id lf10mr5876970ejc.433.1619804543070; Fri, 30 Apr 2021 10:42:23 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u1sm1864523edv.90.2021.04.30.10.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 10:42:22 -0700 (PDT) Date: Fri, 30 Apr 2021 19:42:20 +0200 From: Daniel Vetter To: kernel test robot Subject: Re: [PATCH] drm/i915: Use might_alloc() Message-ID: Mail-Followup-To: kernel test robot , Bernard Zhao , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org References: <20210429024211.58245-1-bernard@vivo.com> <202104300054.AZxXGIKu-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202104300054.AZxXGIKu-lkp@intel.com> X-Operating-System: Linux phenom 5.10.32scarlett+ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, David Airlie , Bernard Zhao , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Apr 30, 2021 at 12:31:27AM +0800, kernel test robot wrote: > Hi Bernard, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on v5.12 next-20210429] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: x86_64-rhel-8.3-kselftests (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d753ff3432ab55f3e94a > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a > # save the attached .config to linux build tree > make W=1 W=1 ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_await_sw_fence': > >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration] > 344 | might_alloc(gfp); > | ^~~~~~~~~~~ > | might_lock > cc1: some warnings being treated as errors I think you're missing an include or something. The other patch you've done seems good, I queued that up in drm-intel-gt-next for 5.14. Thanks, Daniel > > > vim +344 drivers/gpu/drm/i915/i915_sw_fence.c > > 335 > 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, > 337 struct i915_sw_fence *signaler, > 338 wait_queue_entry_t *wq, gfp_t gfp) > 339 { > 340 unsigned int pending; > 341 unsigned long flags; > 342 > 343 debug_fence_assert(fence); > > 344 might_alloc(gfp); > 345 > 346 if (i915_sw_fence_done(signaler)) { > 347 i915_sw_fence_set_error_once(fence, signaler->error); > 348 return 0; > 349 } > 350 > 351 debug_fence_assert(signaler); > 352 > 353 /* The dependency graph must be acyclic. */ > 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) > 355 return -EINVAL; > 356 > 357 pending = I915_SW_FENCE_FLAG_FENCE; > 358 if (!wq) { > 359 wq = kmalloc(sizeof(*wq), gfp); > 360 if (!wq) { > 361 if (!gfpflags_allow_blocking(gfp)) > 362 return -ENOMEM; > 363 > 364 i915_sw_fence_wait(signaler); > 365 i915_sw_fence_set_error_once(fence, signaler->error); > 366 return 0; > 367 } > 368 > 369 pending |= I915_SW_FENCE_FLAG_ALLOC; > 370 } > 371 > 372 INIT_LIST_HEAD(&wq->entry); > 373 wq->flags = pending; > 374 wq->func = i915_sw_fence_wake; > 375 wq->private = fence; > 376 > 377 i915_sw_fence_await(fence); > 378 > 379 spin_lock_irqsave(&signaler->wait.lock, flags); > 380 if (likely(!i915_sw_fence_done(signaler))) { > 381 __add_wait_queue_entry_tail(&signaler->wait, wq); > 382 pending = 1; > 383 } else { > 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); > 385 pending = 0; > 386 } > 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); > 388 > 389 return pending; > 390 } > 391 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F2BC433B4 for ; Fri, 30 Apr 2021 17:42:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 761E261466 for ; Fri, 30 Apr 2021 17:42:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 761E261466 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E1FAB6F57B; Fri, 30 Apr 2021 17:42:24 +0000 (UTC) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 652876F57B for ; Fri, 30 Apr 2021 17:42:24 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id r12so106459130ejr.5 for ; Fri, 30 Apr 2021 10:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=m6XRCfyd1sWEB+fFN+giyD+trqUKGzlWK2yo8Go96QU=; b=SLpmW4OTB3LG+4ygGNIuhVDWx1yiktvAKSGgTwm+rDfLZSUffW5kUQrs4/QCo7rmpL 98ERI1r2BbIFBPXLoHDIkNeonzKH4XIAyoH/Yfnzo+vuXW9sOqXyC9XNIfKR23wnCXXB 2GcnNPlPHH0RaZujrIibm7QhPbiZpSlkALgCE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=m6XRCfyd1sWEB+fFN+giyD+trqUKGzlWK2yo8Go96QU=; b=e2crKyUy+IspGi8Tj7jahlzqzh3nbGrCv/kAecsjiH3k8+/uuii6AjKYPaFkgKSSrx h721SUde1Kh2dQ3CpEImpwjQUj86fqfLNl8lX36mHg9ozJskbJikya4OufDXTjX4JYW0 0K0W+4uCnPCH+RfeC0NxM0hQGppbTzqoyTaNAGq52GpC+Qf3d602jJDZMc2XA8m560o8 MMmuH993lKCz7ZWDHVSdltiXtxwmpw2E0B2ysYn7VB+FVGX23Ou1ezNSQX0F9k+H+7Uu Fl7H8VpryA/Gi/v6awCtiYfwsFsFehjl0xpScM1v0pHXYFrehdOCuk9h6+EUBkpYJyHO TZJw== X-Gm-Message-State: AOAM533u7Q0Lh212jnDZiRe4Ks+qLrmra+uVjKcpSBXX11TZ7cPwIsL0 Vq1Gr5d60bsXWcZb+c1GJFTdPQ== X-Google-Smtp-Source: ABdhPJyG/LGvN/gXpgR1joI/FT5exj2RMZlCjVCMRiv6H1m9f0mh6m55PbrKcqLw14tRZSsGhLYd3Q== X-Received: by 2002:a17:907:174a:: with SMTP id lf10mr5876970ejc.433.1619804543070; Fri, 30 Apr 2021 10:42:23 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u1sm1864523edv.90.2021.04.30.10.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 10:42:22 -0700 (PDT) Date: Fri, 30 Apr 2021 19:42:20 +0200 From: Daniel Vetter To: kernel test robot Message-ID: Mail-Followup-To: kernel test robot , Bernard Zhao , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org References: <20210429024211.58245-1-bernard@vivo.com> <202104300054.AZxXGIKu-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202104300054.AZxXGIKu-lkp@intel.com> X-Operating-System: Linux phenom 5.10.32scarlett+ Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use might_alloc() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, David Airlie , Bernard Zhao , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Apr 30, 2021 at 12:31:27AM +0800, kernel test robot wrote: > Hi Bernard, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on v5.12 next-20210429] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: x86_64-rhel-8.3-kselftests (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d753ff3432ab55f3e94a > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_alloc/20210429-104516 > git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a > # save the attached .config to linux build tree > make W=1 W=1 ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_await_sw_fence': > >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration] > 344 | might_alloc(gfp); > | ^~~~~~~~~~~ > | might_lock > cc1: some warnings being treated as errors I think you're missing an include or something. The other patch you've done seems good, I queued that up in drm-intel-gt-next for 5.14. Thanks, Daniel > > > vim +344 drivers/gpu/drm/i915/i915_sw_fence.c > > 335 > 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fence, > 337 struct i915_sw_fence *signaler, > 338 wait_queue_entry_t *wq, gfp_t gfp) > 339 { > 340 unsigned int pending; > 341 unsigned long flags; > 342 > 343 debug_fence_assert(fence); > > 344 might_alloc(gfp); > 345 > 346 if (i915_sw_fence_done(signaler)) { > 347 i915_sw_fence_set_error_once(fence, signaler->error); > 348 return 0; > 349 } > 350 > 351 debug_fence_assert(signaler); > 352 > 353 /* The dependency graph must be acyclic. */ > 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) > 355 return -EINVAL; > 356 > 357 pending = I915_SW_FENCE_FLAG_FENCE; > 358 if (!wq) { > 359 wq = kmalloc(sizeof(*wq), gfp); > 360 if (!wq) { > 361 if (!gfpflags_allow_blocking(gfp)) > 362 return -ENOMEM; > 363 > 364 i915_sw_fence_wait(signaler); > 365 i915_sw_fence_set_error_once(fence, signaler->error); > 366 return 0; > 367 } > 368 > 369 pending |= I915_SW_FENCE_FLAG_ALLOC; > 370 } > 371 > 372 INIT_LIST_HEAD(&wq->entry); > 373 wq->flags = pending; > 374 wq->func = i915_sw_fence_wake; > 375 wq->private = fence; > 376 > 377 i915_sw_fence_await(fence); > 378 > 379 spin_lock_irqsave(&signaler->wait.lock, flags); > 380 if (likely(!i915_sw_fence_done(signaler))) { > 381 __add_wait_queue_entry_tail(&signaler->wait, wq); > 382 pending = 1; > 383 } else { > 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); > 385 pending = 0; > 386 } > 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); > 388 > 389 return pending; > 390 } > 391 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7792670801814884114==" MIME-Version: 1.0 From: Daniel Vetter To: kbuild-all@lists.01.org Subject: Re: [PATCH] drm/i915: Use might_alloc() Date: Fri, 30 Apr 2021 19:42:20 +0200 Message-ID: In-Reply-To: <202104300054.AZxXGIKu-lkp@intel.com> List-Id: --===============7792670801814884114== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, Apr 30, 2021 at 12:31:27AM +0800, kernel test robot wrote: > Hi Bernard, > = > Thank you for the patch! Yet something to improve: > = > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on v5.12 next-20210429] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > = > url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-i915-Us= e-might_alloc/20210429-104516 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: x86_64-rhel-8.3-kselftests (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=3D1 build): > # https://github.com/0day-ci/linux/commit/9fbd0c1741ce06241105d75= 3ff3432ab55f3e94a > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Bernard-Zhao/drm-i915-Use-might_= alloc/20210429-104516 > git checkout 9fbd0c1741ce06241105d753ff3432ab55f3e94a > # save the attached .config to linux build tree > make W=3D1 W=3D1 ARCH=3Dx86_64 = > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All errors (new ones prefixed by >>): > = > drivers/gpu/drm/i915/i915_sw_fence.c: In function '__i915_sw_fence_awa= it_sw_fence': > >> drivers/gpu/drm/i915/i915_sw_fence.c:344:2: error: implicit declaratio= n of function 'might_alloc'; did you mean 'might_lock'? [-Werror=3Dimplicit= -function-declaration] > 344 | might_alloc(gfp); > | ^~~~~~~~~~~ > | might_lock > cc1: some warnings being treated as errors I think you're missing an include or something. The other patch you've done seems good, I queued that up in drm-intel-gt-next for 5.14. Thanks, Daniel > = > = > vim +344 drivers/gpu/drm/i915/i915_sw_fence.c > = > 335 = > 336 static int __i915_sw_fence_await_sw_fence(struct i915_sw_fence *fe= nce, > 337 struct i915_sw_fence *signaler, > 338 wait_queue_entry_t *wq, gfp_t gfp) > 339 { > 340 unsigned int pending; > 341 unsigned long flags; > 342 = > 343 debug_fence_assert(fence); > > 344 might_alloc(gfp); > 345 = > 346 if (i915_sw_fence_done(signaler)) { > 347 i915_sw_fence_set_error_once(fence, signaler->error); > 348 return 0; > 349 } > 350 = > 351 debug_fence_assert(signaler); > 352 = > 353 /* The dependency graph must be acyclic. */ > 354 if (unlikely(i915_sw_fence_check_if_after(fence, signaler))) > 355 return -EINVAL; > 356 = > 357 pending =3D I915_SW_FENCE_FLAG_FENCE; > 358 if (!wq) { > 359 wq =3D kmalloc(sizeof(*wq), gfp); > 360 if (!wq) { > 361 if (!gfpflags_allow_blocking(gfp)) > 362 return -ENOMEM; > 363 = > 364 i915_sw_fence_wait(signaler); > 365 i915_sw_fence_set_error_once(fence, signaler->error); > 366 return 0; > 367 } > 368 = > 369 pending |=3D I915_SW_FENCE_FLAG_ALLOC; > 370 } > 371 = > 372 INIT_LIST_HEAD(&wq->entry); > 373 wq->flags =3D pending; > 374 wq->func =3D i915_sw_fence_wake; > 375 wq->private =3D fence; > 376 = > 377 i915_sw_fence_await(fence); > 378 = > 379 spin_lock_irqsave(&signaler->wait.lock, flags); > 380 if (likely(!i915_sw_fence_done(signaler))) { > 381 __add_wait_queue_entry_tail(&signaler->wait, wq); > 382 pending =3D 1; > 383 } else { > 384 i915_sw_fence_wake(wq, 0, signaler->error, NULL); > 385 pending =3D 0; > 386 } > 387 spin_unlock_irqrestore(&signaler->wait.lock, flags); > 388 = > 389 return pending; > 390 } > 391 = > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch --===============7792670801814884114==--