From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C70BDC433B4 for ; Thu, 13 May 2021 11:30:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 203DD60E0B for ; Thu, 13 May 2021 11:30:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 203DD60E0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B41196ECF6; Thu, 13 May 2021 11:30:27 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78E9C6ECF6 for ; Thu, 13 May 2021 11:30:26 +0000 (UTC) IronPort-SDR: o0FFRAJFufdJMiUq4BzITcjN/oIzRMb7phciA7A9GVimRlez4voqMYSBmH12yUqGWLCNM+a21n MYe8ZApnV57w== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="261170536" X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="261170536" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 04:30:20 -0700 IronPort-SDR: TXMJDVHOX0v5b0flxE9c3HCduAwuKQRLx79cSixpVPUvM8231bsebSAJ4IXvzxfKnSQr41N/My 6bIxlsNCa/3w== X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="610343437" Received: from abgautam-mobl1.amr.corp.intel.com (HELO intel.com) ([10.254.1.132]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 04:30:18 -0700 Date: Thu, 13 May 2021 07:30:17 -0400 From: Rodrigo Vivi To: Dave Airlie Message-ID: References: <20210426161124.2b7fd708@dellnichtsogutkiste> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: development@manuel-bentele.de, Intel Graphics Development Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, May 13, 2021 at 10:18:49AM +1000, Dave Airlie wrote: > Reviewed-by: Dave Airlie > > Can we get this fix in, having a regression spanning 3 kernels isn't a > good look, we can work out why it matters later in life if anyone > cares. Agreed and pushed do drm-intel-next. This triggered me to do an archeology work here and I found a possible alternative for ILK: +#define HIZ_UNIT_CLOCK_GATE_DISABLE REG_BIT(5) #define FDI_PLL_FREQ_CTL _MMIO(0x46030) #define FDI_PLL_FREQ_CHANGE_REQUEST (1 << 24) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 06d5b7cc8b62..6316b70978f7 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -6892,8 +6892,11 @@ static void ilk_init_clock_gating(struct drm_i915_private *dev_priv) intel_uncore_write(&dev_priv->uncore, PCH_3DCGDIS0, MARIUNIT_CLOCK_GATE_DISABLE | SVSMUNIT_CLOCK_GATE_DISABLE); + + /* WaDisableHizUnitClockGating:ilk */ intel_uncore_write(&dev_priv->uncore, PCH_3DCGDIS1, - VFMUNIT_CLOCK_GATE_DISABLE); + VFMUNIT_CLOCK_GATE_DISABLE | + HIZ_UNIT_CLOCK_GATE_DISABLE); however I couldn't find anything for Baytrail, so let's move with this one for now. > > Dave. > > On Tue, 27 Apr 2021 at 00:31, Simon Rettberg > wrote: > > > > When resetting CACHE_MODE registers, don't enable HiZ Raw Stall > > Optimization on Ivybridge GT1 and Baytrail, as it causes severe glitches > > when rendering any kind of 3D accelerated content. > > This optimization is disabled on these platforms by default according to > > official documentation from 01.org. > > > > Fixes: ef99a60ffd9b ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals") > > Fixes: 520d05a77b28 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals") > > BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3081 > > BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3404 > > BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3071 > > Reviewed-By: Manuel Bentele > > Signed-off-by: Simon Rettberg > > --- > > drivers/gpu/drm/i915/gt/gen7_renderclear.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c > > index de575fdb0..21f08e538 100644 > > --- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c > > +++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c > > @@ -397,7 +397,10 @@ static void emit_batch(struct i915_vma * const vma, > > gen7_emit_pipeline_invalidate(&cmds); > > batch_add(&cmds, MI_LOAD_REGISTER_IMM(2)); > > batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_0_GEN7)); > > - batch_add(&cmds, 0xffff0000); > > + batch_add(&cmds, 0xffff0000 | > > + ((IS_IVB_GT1(i915) || IS_VALLEYVIEW(i915)) ? > > + HIZ_RAW_STALL_OPT_DISABLE : > > + 0)); > > batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_1)); > > batch_add(&cmds, 0xffff0000 | PIXEL_SUBSPAN_COLLECT_OPT_DISABLE); > > gen7_emit_pipeline_invalidate(&cmds); > > -- > > 2.25.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx