All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org, "Greg Kurz" <groug@kaod.org>,
	"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
	qemu-ppc@nongnu.org,
	"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'
Date: Fri, 14 May 2021 09:33:18 +1000	[thread overview]
Message-ID: <YJ23PiCRO/ytJEKo@yekko> (raw)
In-Reply-To: <161fa4ca-5407-790c-8e2f-e0665c89fd6f@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

On Thu, May 13, 2021 at 05:20:06PM +0200, Paolo Bonzini wrote:
> On 12/05/21 09:02, David Gibson wrote:
> > > But with "imply" you could end up with a PSERIES that does not have NVDIMM
> > > when also using --without-default-devices, couldn't you? Why don't you use
> > > "select" instead of "imply" ?
> > Oh.. clearly I misunderstand the semantics of "imply".  If we don't
> > need NVDIMM for PSERIES, why does there need to be any Kconfig
> > connection between them at all?
> 
> Because you still want it in the binary by default (i.e. unless
> --without-default-devices).
> 
> Basically,
> 
> config PSERIES
>     imply NVDIMM
> 
> is the same as
> 
> config NVDIMM
>     default y if PSERIES

Ah, ok, I get it now.  "imply" is a terrible word for this, but ok.

> Both of them are a way to say "PSERIES can work with NVDIMM so you want to
> include it unless you want some fine tuning".  In Linux "imply" is very
> rarely used, while in QEMU it's quite common because it keeps the many
> per-board defaults close together.
> 
> Paolo
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-05-14  0:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 15:53 [RFC PATCH 0/5] buildsys: Do not use internal fdt library when asked for the system one Philippe Mathieu-Daudé
2021-05-11 15:53 ` [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Philippe Mathieu-Daudé
2021-05-12  2:24   ` David Gibson
2021-05-12  3:57     ` Philippe Mathieu-Daudé
2021-05-12  4:53       ` Thomas Huth
2021-05-12  5:08         ` Philippe Mathieu-Daudé
2021-05-12  5:30           ` Thomas Huth
2021-05-12  7:02         ` David Gibson
2021-05-13 15:20           ` Paolo Bonzini
2021-05-13 23:33             ` David Gibson [this message]
2021-05-12  8:02   ` Paolo Bonzini
2021-05-11 15:53 ` [RFC PATCH 2/5] Kconfig: Declare 'FDT' host symbol Philippe Mathieu-Daudé
2021-05-12  7:37   ` Paolo Bonzini
2021-05-11 15:53 ` [RFC PATCH 3/5] hw/ppc: Have pSeries depends on libfdt (via host Kconfig FDT symbol) Philippe Mathieu-Daudé
2021-05-12  2:27   ` David Gibson
2021-05-12  8:01     ` Paolo Bonzini
2021-05-13  3:46       ` David Gibson
2021-05-12  7:45   ` Paolo Bonzini
2021-05-12  8:27     ` Philippe Mathieu-Daudé
2021-05-11 15:53 ` [RFC PATCH 4/5] hw/ppc/fdt: Drop dependency on libfdt Philippe Mathieu-Daudé
2021-05-12  2:30   ` David Gibson
2021-05-12  7:59     ` Paolo Bonzini
2021-05-13  3:46       ` David Gibson
2021-05-13 15:26         ` Paolo Bonzini
2021-05-13 23:35           ` David Gibson
2021-05-14  5:29             ` Paolo Bonzini
2021-05-14  8:22               ` Philippe Mathieu-Daudé
2021-05-11 15:53 ` [RFC PATCH 5/5] meson: Do not use internal fdt library if user asked for the system one Philippe Mathieu-Daudé
2021-05-12  7:32   ` Paolo Bonzini
2021-05-11 15:57 ` [RFC PATCH 0/5] buildsys: Do not use internal fdt library when " Philippe Mathieu-Daudé
2021-05-12  3:56   ` Philippe Mathieu-Daudé
2021-05-12  7:34     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ23PiCRO/ytJEKo@yekko \
    --to=david@gibson.dropbear.id.au \
    --cc=aik@ozlabs.ru \
    --cc=ehabkost@redhat.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=groug@kaod.org \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.