All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Schier <nicolas@fjasle.eu>
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, Finn Behrens <me@kloenk.de>,
	Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH v2 1/2] tweewide: Fix most Shebang lines
Date: Thu, 13 May 2021 22:03:24 +0200	[thread overview]
Message-ID: <YJ2GDOt48sjlMFtD@lillesand.fjasle.eu> (raw)
In-Reply-To: <YJvC2W9QTpc9JBp1@kroah.com>

On Wed, May 12, 2021 at 01:58PM +0000, Greg KH wrote:
> On Tue, May 11, 2021 at 08:58:16PM +0200, Nicolas Schier wrote:
> > From: Finn Behrens <me@kloenk.de>
> > 
> > commit c25ce589dca10d64dde139ae093abc258a32869c upstream.
> > 
> > Change every shebang which does not need an argument to use /usr/bin/env.
> > This is needed as not every distro has everything under /usr/bin,
> > sometimes not even bash.
> > 
> > Signed-off-by: Finn Behrens <me@kloenk.de>
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > [nicolas@fjasle.eu: ported to v4.9, updated contexts, adapt for old
> >  scripts]
> 
> What about 4.14, 4.19, 5.4, and 5.10?  We can't add patches only to one
> stable tree and not all of the newer ones as well.

Hi Greg,

yes, that makes sense obviously, I did not have that in mind.  If there 
is a chance for acceptance, I will gladly provide the patches for the 
newer stable tree as well.

> And what problem is this solving?  What distro has problems with this
> for this old kernel tree?
> 
> thanks,
> 
> greg k-h

my concrete problem is that I work with several 4.9 kernel trees and 
that our build system uses diffconfig (for consistency checking) which 
does not run anymore on a current Debian testing (/usr/bin/python is 
not more available).  As the corresponding upstream "fix" commit 
51839e29cb59544 (cp. patch 2/2) technically bases on commit
c25ce589dca10d64dde, I thought backporting both should be the cleaner 
way.

I would not mind to drop this patch, but I would like to see commit 
51839e29cb59544 in the stable trees.  Does it make sense to prepare 
backports of it for all current stable trees?

Thanks and kind regards,
Nicolas

-- 
epost: nicolas@fjasle.eu               irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
     -- frykten for herren er opphav til kunnskap --

  reply	other threads:[~2021-05-13 20:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 18:58 [PATCH v2 0/2] shebang fixes and explicit python3 switch for v4.9 Nicolas Schier
2021-05-11 18:58 ` [PATCH v2 1/2] tweewide: Fix most Shebang lines Nicolas Schier
2021-05-12 11:58   ` Greg KH
2021-05-13 20:03     ` Nicolas Schier [this message]
2021-05-17 12:01       ` Greg KH
2021-05-11 18:58 ` [PATCH v2 2/2] scripts: switch explicitly to Python 3 Nicolas Schier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ2GDOt48sjlMFtD@lillesand.fjasle.eu \
    --to=nicolas@fjasle.eu \
    --cc=greg@kroah.com \
    --cc=masahiroy@kernel.org \
    --cc=me@kloenk.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.