From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57454C433B4 for ; Fri, 14 May 2021 12:19:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32EF861285 for ; Fri, 14 May 2021 12:19:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233199AbhENMUb (ORCPT ); Fri, 14 May 2021 08:20:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232671AbhENMUa (ORCPT ); Fri, 14 May 2021 08:20:30 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD124C061574 for ; Fri, 14 May 2021 05:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4j6NAUINOO2iRcafPhFqTSB4UiIS5qPdm2W1b5MCFfo=; b=v/Btch9J/kbExn3R8m5BlhEMgM nEleQOuvkkgT8ka60BvyzSgCv6r4VrATcDO1UYG3G0S/DPt/GeMiF8m/jJLLnw5b5XNFjYfaDl8Ii GbMcgQeFIzeKIH+gn+Zmye9+ozbfTNtehdl7O6fRX6PUXlpLr/hU3FfObkJZjSCYIkvteTMTw1tfs KSWOwW+F/FVxdEasLWPSqRRatNsRgzoWQXI9TKvyOH4J6RIg5L8stpRzhcxk+8e5YUGtLclA0juhB USvUpAkMPSWX5tcBOmHbskfCMv5YzrQuUEvSG9PP7y2wmECHI66QP8frqj+RHkS6ETc6qTkkYrjEd gtslY/5g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lhWlL-00ALqZ-0H; Fri, 14 May 2021 12:18:00 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C803E30022A; Fri, 14 May 2021 14:17:49 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id AEE0820D74F30; Fri, 14 May 2021 14:17:49 +0200 (CEST) Date: Fri, 14 May 2021 14:17:49 +0200 From: Peter Zijlstra To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Michel Lespinasse Subject: Re: [PATCH 26/94] Maple Tree: Add new data structure Message-ID: References: <20210428153542.2814175-1-Liam.Howlett@Oracle.com> <20210428153542.2814175-27-Liam.Howlett@Oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210428153542.2814175-27-Liam.Howlett@Oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 28, 2021 at 03:36:02PM +0000, Liam Howlett wrote: > +static void mas_set_height(struct ma_state *mas) > +{ > + unsigned int new_flags = mas->tree->ma_flags; > + > + new_flags &= ~MAPLE_HEIGHT_MASK; > + new_flags |= mas->depth << MAPLE_HEIGHT_OFFSET; > + mas->tree->ma_flags = new_flags; > +} This goes sideways when mas->depth is too large; I didn't quickly see an assertion / range checks for mas->depth anywhere.