From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94B3B70 for ; Fri, 14 May 2021 16:51:29 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id p17so168515pjz.3 for ; Fri, 14 May 2021 09:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e6Gzp7eGnrG8H4GauPeUuR3AzbUI2wVGSNiIGMsXoFU=; b=GH0EWCQaUxR/QeQAEPLbOylF9Bcdez/FFPuOmqAi2aEG/llNf/B0Fi8bEBIgN3275q uXuDimJLkvAy2NFFbjsKxae8yXspDNhILL2OnqwJ6noFr1y/sP55fu8F+ILvNKPSaQTV SLg33vzD62ZxBbOPCsRWAs8U9EOy74QQUnpXY6MBmeD27dZT4gOl2Lr6KINPTT6sVe/3 aAQ8xC/y3XP7IMmgRqBuwgYcNfZUHVJKiANrlehEFrbaOkgtcEQxtv8Fps6O+pIfImLJ EA7OMRAGoNo+Zz1mPlxz35G0GmPAA/nB/a25gY5LhjoYEo6DJHBdTgNcYfI9Xz1G6Wzn 18tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e6Gzp7eGnrG8H4GauPeUuR3AzbUI2wVGSNiIGMsXoFU=; b=BUsE+MA4KeHdGYwMHeXgpFnKy2uwbNmpzbPqZVNI+AKK+4tlvhr2+vnAjG2p2opX/z KcoSHnEHZrFBPgeyefWRPv6fNjJbd5pX7Ic9SvaDBsGAHqMDJ5m6265D1hbrpbheXL77 Z1R0y4OJwF2ChITmvw1UTnBrLy9qwSfdsOav7iCm/gi3rZuKSnY7YT8bLIeaQEHrLRRt Ep947FQsMinhPwsqW5r/UmgrWPS2678cGfpW3FRll8PrZ1aP+9bnD4pp7Kq5lMlsJ+dZ tWYsNSAOuPUnzclS6a8Nrs2nhDIDdgXmKQllAWk4NxMVOY+W+0sMR6ko8mCXjDsGKK/v 5k6w== X-Gm-Message-State: AOAM532esq+2pZCMjoN1mkqYO52aGiJqXxySsDiiln7R6rC88arfIGlR aBnjMlGld4Wv6F4r19jmQO4= X-Google-Smtp-Source: ABdhPJxfH9/KEBTNpAakNtxHhA7kdVgkqaIiThe/gzc/GWTqqMQI9DMhjPmy8EUk2OMfabKIhWIfuQ== X-Received: by 2002:a17:90a:ae15:: with SMTP id t21mr12417540pjq.55.1621011089100; Fri, 14 May 2021 09:51:29 -0700 (PDT) Received: from fedora ([2405:201:6008:61b4:4e16:5348:d963:c66d]) by smtp.gmail.com with ESMTPSA id z20sm4864951pjq.47.2021.05.14.09.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 May 2021 09:51:28 -0700 (PDT) Date: Fri, 14 May 2021 22:21:22 +0530 From: Shreyansh Chouhan To: Joe Perches Cc: Greg KH , pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: fix gb_loopback_stats_attrs definition Message-ID: References: <20210514133039.304760-1-chouhan.shreyansh630@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 14, 2021 at 08:56:10AM -0700, Joe Perches wrote: > On Fri, 2021-05-14 at 17:30 +0200, Greg KH wrote: > > On Fri, May 14, 2021 at 08:42:16PM +0530, Shreyansh Chouhan wrote: > [] > > > I didn't look at how/where was the macro called and missed a very > > > obvious error. Now that I have looked at it, the only way I can think of > > > fixing this is changing the macro to a (inline?) function. Will > > > that be a desirable change? > > > > No, it can't be a function, the code is fine as-is, checkpatch is just a > > perl script and does not always know what needs to be done. > > true. > > perhaps better though to rename these declaring macros to start with declare_ > > Something like this: Thanks! I can definitely help with this. I'll send the patch in a bit. Since it seemed as if the original patch wasn't really required, I canceled the moderator approval request for the greybus-dev mailing list. I thought I'd rather not bother the moderator and the rest of the list with these patches. I thought I should mention this since it could cause some confusion. I will start a new thread for the other patch. Regards, Shreyansh Chouhan