From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 402F9C43460 for ; Tue, 4 May 2021 13:55:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C5606115C for ; Tue, 4 May 2021 13:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231371AbhEDN43 (ORCPT ); Tue, 4 May 2021 09:56:29 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:51499 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231216AbhEDN41 (ORCPT ); Tue, 4 May 2021 09:56:27 -0400 X-Originating-IP: 90.65.108.55 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 9FD541BF20B; Tue, 4 May 2021 13:55:27 +0000 (UTC) Date: Tue, 4 May 2021 15:55:27 +0200 From: Alexandre Belloni To: Vladimir Oltean Cc: Andrew Lunn , Colin Foster , Rob Herring , Claudiu Manoil , "supporter:OCELOT ETHERNET SWITCH DRIVER" , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Russell King , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "open list:OCELOT ETHERNET SWITCH DRIVER" Subject: Re: [RFC PATCH vN net-next 2/2] net: mscc: ocelot: add support for VSC75XX SPI control Message-ID: References: <20210504051130.1207550-1-colin.foster@in-advantage.com> <20210504051130.1207550-2-colin.foster@in-advantage.com> <20210504125942.nx5b6j2cy34qyyhm@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210504125942.nx5b6j2cy34qyyhm@skbuf> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/2021 12:59:43+0000, Vladimir Oltean wrote: > > > +static void vsc7512_phylink_validate(struct ocelot *ocelot, int port, > > > + unsigned long *supported, > > > + struct phylink_link_state *state) > > > +{ > > > + struct ocelot_port *ocelot_port = ocelot->ports[port]; > > > + __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { > > > + 0, > > > + }; > > > > This function seems out of place. Why would SPI access change what the > > ports are capable of doing? Please split this up into more > > patches. Keep the focus of this patch as being adding SPI support. > > What is going on is that this is just the way in which the drivers are > structured. Colin is not really "adding SPI support" to any of the > existing DSA switches that are supported (VSC9953, VSC9959) as much as > "adding support for a new switch which happens to be controlled over > SPI" (VSC7512). Note that this should not only be about vsc7512 as the whole ocelot family (vsc7511, vsc7512, vsc7513 and vsc7514) can be connected over spi. Also, they can all be used in a DSA configuration, over PCIe, just like Felix. > The layering is as follows: > - drivers/net/dsa/ocelot/felix_vsc7512_spi.c: deals with the most > hardware specific SoC support. The regmap is defined here, so are the > port capabilities. > - drivers/net/dsa/ocelot/felix.c: common integration with DSA > - drivers/net/ethernet/mscc/ocelot*.c: the SoC-independent hardware > support. > > I'm not actually sure that splitting the port PHY mode support in a > separate patch is possible while keeping functional intermediate > results. But I do agree about the rest, splitting the device tree > changes, etc. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com