From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C833FC433ED for ; Tue, 4 May 2021 15:13:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3477160FD8 for ; Tue, 4 May 2021 15:13:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3477160FD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldwkB-0001En-Sf for qemu-devel@archiver.kernel.org; Tue, 04 May 2021 11:13:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldwj8-0000lG-Gk for qemu-devel@nongnu.org; Tue, 04 May 2021 11:12:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47261) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldwj4-0002S2-Ga for qemu-devel@nongnu.org; Tue, 04 May 2021 11:12:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620141160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=byxsm863H2VCcoAz4ug3EylNPJwYmMzRm710h1Cx+rA=; b=fEVQEQYI6EGeBHzKNAFvD/LiNZmjoTeXfy1HyVM4IzKTnsOhhGkTIN/Yaefdng9V9wRS9d 5HrLaDfPwMMKCKzijWgr/qVp+yfDLBVsWb4L623vfTQHngsqccDf7VIbhScC+mkfuzuvpL VuakFGG9blKOzHzxhbhQDcQ8AsE2Ruk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-567-rQ5V5dZ6PWOBh8DZPZ_VSg-1; Tue, 04 May 2021 11:12:38 -0400 X-MC-Unique: rQ5V5dZ6PWOBh8DZPZ_VSg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A7C03107ACF8; Tue, 4 May 2021 15:12:37 +0000 (UTC) Received: from localhost (ovpn-115-110.ams2.redhat.com [10.36.115.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B5A45D6B1; Tue, 4 May 2021 15:12:37 +0000 (UTC) Date: Tue, 4 May 2021 16:12:36 +0100 From: Stefan Hajnoczi To: "Dr. David Alan Gilbert (git)" Subject: Re: [PATCH v3 02/26] virtiofsd: Don't assume header layout Message-ID: References: <20210428110100.27757-1-dgilbert@redhat.com> <20210428110100.27757-3-dgilbert@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210428110100.27757-3-dgilbert@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+gHic+xH234Qie+K" Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.697, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org, vgoyal@redhat.com, groug@kaod.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --+gHic+xH234Qie+K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 28, 2021 at 12:00:36PM +0100, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > virtiofsd incorrectly assumed a fixed set of header layout in the virt > queue; assuming that the fuse and write headers were conveniently > separated from the data; the spec doesn't allow us to take that > convenience, so fix it up to deal with it the hard way. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_virtio.c | 94 +++++++++++++++++++++++++++-------- > 1 file changed, 73 insertions(+), 21 deletions(-) Reviewed-by: Stefan Hajnoczi --+gHic+xH234Qie+K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmCRZGMACgkQnKSrs4Gr c8gANggAk+5DPo3kDQ9APbrx5HDtEJmdmbvgOH/NNIN6XRhmKOMpz0XOk+K/6+y7 sdJPPsRatzXtl5PfxE5i4/bblNlcvFAD6hKU2ZGuJvMD73s66oQ2Vs+zr83K7cr4 W209oPi2tZb7h8LUNy5CAi5JUtj1h62ey0oVBCZ/KSC80zH9G3iHU8v07jkILvdN hspYfdZHE61iNZwOUeucxoeEaoLuAWRoElb41YZ1zoXK0o/sW0GYZfKofoBGAn60 6mJGrKQPWVkSMT+3KWHwo3bqleq/cS3ds6wCP8CPR0TrNeVWHhjX7pj3CJjq3oh9 oLFIdjhyN0Hb5X9+AY/xrMVdnx02yw== =HQRB -----END PGP SIGNATURE----- --+gHic+xH234Qie+K-- From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 4 May 2021 16:12:36 +0100 From: Stefan Hajnoczi Message-ID: References: <20210428110100.27757-1-dgilbert@redhat.com> <20210428110100.27757-3-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+gHic+xH234Qie+K" Content-Disposition: inline In-Reply-To: <20210428110100.27757-3-dgilbert@redhat.com> Subject: Re: [Virtio-fs] [PATCH v3 02/26] virtiofsd: Don't assume header layout List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org, vgoyal@redhat.com --+gHic+xH234Qie+K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 28, 2021 at 12:00:36PM +0100, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > virtiofsd incorrectly assumed a fixed set of header layout in the virt > queue; assuming that the fuse and write headers were conveniently > separated from the data; the spec doesn't allow us to take that > convenience, so fix it up to deal with it the hard way. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_virtio.c | 94 +++++++++++++++++++++++++++-------- > 1 file changed, 73 insertions(+), 21 deletions(-) Reviewed-by: Stefan Hajnoczi --+gHic+xH234Qie+K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmCRZGMACgkQnKSrs4Gr c8gANggAk+5DPo3kDQ9APbrx5HDtEJmdmbvgOH/NNIN6XRhmKOMpz0XOk+K/6+y7 sdJPPsRatzXtl5PfxE5i4/bblNlcvFAD6hKU2ZGuJvMD73s66oQ2Vs+zr83K7cr4 W209oPi2tZb7h8LUNy5CAi5JUtj1h62ey0oVBCZ/KSC80zH9G3iHU8v07jkILvdN hspYfdZHE61iNZwOUeucxoeEaoLuAWRoElb41YZ1zoXK0o/sW0GYZfKofoBGAn60 6mJGrKQPWVkSMT+3KWHwo3bqleq/cS3ds6wCP8CPR0TrNeVWHhjX7pj3CJjq3oh9 oLFIdjhyN0Hb5X9+AY/xrMVdnx02yw== =HQRB -----END PGP SIGNATURE----- --+gHic+xH234Qie+K--