From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jin Yao <yao.jin@linux.intel.com>,
jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 1/2] perf header: Support HYBRID_TOPOLOGY feature
Date: Tue, 4 May 2021 21:37:34 +0200 [thread overview]
Message-ID: <YJGifgASdDD7T8Xc@krava> (raw)
In-Reply-To: <YJGgYSXcJbZ2n3H3@kernel.org>
On Tue, May 04, 2021 at 04:28:33PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 04, 2021 at 04:56:44PM +0200, Jiri Olsa escreveu:
> > On Fri, Apr 30, 2021 at 03:46:01PM +0800, Jin Yao wrote:
> > > It would be useful to let user know the hybrid topology.
> > > Adding HYBRID_TOPOLOGY feature in header to indicate the
> > > core cpus and the atom cpus.
>
> > > With this patch,
>
> > > For the perf.data generated on hybrid platform,
> > > reports the hybrid cpu list.
>
> > > root@otcpl-adl-s-2:~# perf report --header-only -I
> > > ...
> > > # cpu_core cpu list : 0-15
> > > # cpu_atom cpu list : 16-23
>
> > hum, should we print 'hybrid:' or something to make
> > sure its not confused with something else? like
>
> > # hybrid cpu_core cpu list : 0-15
> > # hybrid cpu_atom cpu list : 16-23
>
> But this _core/_atom already got to be enough? I disagreed with that
> naming, but neverthless having one or the other present in an output is
> a clear mark of this hybrid topology.
>
> I.e having that extra hybrid string that wouldn't add information to the
> output.
sure when you know that cpu_core/cpu_atom are hybrid pmus ;-)
and I guess other arch will come with other names
jirka
>
> IMHO.
>
> - Arnaldo
>
next prev parent reply other threads:[~2021-05-04 19:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 7:46 [PATCH v1 1/2] perf header: Support HYBRID_TOPOLOGY feature Jin Yao
2021-04-30 7:46 ` [PATCH v1 2/2] perf header: Support hybrid CPU_PMU_CAPS Jin Yao
2021-05-04 15:07 ` Jiri Olsa
2021-05-06 4:59 ` Jin, Yao
2021-05-06 13:22 ` Jiri Olsa
2021-05-06 14:43 ` Jin, Yao
2021-05-10 13:11 ` Jiri Olsa
2021-05-11 1:15 ` Jin, Yao
2021-05-03 15:18 ` [PATCH v1 1/2] perf header: Support HYBRID_TOPOLOGY feature Arnaldo Carvalho de Melo
2021-05-04 2:03 ` Jin, Yao
2021-05-04 14:54 ` Jiri Olsa
2021-05-06 2:01 ` Jin, Yao
2021-05-04 14:56 ` Jiri Olsa
2021-05-04 19:28 ` Arnaldo Carvalho de Melo
2021-05-04 19:37 ` Jiri Olsa [this message]
2021-05-05 13:49 ` Arnaldo Carvalho de Melo
2021-05-05 20:28 ` Jiri Olsa
2021-05-06 2:22 ` Jin, Yao
2021-05-06 2:17 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJGifgASdDD7T8Xc@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.