From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4096C433ED for ; Wed, 5 May 2021 16:20:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEF7B6121F for ; Wed, 5 May 2021 16:20:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233983AbhEEQVs (ORCPT ); Wed, 5 May 2021 12:21:48 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:54640 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233857AbhEEQVr (ORCPT ); Wed, 5 May 2021 12:21:47 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1leKGU-002hN8-IW; Wed, 05 May 2021 18:20:46 +0200 Date: Wed, 5 May 2021 18:20:46 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210429083636.22560-1-pali@kernel.org> <20210505180433.550178c8@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210505180433.550178c8@thinkpad> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 05, 2021 at 06:04:33PM +0200, Marek Behún wrote: > On Mon, 3 May 2021 14:22:49 +0200 > Andrew Lunn wrote: > > > On Thu, Apr 29, 2021 at 10:36:31AM +0200, Pali Rohár wrote: > > > From: Marek Behún > > > > > > The status decoding function mox_get_status() currently contains a dead > > > code path: if the error status is not MBOX_STS_SUCCESS, it always > > > returns -EIO, so the comparison to MBOX_STS_FAIL is never executed and > > > we don't get the actual error code sent by the firmware. > > > > > > Fix this. > > > > > > Signed-off-by: Marek Behún > > > Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver") > > > > You have put a fixes tag here, meaning you want it in stable? How does > > dead code elimination fulfil the stable requirements? > > > > Do any of these changes contain real fixes? > > > > Andrew > > Andrew, this is not dead code elimination. Please word you commit message differently. The status decoding function mox_get_status() currently contains an incorrect check: ... Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92EF5C433ED for ; Wed, 5 May 2021 16:23:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56F8F613B3 for ; Wed, 5 May 2021 16:23:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56F8F613B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yS9AfinqQjEJlS2WQv/gsWpZuQZB1BCBdIEZ6k/5GAg=; b=NoByU9qn6ujL1i+eJqhbkLcjM kNOB0ThRgRPsh3fPzibKbvLOMP2DUmxRdX6MLKDmTfhQpmOjbEf6D/NXNPWbtI2+NRSiTDqi5vwia pITFWs7vocmJ7UYvElr4+VtPK1u7DCots3Zr8a93qg5wr8bH0TzDw+mfuV0jArzna/q1qD5w4ionk 1wbUOyZcZLjdEWNNoZLbYI8Q19yEAIMm1lFkY0yzeLPri0mL95xGb2Doed5SXCCR+0JMjJlgU8jbA eKN0UMdgbLPAS7eOw73u4DfCZgM5J6N16mU9WzqaOdNbxwTdWd6rn7FUUD74Bkuui8VcaRPeWoyla 6dLjqSuFA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leKGm-001dBC-4B; Wed, 05 May 2021 16:21:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leKGj-001dB2-GS for linux-arm-kernel@desiato.infradead.org; Wed, 05 May 2021 16:21:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=g+W/KpJBW2WS82/AmcqNW4oSpKgKEka+nNgMcwDJrOQ=; b=MmsLAH8S6bmKxygsqV6gKWDrje azifJ2NiXryNCZoa/sg+FQDGmmnpHG0HyHatqjbXqFUlya+P4pwdeUNTPpT257YtHw1f5gGroGE65 R6l1dv1Bs0afdvrNMLnWfmPcFOTMsbfmE6oU+EESe0dUTZ+fJM8B6PUEG7id2AlAI9kg5Fg/2wjAs RYzh5bHbSiMcDSSzsCXPjox38Tn4mEnHtNfuwJAmArugFuPmhlHs7XkwgCKcYjrqgefm5JqHVjTkW CLZCo/A3JSufxgsAF4kFX2HRzMs1ssn2fjt96J4tPy1jMfA84RWv1ebH6yd4e9xHlPQiP+NEkbzaU DijsB0Yw==; Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leKGg-004vRP-JV for linux-arm-kernel@lists.infradead.org; Wed, 05 May 2021 16:21:00 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1leKGU-002hN8-IW; Wed, 05 May 2021 18:20:46 +0200 Date: Wed, 5 May 2021 18:20:46 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210429083636.22560-1-pali@kernel.org> <20210505180433.550178c8@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210505180433.550178c8@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_092058_668753_1D748C5E X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 05, 2021 at 06:04:33PM +0200, Marek Beh=FAn wrote: > On Mon, 3 May 2021 14:22:49 +0200 > Andrew Lunn wrote: > = > > On Thu, Apr 29, 2021 at 10:36:31AM +0200, Pali Roh=E1r wrote: > > > From: Marek Beh=FAn > > > = > > > The status decoding function mox_get_status() currently contains a de= ad > > > code path: if the error status is not MBOX_STS_SUCCESS, it always > > > returns -EIO, so the comparison to MBOX_STS_FAIL is never executed and > > > we don't get the actual error code sent by the firmware. > > > = > > > Fix this. > > > = > > > Signed-off-by: Marek Beh=FAn > > > Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver")= = > > = > > You have put a fixes tag here, meaning you want it in stable? How does > > dead code elimination fulfil the stable requirements? > > = > > Do any of these changes contain real fixes? > > = > > Andrew > = > Andrew, this is not dead code elimination. Please word you commit message differently. The status decoding function mox_get_status() currently contains an incorrect check: ... Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel