From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CD84C433B4 for ; Thu, 6 May 2021 00:14:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5FCC61164 for ; Thu, 6 May 2021 00:14:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230056AbhEFAPS (ORCPT ); Wed, 5 May 2021 20:15:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:57376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229673AbhEFAPS (ORCPT ); Wed, 5 May 2021 20:15:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A601261164; Thu, 6 May 2021 00:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620260060; bh=096xI+qq81ppXCw9EPK5Ma7vQkLFbEJxt4UQKHOxELA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Czy/j8JRaeWc7sta2wP4tEgSiNHaGZdKqOHSZjKaiKPGuLPy8rT4olB3BqJe8oAgZ VcgVLEo7aQBKvMi2/T3ay0LYiFVKkABB8zNUlMsKhfwo8MsA8ER1tgeITS+SN5jYav P/cknbOOsx+2jRW25JMIqS7uR8uAMVPV4p+jyP6X2SCQrpcV9vfFDOUwuULqzufdzd JRRmgrABnemgDzuCTsZRwVsjqBA+SgPAmlsoU2/QqBZ/I6cX8BoGqFzealQDIN5xn7 GlUgZV9mVSR4b3zMeNJ2nBMC00EuzM0AbKvbebJHdb8d1fm3OFApcS6XmIitec4guG ecKqYoOvojTJA== Date: Wed, 5 May 2021 20:14:18 -0400 From: Sasha Levin To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andrew Scull , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH AUTOSEL 5.11 036/104] KVM: arm64: Use BUG and BUG_ON in nVHE hyp Message-ID: References: <20210505163413.3461611-1-sashal@kernel.org> <20210505163413.3461611-36-sashal@kernel.org> <874kfhnn2k.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <874kfhnn2k.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 05, 2021 at 05:48:51PM +0100, Marc Zyngier wrote: >Sasha, > >On Wed, 05 May 2021 17:33:05 +0100, >Sasha Levin wrote: >> >> From: Andrew Scull >> >> [ Upstream commit f79e616f27ab6cd74deb0995a8eead3d1c9d65af ] >> >> hyp_panic() reports the address of the panic by using ELR_EL2, but this >> isn't a useful address when hyp_panic() is called directly. Replace such >> direct calls with BUG() and BUG_ON() which use BRK to trigger an >> exception that then goes to hyp_panic() with the correct address. Also >> remove the hyp_panic() declaration from the header file to avoid >> accidental misuse. >> >> Signed-off-by: Andrew Scull >> Acked-by: Will Deacon >> Signed-off-by: Marc Zyngier >> Link: https://lore.kernel.org/r/20210318143311.839894-5-ascull@google.com >> Signed-off-by: Sasha Levin > >This has no chance of working without the patches that enable BUG() >support at EL2, and *really* isn't stable material. > >Please drop this patch. Will do, thanks! -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52436C433ED for ; Thu, 6 May 2021 00:14:27 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id A5605613CD for ; Thu, 6 May 2021 00:14:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5605613CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 371D44B424; Wed, 5 May 2021 20:14:26 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f2f3Q9j74xL0; Wed, 5 May 2021 20:14:25 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2A5FD4B420; Wed, 5 May 2021 20:14:25 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4D1404B420 for ; Wed, 5 May 2021 20:14:23 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ozS9xEds-teF for ; Wed, 5 May 2021 20:14:22 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id E946C4B331 for ; Wed, 5 May 2021 20:14:21 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id A601261164; Thu, 6 May 2021 00:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620260060; bh=096xI+qq81ppXCw9EPK5Ma7vQkLFbEJxt4UQKHOxELA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Czy/j8JRaeWc7sta2wP4tEgSiNHaGZdKqOHSZjKaiKPGuLPy8rT4olB3BqJe8oAgZ VcgVLEo7aQBKvMi2/T3ay0LYiFVKkABB8zNUlMsKhfwo8MsA8ER1tgeITS+SN5jYav P/cknbOOsx+2jRW25JMIqS7uR8uAMVPV4p+jyP6X2SCQrpcV9vfFDOUwuULqzufdzd JRRmgrABnemgDzuCTsZRwVsjqBA+SgPAmlsoU2/QqBZ/I6cX8BoGqFzealQDIN5xn7 GlUgZV9mVSR4b3zMeNJ2nBMC00EuzM0AbKvbebJHdb8d1fm3OFApcS6XmIitec4guG ecKqYoOvojTJA== Date: Wed, 5 May 2021 20:14:18 -0400 From: Sasha Levin To: Marc Zyngier Subject: Re: [PATCH AUTOSEL 5.11 036/104] KVM: arm64: Use BUG and BUG_ON in nVHE hyp Message-ID: References: <20210505163413.3461611-1-sashal@kernel.org> <20210505163413.3461611-36-sashal@kernel.org> <874kfhnn2k.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <874kfhnn2k.wl-maz@kernel.org> Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, May 05, 2021 at 05:48:51PM +0100, Marc Zyngier wrote: >Sasha, > >On Wed, 05 May 2021 17:33:05 +0100, >Sasha Levin wrote: >> >> From: Andrew Scull >> >> [ Upstream commit f79e616f27ab6cd74deb0995a8eead3d1c9d65af ] >> >> hyp_panic() reports the address of the panic by using ELR_EL2, but this >> isn't a useful address when hyp_panic() is called directly. Replace such >> direct calls with BUG() and BUG_ON() which use BRK to trigger an >> exception that then goes to hyp_panic() with the correct address. Also >> remove the hyp_panic() declaration from the header file to avoid >> accidental misuse. >> >> Signed-off-by: Andrew Scull >> Acked-by: Will Deacon >> Signed-off-by: Marc Zyngier >> Link: https://lore.kernel.org/r/20210318143311.839894-5-ascull@google.com >> Signed-off-by: Sasha Levin > >This has no chance of working without the patches that enable BUG() >support at EL2, and *really* isn't stable material. > >Please drop this patch. Will do, thanks! -- Thanks, Sasha _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BAA1C433ED for ; Thu, 6 May 2021 00:17:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FCD36112D for ; Thu, 6 May 2021 00:17:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FCD36112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jXEWV5IZEkJPx24xzlSsxqPwm/G4Gb473Vqspy5/dA4=; b=pZ3uw/FdiCMYB4nOEBzJv1+Lg NOoqxXyMWGw1g3JNsZX0Cd0/JbqOFtHWw4TtLLG+tTtslXdmpFTq9R1bYyE8octhwzftSlLpr9w5B 3f96OtaFIisIikMlHQzInnJGoGM92r2adlrxaFcByu2iWRVGoi65MtXqldfUXPO3C9PMZS6YDIG01 2GLXYzAB9+rjDE8JPECxzlTIK2/oSCEV8Mugopy8lZrI1sRviH91ajZCydYf1hxqC7W9N0dszG+zS 9OgjClI5yXDFa14aGeMs3BeMmRDUsxUPZPCSwya5wmcXLy5V7OTch4/jSziHzpTUnZ3I88NEMr1Fb F6jLJv/TQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRfE-002gQk-NY; Thu, 06 May 2021 00:14:50 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leReq-002gOv-96 for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:14:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JtDzGA73yH40Myz6cmrOSThogiCP8hK+/HgzhGQMxTQ=; b=Hgznl3NwGA8RYgsylySjGgBIEr rCPNr+NPvHAOQddX5oQkRL/CJqZlFapr9dTd2d2SbAi8SQe1G0JhW7htwZGzXtSFuucv14cmX4/UP tc8wWPVS4D8Kh6+/gdhKgcPt0NOqpWFA8Xy8qCszkvqy+lZn+32LFSZDq8QcvkaikNMr8TUEi27iX y6mVKHbHWNpywly8SMNGkwdhibO0lg7gKwBxS/FtqZgdrSMc0dFV+xidyr3DdBN21QEsdHxuEfiFk MupFYCC4nvBvK3yraYtP30boSHsA99ZSbmd/wTwjGjzlVcAabyZXbdhjKyZMkuXMpedlJWOn2qnEG BAtz4Elw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRen-005QUF-LO for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:14:23 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A601261164; Thu, 6 May 2021 00:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620260060; bh=096xI+qq81ppXCw9EPK5Ma7vQkLFbEJxt4UQKHOxELA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Czy/j8JRaeWc7sta2wP4tEgSiNHaGZdKqOHSZjKaiKPGuLPy8rT4olB3BqJe8oAgZ VcgVLEo7aQBKvMi2/T3ay0LYiFVKkABB8zNUlMsKhfwo8MsA8ER1tgeITS+SN5jYav P/cknbOOsx+2jRW25JMIqS7uR8uAMVPV4p+jyP6X2SCQrpcV9vfFDOUwuULqzufdzd JRRmgrABnemgDzuCTsZRwVsjqBA+SgPAmlsoU2/QqBZ/I6cX8BoGqFzealQDIN5xn7 GlUgZV9mVSR4b3zMeNJ2nBMC00EuzM0AbKvbebJHdb8d1fm3OFApcS6XmIitec4guG ecKqYoOvojTJA== Date: Wed, 5 May 2021 20:14:18 -0400 From: Sasha Levin To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andrew Scull , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH AUTOSEL 5.11 036/104] KVM: arm64: Use BUG and BUG_ON in nVHE hyp Message-ID: References: <20210505163413.3461611-1-sashal@kernel.org> <20210505163413.3461611-36-sashal@kernel.org> <874kfhnn2k.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <874kfhnn2k.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_171421_753515_55105A20 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 05, 2021 at 05:48:51PM +0100, Marc Zyngier wrote: >Sasha, > >On Wed, 05 May 2021 17:33:05 +0100, >Sasha Levin wrote: >> >> From: Andrew Scull >> >> [ Upstream commit f79e616f27ab6cd74deb0995a8eead3d1c9d65af ] >> >> hyp_panic() reports the address of the panic by using ELR_EL2, but this >> isn't a useful address when hyp_panic() is called directly. Replace such >> direct calls with BUG() and BUG_ON() which use BRK to trigger an >> exception that then goes to hyp_panic() with the correct address. Also >> remove the hyp_panic() declaration from the header file to avoid >> accidental misuse. >> >> Signed-off-by: Andrew Scull >> Acked-by: Will Deacon >> Signed-off-by: Marc Zyngier >> Link: https://lore.kernel.org/r/20210318143311.839894-5-ascull@google.com >> Signed-off-by: Sasha Levin > >This has no chance of working without the patches that enable BUG() >support at EL2, and *really* isn't stable material. > >Please drop this patch. Will do, thanks! -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel