From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B4C0C43461 for ; Thu, 6 May 2021 16:04:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9708C61073 for ; Thu, 6 May 2021 16:04:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9708C61073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1legTq-0002EQ-B2 for qemu-devel@archiver.kernel.org; Thu, 06 May 2021 12:04:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1legMT-0006ub-MH for qemu-devel@nongnu.org; Thu, 06 May 2021 11:56:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1legMO-0008QX-Sp for qemu-devel@nongnu.org; Thu, 06 May 2021 11:56:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620316580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QMLV4shi+68TOZM9hTX40Iz+aDBb+Xike0tvlRJqWmY=; b=gLCIxDSafhSuI5AMpz+K6ZxAL+qiUEspW4LhQFkpEnHbAAtTycZazYJKEOdlttKIdPzfKW 4ozmP7HjAozUUu4ssQs0t8rKL7NQgXvDZCpIkK1kL61e5NZDXa5lEEmSiOVW49xSOhNztf nbOjgIJ0gwMQab8snKoEZKyUzb0QDBE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-227-jsDbzTVmMeKVS15m8dYIxw-1; Thu, 06 May 2021 11:56:18 -0400 X-MC-Unique: jsDbzTVmMeKVS15m8dYIxw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA16980ED9D; Thu, 6 May 2021 15:56:17 +0000 (UTC) Received: from work-vm (ovpn-115-37.ams2.redhat.com [10.36.115.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6B1E5C22B; Thu, 6 May 2021 15:56:09 +0000 (UTC) Date: Thu, 6 May 2021 16:56:07 +0100 From: "Dr. David Alan Gilbert" To: qemu-devel@nongnu.org, vgoyal@redhat.com, stefanha@redhat.com, groug@kaod.org Subject: Re: [PATCH v3 01/26] virtiofs: Fixup printf args Message-ID: References: <20210428110100.27757-1-dgilbert@redhat.com> <20210428110100.27757-2-dgilbert@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210428110100.27757-2-dgilbert@redhat.com> User-Agent: Mutt/2.0.6 (2021-03-06) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.69, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Fixup some fuse_log printf args for 32bit compatibility. > > Signed-off-by: Dr. David Alan Gilbert queued this 1/26 only > --- > tools/virtiofsd/passthrough_ll.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c > index 1553d2ef45..110f85a701 100644 > --- a/tools/virtiofsd/passthrough_ll.c > +++ b/tools/virtiofsd/passthrough_ll.c > @@ -2011,10 +2011,10 @@ static void lo_getlk(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info *fi, > > fuse_log(FUSE_LOG_DEBUG, > "lo_getlk(ino=%" PRIu64 ", flags=%d)" > - " owner=0x%lx, l_type=%d l_start=0x%lx" > - " l_len=0x%lx\n", > - ino, fi->flags, fi->lock_owner, lock->l_type, lock->l_start, > - lock->l_len); > + " owner=0x%" PRIx64 ", l_type=%d l_start=0x%" PRIx64 > + " l_len=0x%" PRIx64 "\n", > + ino, fi->flags, fi->lock_owner, lock->l_type, > + (uint64_t)lock->l_start, (uint64_t)lock->l_len); > > if (!lo->posix_lock) { > fuse_reply_err(req, ENOSYS); > @@ -2061,10 +2061,10 @@ static void lo_setlk(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info *fi, > > fuse_log(FUSE_LOG_DEBUG, > "lo_setlk(ino=%" PRIu64 ", flags=%d)" > - " cmd=%d pid=%d owner=0x%lx sleep=%d l_whence=%d" > - " l_start=0x%lx l_len=0x%lx\n", > + " cmd=%d pid=%d owner=0x%" PRIx64 " sleep=%d l_whence=%d" > + " l_start=0x%" PRIx64 " l_len=0x%" PRIx64 "\n", > ino, fi->flags, lock->l_type, lock->l_pid, fi->lock_owner, sleep, > - lock->l_whence, lock->l_start, lock->l_len); > + lock->l_whence, (uint64_t)lock->l_start, (uint64_t)lock->l_len); > > if (!lo->posix_lock) { > fuse_reply_err(req, ENOSYS); > @@ -3097,9 +3097,10 @@ static void lo_copy_file_range(fuse_req_t req, fuse_ino_t ino_in, off_t off_in, > > fuse_log(FUSE_LOG_DEBUG, > "lo_copy_file_range(ino=%" PRIu64 "/fd=%d, " > - "off=%lu, ino=%" PRIu64 "/fd=%d, " > - "off=%lu, size=%zd, flags=0x%x)\n", > - ino_in, in_fd, off_in, ino_out, out_fd, off_out, len, flags); > + "off=%ju, ino=%" PRIu64 "/fd=%d, " > + "off=%ju, size=%zd, flags=0x%x)\n", > + ino_in, in_fd, (intmax_t)off_in, > + ino_out, out_fd, (intmax_t)off_out, len, flags); > > res = copy_file_range(in_fd, &off_in, out_fd, &off_out, len, flags); > if (res < 0) { > -- > 2.31.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 6 May 2021 16:56:07 +0100 From: "Dr. David Alan Gilbert" Message-ID: References: <20210428110100.27757-1-dgilbert@redhat.com> <20210428110100.27757-2-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210428110100.27757-2-dgilbert@redhat.com> Subject: Re: [Virtio-fs] [PATCH v3 01/26] virtiofs: Fixup printf args List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, vgoyal@redhat.com, stefanha@redhat.com, groug@kaod.org Cc: virtio-fs@redhat.com * Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Fixup some fuse_log printf args for 32bit compatibility. > > Signed-off-by: Dr. David Alan Gilbert queued this 1/26 only > --- > tools/virtiofsd/passthrough_ll.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c > index 1553d2ef45..110f85a701 100644 > --- a/tools/virtiofsd/passthrough_ll.c > +++ b/tools/virtiofsd/passthrough_ll.c > @@ -2011,10 +2011,10 @@ static void lo_getlk(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info *fi, > > fuse_log(FUSE_LOG_DEBUG, > "lo_getlk(ino=%" PRIu64 ", flags=%d)" > - " owner=0x%lx, l_type=%d l_start=0x%lx" > - " l_len=0x%lx\n", > - ino, fi->flags, fi->lock_owner, lock->l_type, lock->l_start, > - lock->l_len); > + " owner=0x%" PRIx64 ", l_type=%d l_start=0x%" PRIx64 > + " l_len=0x%" PRIx64 "\n", > + ino, fi->flags, fi->lock_owner, lock->l_type, > + (uint64_t)lock->l_start, (uint64_t)lock->l_len); > > if (!lo->posix_lock) { > fuse_reply_err(req, ENOSYS); > @@ -2061,10 +2061,10 @@ static void lo_setlk(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info *fi, > > fuse_log(FUSE_LOG_DEBUG, > "lo_setlk(ino=%" PRIu64 ", flags=%d)" > - " cmd=%d pid=%d owner=0x%lx sleep=%d l_whence=%d" > - " l_start=0x%lx l_len=0x%lx\n", > + " cmd=%d pid=%d owner=0x%" PRIx64 " sleep=%d l_whence=%d" > + " l_start=0x%" PRIx64 " l_len=0x%" PRIx64 "\n", > ino, fi->flags, lock->l_type, lock->l_pid, fi->lock_owner, sleep, > - lock->l_whence, lock->l_start, lock->l_len); > + lock->l_whence, (uint64_t)lock->l_start, (uint64_t)lock->l_len); > > if (!lo->posix_lock) { > fuse_reply_err(req, ENOSYS); > @@ -3097,9 +3097,10 @@ static void lo_copy_file_range(fuse_req_t req, fuse_ino_t ino_in, off_t off_in, > > fuse_log(FUSE_LOG_DEBUG, > "lo_copy_file_range(ino=%" PRIu64 "/fd=%d, " > - "off=%lu, ino=%" PRIu64 "/fd=%d, " > - "off=%lu, size=%zd, flags=0x%x)\n", > - ino_in, in_fd, off_in, ino_out, out_fd, off_out, len, flags); > + "off=%ju, ino=%" PRIu64 "/fd=%d, " > + "off=%ju, size=%zd, flags=0x%x)\n", > + ino_in, in_fd, (intmax_t)off_in, > + ino_out, out_fd, (intmax_t)off_out, len, flags); > > res = copy_file_range(in_fd, &off_in, out_fd, &off_out, len, flags); > if (res < 0) { > -- > 2.31.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK