From: Jeff King <peff@peff.net>
To: Will Chandler <wfc@wfchandler.org>
Cc: git@vger.kernel.org, ps@pks.im
Subject: Re: [PATCH] refs: cleanup directories when deleting packed ref
Date: Fri, 7 May 2021 18:02:17 -0400 [thread overview]
Message-ID: <YJW46fsdKaUv2Fln@coredump.intra.peff.net> (raw)
In-Reply-To: <YJW3n6lVWVAuLQap@coredump.intra.peff.net>
On Fri, May 07, 2021 at 05:56:47PM -0400, Jeff King wrote:
> > +test_expect_success 'directory not created deleting packed ref' '
> > + git branch d1/d2/r1 HEAD &&
> > + git pack-refs --all &&
> > + test_path_is_missing .git/refs/heads/d1/d2 &&
> > + git branch -d d1/d2/r1 &&
> > + test_path_is_missing .git/refs/heads/d1/d2 &&
> > + test_path_is_missing .git/refs/heads/d1
> > +'
>
> ...this test passes even without your patch applied. I wonder if there's
> something else required to trigger the problem.
If I replace "git branch -d" with "git update-ref -d", then the problem
does trigger (and your patch does indeed clear it up). I wonder what the
difference is.
-Peff
next prev parent reply other threads:[~2021-05-07 22:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 14:37 [PATCH] refs: cleanup directories when deleting packed ref Will Chandler
2021-05-07 21:56 ` Jeff King
2021-05-07 22:02 ` Jeff King [this message]
2021-05-07 22:57 ` Jeff King
2021-05-08 4:27 ` Will Chandler
2021-05-08 5:00 ` Will Chandler
2021-05-08 5:21 ` Bagas Sanjaya
2021-05-08 6:24 ` Junio C Hamano
2021-05-09 18:45 ` Will Chandler
2021-05-10 1:15 ` Junio C Hamano
2021-05-11 1:35 ` Jeff King
2021-05-11 4:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJW46fsdKaUv2Fln@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=wfc@wfchandler.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.