All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, Sunil Pai G <sunil.pai.g@intel.com>
Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix parameter shadow warning
Date: Mon, 10 May 2021 10:02:42 +0100	[thread overview]
Message-ID: <YJj2spfJ0JTzi2ti@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20210507172025.181720-1-kevin.laatz@intel.com>

On Fri, May 07, 2021 at 05:20:25PM +0000, Kevin Laatz wrote:
> In the function __idxd_completed_ops() we have a parameter shadow warning
> due to a local variable having the same name as one of the function
> parameters. This is fixed by simply renaming the local variable.
> 
> Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs")
> 
> Reported-by: Sunil Pai G <sunil.pai.g@intel.com>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
Please provide details in the commit log as to how/when this was seen. I
believe this issue was seen only with OVS because it passes the -Wshadow
flag when building - something DPDK probably should do, but doesn't. Is
that correct?

  parent reply	other threads:[~2021-05-10  9:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 17:20 Kevin Laatz
2021-05-08  7:25 ` Pai G, Sunil
2021-05-10  9:02 ` Bruce Richardson [this message]
2021-05-10 11:07   ` Laatz, Kevin
2021-05-10 12:55 ` [dpdk-dev] [PATCH v2] " Kevin Laatz
2021-05-10 13:36   ` Bruce Richardson
2021-05-10 14:06   ` David Marchand
2021-05-10 14:48     ` Bruce Richardson
2021-05-11 20:49       ` Thomas Monjalon
2021-05-12 10:47   ` [dpdk-dev] [PATCH v3] " Kevin Laatz
2021-05-12 12:59     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJj2spfJ0JTzi2ti@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=kevin.laatz@intel.com \
    --cc=sunil.pai.g@intel.com \
    --subject='Re: [dpdk-dev] [PATCH] raw/ioat: fix parameter shadow warning' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.