From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A92EAC433ED for ; Mon, 10 May 2021 09:02:51 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 0AAD961132 for ; Mon, 10 May 2021 09:02:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AAD961132 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B102440140; Mon, 10 May 2021 11:02:49 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 6A8514003E for ; Mon, 10 May 2021 11:02:48 +0200 (CEST) IronPort-SDR: A5Kk/EjUSveTmBHlUYvP4I35p35hY23C+MU2dnlOl0oYrpRwKjpkK7au8QZFe0EAAgtAxKEy/w 0ERwOIO1ZbtA== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="220090380" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="220090380" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 02:02:46 -0700 IronPort-SDR: fu1uDzPHfEAs1Ejq7ERtB914MznAJpD/ddAF75oUP10c8aa8Ge1xIwh4mkFSazJXCOGmHRZVWa kbdAIwbKP7ZA== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="436054392" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.68]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 May 2021 02:02:45 -0700 Date: Mon, 10 May 2021 10:02:42 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org, Sunil Pai G Message-ID: References: <20210507172025.181720-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210507172025.181720-1-kevin.laatz@intel.com> Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix parameter shadow warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 07, 2021 at 05:20:25PM +0000, Kevin Laatz wrote: > In the function __idxd_completed_ops() we have a parameter shadow warning > due to a local variable having the same name as one of the function > parameters. This is fixed by simply renaming the local variable. > > Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs") > > Reported-by: Sunil Pai G > Signed-off-by: Kevin Laatz > --- Please provide details in the commit log as to how/when this was seen. I believe this issue was seen only with OVS because it passes the -Wshadow flag when building - something DPDK probably should do, but doesn't. Is that correct?