From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25579C4363F for ; Mon, 10 May 2021 12:50:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08954610F8 for ; Mon, 10 May 2021 12:50:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349457AbhEJMta (ORCPT ); Mon, 10 May 2021 08:49:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241048AbhEJLh0 (ORCPT ); Mon, 10 May 2021 07:37:26 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3770C0612EF for ; Mon, 10 May 2021 04:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=TVPjZAPijAHa4LLIWNuJ7wX5h0yLsHB88OKvBcyrgOo=; b=Gw1gDi9F8ySm9OmXtdCpTxBtJg Nq3qzu+lXQfCZfJwhi+774DevttDiMcVEwLMIXFt6kcxjVSmJKOBvR/oN1/wZk8GwzpL6opOQwnEr eWvtD1szk+xiE7MTg/c6Cd4ktFdvjdYp0YELxgAg1m2R5H4h/7/R1cLpqj6ylG3WTx1ljqIocEFuv 521+Hbg4Nb+AkVWd7EReAGd6Uq+gwPWjom7BhVcI8qV+q447UnxQ7X/JPUmtBqEUtgd4XfGQZHyk6 5XLw1M5g+Y7DFnFv6oBshdWuk/6MEJCRw5EeShxPlFUk6obt6nFHGmcIXXK5q2/Sfyp+oRlBTNwhT OnHZTXCQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lg48m-00E5um-VO; Mon, 10 May 2021 11:32:01 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 32B893002C4; Mon, 10 May 2021 13:32:00 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 10A7C2028F007; Mon, 10 May 2021 13:32:00 +0200 (CEST) Date: Mon, 10 May 2021 13:31:59 +0200 From: Peter Zijlstra To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org, Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: Re: [PATCH 0/3] xen: remove some checks for always present Xen features Message-ID: References: <20210422151007.2205-1-jgross@suse.com> <3c89ca14-8790-2d0e-a115-16a0976f68e3@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <3c89ca14-8790-2d0e-a115-16a0976f68e3@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 10, 2021 at 09:34:18AM +0200, Juergen Gross wrote: > On 22.04.21 17:10, Juergen Gross wrote: > > Some features of Xen can be assumed to be always present, so add a > > central check to verify this being true and remove the other checks. > >=20 > > Juergen Gross (3): > > xen: check required Xen features > > xen: assume XENFEAT_mmu_pt_update_preserve_ad being set for pv guests > > xen: assume XENFEAT_gnttab_map_avail_bits being set for pv guests > >=20 > > arch/x86/xen/enlighten_pv.c | 12 ++---------- > > arch/x86/xen/mmu_pv.c | 4 ++-- > > drivers/xen/features.c | 18 ++++++++++++++++++ > > drivers/xen/gntdev.c | 36 ++---------------------------------- > > 4 files changed, 24 insertions(+), 46 deletions(-) > >=20 >=20 > Could I please get some feedback on this series? I'm obviously in favour, but given I'm not an actual Xen user that might not be worth much, still: Acked-by: Peter Zijlstra (Intel)