From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09170C43461 for ; Mon, 10 May 2021 13:02:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3EF561040 for ; Mon, 10 May 2021 13:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350321AbhEJM5K (ORCPT ); Mon, 10 May 2021 08:57:10 -0400 Received: from mga18.intel.com ([134.134.136.126]:62648 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348133AbhEJMkQ (ORCPT ); Mon, 10 May 2021 08:40:16 -0400 IronPort-SDR: /F+7haN7w14ep2tcd6GrwJ4ObO1r0XvmEHJuEQAt/Lm6cPAwEdvcvnPsdsodpdr5MERlIlWhYR JwvLzMI3BvLA== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="186630435" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="186630435" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 05:39:11 -0700 IronPort-SDR: qr+vKfhFFOxuAriRn/h1VWiMb0tXm1Qu5IZa5twkTj1uqIaFfwLl8EDw5CS3NBEwX2Poquub4Y Pgla+J4ZgJjA== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="470782756" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 05:39:00 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lg5BY-00BAPk-PH; Mon, 10 May 2021 15:38:56 +0300 Date: Mon, 10 May 2021 15:38:56 +0300 From: Andy Shevchenko To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood , Haojian Zhuang , Robert Jarzmik , Daniel Mack Subject: Re: [PATCH v2 07/14] spi: pxa2xx: Introduce int_stop_and_reset() helper Message-ID: References: <20210423182441.50272-1-andriy.shevchenko@linux.intel.com> <20210423182441.50272-8-andriy.shevchenko@linux.intel.com> <20210510120953.GA15173@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510120953.GA15173@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 10, 2021 at 01:09:53PM +0100, Mark Brown wrote: > On Fri, Apr 23, 2021 at 09:24:34PM +0300, Andy Shevchenko wrote: > > Currently we have three times the same few lines repeated in the code. > > Deduplicate them by newly introduced int_stop_and_reset() helper. > > This doesn't apply against current code, please check and resend. Hmm... Can you, please, point out, what branch should I use? It seems good against v5.13-rc1 and spi/for-5.14. Okay, I will resend against spi/for-5.14, but I don't see the issue here. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CDC4C433ED for ; Mon, 10 May 2021 12:40:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCFBF61075 for ; Mon, 10 May 2021 12:40:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCFBF61075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D6B8716A2; Mon, 10 May 2021 14:39:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D6B8716A2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1620650409; bh=5SofxNKeEKJyLUmGPf5J50yS3HL9/uRmaU+Pl43dXBY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qLU6lwlqqpwDAVJ15Jur1O4OMT1ZDdBYgoe+/gjgAGQa2h6rxxC1iSNGNnoCYDVxQ 70Kb6Ulc35zIcwLs5I4jL4RXFchWzlBOewbpwcbR8OXzmbMiNqgxKWiUWpLn4V2PNh I2/AvKcdfKXHTwlVBu0DmJj39lnEJOQSDsMe72/0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7058CF800B4; Mon, 10 May 2021 14:39:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 91EE1F80240; Mon, 10 May 2021 14:39:18 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 84597F800B4 for ; Mon, 10 May 2021 14:39:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 84597F800B4 IronPort-SDR: cQD21UsXK+KX+s2raSRVxTSouHIvLXxPiQn8WUJt5nUzueCqE9t3HoJ0abljpB8XZCBtqVUwE2 rA+EdYw+nhWA== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="220129980" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="220129980" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 05:39:12 -0700 IronPort-SDR: qr+vKfhFFOxuAriRn/h1VWiMb0tXm1Qu5IZa5twkTj1uqIaFfwLl8EDw5CS3NBEwX2Poquub4Y Pgla+J4ZgJjA== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="470782756" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 05:39:00 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lg5BY-00BAPk-PH; Mon, 10 May 2021 15:38:56 +0300 Date: Mon, 10 May 2021 15:38:56 +0300 From: Andy Shevchenko To: Mark Brown Subject: Re: [PATCH v2 07/14] spi: pxa2xx: Introduce int_stop_and_reset() helper Message-ID: References: <20210423182441.50272-1-andriy.shevchenko@linux.intel.com> <20210423182441.50272-8-andriy.shevchenko@linux.intel.com> <20210510120953.GA15173@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510120953.GA15173@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Liam Girdwood , Haojian Zhuang , Takashi Iwai , Daniel Mack , linux-spi@vger.kernel.org, Robert Jarzmik , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, May 10, 2021 at 01:09:53PM +0100, Mark Brown wrote: > On Fri, Apr 23, 2021 at 09:24:34PM +0300, Andy Shevchenko wrote: > > Currently we have three times the same few lines repeated in the code. > > Deduplicate them by newly introduced int_stop_and_reset() helper. > > This doesn't apply against current code, please check and resend. Hmm... Can you, please, point out, what branch should I use? It seems good against v5.13-rc1 and spi/for-5.14. Okay, I will resend against spi/for-5.14, but I don't see the issue here. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F84CC433ED for ; Mon, 10 May 2021 12:41:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA93261432 for ; Mon, 10 May 2021 12:41:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA93261432 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rsqeyAq8u5UP1PdRbaxBVSZ0URj70rttRd+RLbBgaNU=; b=OdItsufXIcxASdwd9/cYta9cL a5CfipjtfxmRbIyQ0a5L+lTGm8JQdhYSJlEUIups9Ohy6YNoluGnBTQ1vbNn7WG1s3xFhuCt4TvPt FNoDUwAv5C/W8X+rR19a2AK/wxgwRPo+urlXk6Tka1ImM/y5MbdDYYmIJftyCFY6CR8BN2z9jxsKC LZvGFvc6esZwk5acKCzbrlvwDLSaR9EPW8XMMZMMCaVyiqrT3vuLMwJcZ/h92903cnIHJf4FX7GoV RsyBaZXgICG4BzAL70fyp963CLi0GaC3CMmJ1tv2NOU+CJhir7xvnbGM8IDs3nel/F5PWQRndxro5 ET8wIezmQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lg5Bz-00EI5i-A9; Mon, 10 May 2021 12:39:23 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg5Bw-00EI5Z-6k for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 12:39:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KKB24NmvUY7jWmOW1IhSQl8t0TA8H7UpM6y2/P02dBo=; b=m6fcp4S6RikmI3UazKDx4E0ggP 0JwWgDwsrZd7ABOdn+N223AVGcpK+WPYU7x3EobZChlIv5Zx7SFgONyzIgKOBEwkWUlOaO+CN281d dF6LP1/yd3ufXCYx+el4XNIwHZuw7CXe0kGtE92BbK/jVYOC56ZDxSicZHgMsv/FssaqnUGM3kKaB 7vasXW4C3iBLWIXvU1Iw8BkgNpspzdkQiQ/su0DT0g/YRYuvGwkWHdYrH2pFUzRbW7BnZdOPvn3Vj UO68jhrnaPPOUznbrPvdsVp6yjiFSHl+ca5XQ5ZagfEdVMIDMa3nDma4+OvL9/gIqbbv2UF89W0oz uRDugprg==; Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg5Bt-008hMr-NV for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 12:39:18 +0000 IronPort-SDR: sdCDzjEcxBt7vX6DIuJEHzl5LvOqaSzABE18WALN59hVtLSXfyatHxWxoIivdoaW24AcFXP3qj +f/cQ3sDxuDA== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="179448014" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="179448014" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 05:39:12 -0700 IronPort-SDR: qr+vKfhFFOxuAriRn/h1VWiMb0tXm1Qu5IZa5twkTj1uqIaFfwLl8EDw5CS3NBEwX2Poquub4Y Pgla+J4ZgJjA== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="470782756" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 05:39:00 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lg5BY-00BAPk-PH; Mon, 10 May 2021 15:38:56 +0300 Date: Mon, 10 May 2021 15:38:56 +0300 From: Andy Shevchenko To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood , Haojian Zhuang , Robert Jarzmik , Daniel Mack Subject: Re: [PATCH v2 07/14] spi: pxa2xx: Introduce int_stop_and_reset() helper Message-ID: References: <20210423182441.50272-1-andriy.shevchenko@linux.intel.com> <20210423182441.50272-8-andriy.shevchenko@linux.intel.com> <20210510120953.GA15173@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210510120953.GA15173@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_053917_793825_8BB2EFFC X-CRM114-Status: GOOD ( 12.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 10, 2021 at 01:09:53PM +0100, Mark Brown wrote: > On Fri, Apr 23, 2021 at 09:24:34PM +0300, Andy Shevchenko wrote: > > Currently we have three times the same few lines repeated in the code. > > Deduplicate them by newly introduced int_stop_and_reset() helper. > > This doesn't apply against current code, please check and resend. Hmm... Can you, please, point out, what branch should I use? It seems good against v5.13-rc1 and spi/for-5.14. Okay, I will resend against spi/for-5.14, but I don't see the issue here. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel