All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH v3 4/4] lib: reset SIGTERM to original disposition if timeout occured
@ 2021-05-08  5:51 Li Wang
  2021-05-10 11:57 ` Cyril Hrubis
  0 siblings, 1 reply; 4+ messages in thread
From: Li Wang @ 2021-05-08  5:51 UTC (permalink / raw)
  To: ltp

To limit the "kill $sleep_pid; exit" action only effect on the
sleep proccess will make code easy to understand.

Also, to get rid of below redundant behavior:
  ./../../../testcases/lib/tst_test.sh: line 1: kill: (242089) - No such process

Signed-off-by: Li Wang <liwang@redhat.com>
---
 testcases/lib/tst_test.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
index b6ca0cb26..28c2052d6 100644
--- a/testcases/lib/tst_test.sh
+++ b/testcases/lib/tst_test.sh
@@ -472,6 +472,7 @@ _tst_timeout_process()
 	sleep_pid=$!
 	trap "kill $sleep_pid; exit" TERM
 	wait $sleep_pid
+	trap - TERM
 	_tst_kill_test
 }
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [LTP] [PATCH v3 4/4] lib: reset SIGTERM to original disposition if timeout occured
  2021-05-08  5:51 [LTP] [PATCH v3 4/4] lib: reset SIGTERM to original disposition if timeout occured Li Wang
@ 2021-05-10 11:57 ` Cyril Hrubis
  2021-05-10 12:45   ` Li Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2021-05-10 11:57 UTC (permalink / raw)
  To: ltp

Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

The whole series looks good to me. I'm ok with merging these changes
beofre the release.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [LTP] [PATCH v3 4/4] lib: reset SIGTERM to original disposition if timeout occured
  2021-05-10 11:57 ` Cyril Hrubis
@ 2021-05-10 12:45   ` Li Wang
  2021-05-10 14:38     ` Petr Vorel
  0 siblings, 1 reply; 4+ messages in thread
From: Li Wang @ 2021-05-10 12:45 UTC (permalink / raw)
  To: ltp

On Mon, May 10, 2021 at 8:23 PM Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Hi!
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
>
> The whole series looks good to me. I'm ok with merging these changes
> beofre the release.

Thanks for the review! Patchset tweaked with your suggestions and merged.

-- 
Regards,
Li Wang


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [LTP] [PATCH v3 4/4] lib: reset SIGTERM to original disposition if timeout occured
  2021-05-10 12:45   ` Li Wang
@ 2021-05-10 14:38     ` Petr Vorel
  0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2021-05-10 14:38 UTC (permalink / raw)
  To: ltp

> On Mon, May 10, 2021 at 8:23 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> > Hi!
> > Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

> > The whole series looks good to me. I'm ok with merging these changes
> > beofre the release.

> Thanks for the review! Patchset tweaked with your suggestions and merged.

Thanks!

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-10 14:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08  5:51 [LTP] [PATCH v3 4/4] lib: reset SIGTERM to original disposition if timeout occured Li Wang
2021-05-10 11:57 ` Cyril Hrubis
2021-05-10 12:45   ` Li Wang
2021-05-10 14:38     ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.