From: Bruce Richardson <firstname.lastname@example.org> To: David Marchand <email@example.com> Cc: Kevin Laatz <firstname.lastname@example.org>, dev <email@example.com>, Sunil Pai G <firstname.lastname@example.org> Subject: Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning Date: Mon, 10 May 2021 15:48:27 +0100 [thread overview] Message-ID: <YJlHuwlX5KuRBVdO@bricha3-MOBL.ger.corp.intel.com> (raw) In-Reply-To: <CAJFAV8yVNr7suYWM6Wm60km=yLu7EOdi57QuBLhjh1RZfzCvuQ@mail.gmail.com> On Mon, May 10, 2021 at 04:06:00PM +0200, David Marchand wrote: > On Mon, May 10, 2021 at 2:55 PM Kevin Laatz <email@example.com> wrote: > > > > In the function __idxd_completed_ops() we have a parameter shadow warning > > due to a local variable having the same name as one of the function > > parameters. This issue is fixed by simply renaming the local variable. > > > > This warning was discovered during an OVS build with DPDK 21.05-rc2. The > > OVS build passes the -Wshadow flag by default, allowing the warning to be > > seen. > > A bit confusing. > -Wshadow only affects OVS code and there is no code calling this in > the OVS master branch. > > I did not see this issue while updating my dpdk-latest OVS branch and > running builds in GHA. > So I guess Sunil caught it with his patch: > https://firstname.lastname@example.org/ > Yes, it was caught by Sunil in the course of his work. Ideally, I think -Wshadow would be a good flag to add to our DPDK builds, but it causes quite a number of errors right now to do so. Hopefully in a future release. /Bruce
next prev parent reply other threads:[~2021-05-10 14:48 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-07 17:20 [dpdk-dev] [PATCH] " Kevin Laatz 2021-05-08 7:25 ` Pai G, Sunil 2021-05-10 9:02 ` Bruce Richardson 2021-05-10 11:07 ` Laatz, Kevin 2021-05-10 12:55 ` [dpdk-dev] [PATCH v2] " Kevin Laatz 2021-05-10 13:36 ` Bruce Richardson 2021-05-10 14:06 ` David Marchand 2021-05-10 14:48 ` Bruce Richardson [this message] 2021-05-11 20:49 ` Thomas Monjalon 2021-05-12 10:47 ` [dpdk-dev] [PATCH v3] " Kevin Laatz 2021-05-12 12:59 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJlHuwlX5KuRBVdO@bricha3-MOBL.ger.corp.intel.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.