From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-integrity <linux-integrity@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl()
Date: Wed, 12 May 2021 04:21:50 +0300 [thread overview]
Message-ID: <YJstroyoV5KfEh/m@kernel.org> (raw)
In-Reply-To: <b79b306a-71da-f655-3e68-11f1c9df4115@huawei.com>
On Wed, May 12, 2021 at 09:12:26AM +0800, Leizhen (ThunderTown) wrote:
>
>
> On 2021/5/10 4:41, Jarkko Sakkinen wrote:
> > On Sat, May 08, 2021 at 10:54:44AM +0800, Zhen Lei wrote:
> >> Fix to return a negative error code from the error handling
> >> case instead of 0, as done elsewhere in this function.
> >>
> >> Fixes: 58472f5cd4f6("tpm: validate TPM 2.0 commands")
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> >
> > In the commit message:
> >
> > 1. Instead of writing "a negative error code", write -EFAULT.
> OK, I will change it.
>
> > 2. Some explanation of the choice.
> Do you mean why I choice error code -EFAULT? There's a similar one above this branch.
>
> if (nr_commands > 0xFFFFF) {
> rc = -EFAULT;
> goto out;
> }
I mean that the commit message must rationalize whatever the commit does,
and choices made.
/Jarkko
prev parent reply other threads:[~2021-05-12 1:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 2:54 [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl() Zhen Lei
2021-05-09 20:41 ` Jarkko Sakkinen
2021-05-12 1:12 ` Leizhen (ThunderTown)
2021-05-12 1:21 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJstroyoV5KfEh/m@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.