From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6468C433ED for ; Wed, 12 May 2021 12:50:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABA4561104 for ; Wed, 12 May 2021 12:50:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230347AbhELMve (ORCPT ); Wed, 12 May 2021 08:51:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:50464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbhELMve (ORCPT ); Wed, 12 May 2021 08:51:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 89EFE613CA; Wed, 12 May 2021 12:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620823826; bh=uGZN093G8UznNDfSiUvQMW1X6K1u4U9norEFO5yfBeU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qY3xt5DM9nNrf/qzNYHSoEht97NuI/NL/B7mp1RgXdwLN323h6lINp63PXOM1ESqF 3MI7HBDlJ3q/OMgjDp2fOWSX4gkDShnedRWL1fkC7VSmfXfD3QYpGpiPuzYYB8Yl5P qybPIx2OIxF7CpqutOGTqnMk2zYiP+mEeeEC7jno7Sdk6TBuzjh5vPf+JKK/ud3niX B7+MXNsbwvtxLyqiuE1i2qTpxHdzFrgfMAoD/PtEdB3PKj0RFsx7UVfQ1cwOY6pXid Zxh2AC9uLPqYA3lJbB2DmYO9n3O/DbU8KypLraFHaoNsfe6O2Da47pmtXOD2z2ZDEA 1GvKgH2V0PL3Q== Date: Wed, 12 May 2021 15:50:21 +0300 From: Leon Romanovsky To: "Marciniszyn, Mike" Cc: "Dalessandro, Dennis" , Doug Ledford , Jason Gunthorpe , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: [PATCH rdma-next] RDMA/rdmavt: Decouple QP and SGE lists allocations Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, May 12, 2021 at 12:25:15PM +0000, Marciniszyn, Mike wrote: > > > Thanks Leon, we'll get this put through our testing. > > > > Thanks a lot. > > > > > > > The patch as is passed all our functional testing. Thanks Mike, Can I ask you to perform a performance comparison between this patch and the following? diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/rdmavt/qp.c index 4522071fc220..d0e0f7cbe17a 100644 --- a/drivers/infiniband/sw/rdmavt/qp.c +++ b/drivers/infiniband/sw/rdmavt/qp.c @@ -1134,7 +1134,7 @@ struct ib_qp *rvt_create_qp(struct ib_pd *ibpd, } else if (init_attr->cap.max_recv_sge > 1) sg_list_sz = sizeof(*qp->r_sg_list) * (init_attr->cap.max_recv_sge - 1); - qp = kzalloc(sizeof(*qp), GFP_KERNEL); + qp = kzalloc_node(sizeof(*qp), GFP_KERNEL, rdi->dparms.node); if (!qp) goto bail_swq; qp->r_sg_list = Thanks > > Mike