From: Bruce Richardson <bruce.richardson@intel.com>
To: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Cc: Heinrich Kuhn <heinrich.kuhn@netronome.com>,
dev@dpdk.org, "Chaoyong.He" <chaoyong.he@corigine.com>,
Simon Horman <simon.horman@netronome.com>,
konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: change mq-mode on single queue devices
Date: Thu, 13 May 2021 10:59:07 +0100 [thread overview]
Message-ID: <YJz4a6T4GF5iswIh@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <fc0e7fac-6141-cbc8-4527-11f70efbcfeb@intel.com>
On Wed, May 12, 2021 at 09:43:57PM +0300, Medvedkin, Vladimir wrote:
> Hi Bruce,
>
> On 12/05/2021 19:32, Bruce Richardson wrote:
> > On Mon, May 10, 2021 at 06:53:19PM +0200, Heinrich Kuhn wrote:
> > > From: "Chaoyong.He" <chaoyong.he@corigine.com>
> > >
> > > Set the Rx multi-queue mode to NONE when configuring a port that is
> > > associated with hardware that only supports a single Rx queue.
> > >
> > > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> > > Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
> > > Signed-off-by: Simon Horman <simon.horman@netronome.com>
> > > ---
> > > examples/l3fwd/main.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
> > > index bb49e5faf..87b638ac0 100644
> > > --- a/examples/l3fwd/main.c
> > > +++ b/examples/l3fwd/main.c
> > > @@ -953,6 +953,10 @@ l3fwd_poll_resource_setup(void)
> > > local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
> > > dev_info.flow_type_rss_offloads;
> > > +
> > > + if (dev_info.max_rx_queues == 1)
> > > + local_port_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
> > > +
> >
> > While it makes sense to do this when the port only supports a single queue,
> > would it not also make sense to do this when the requested queues are 1
> > too?
> >
> > Adding some lookup library maintainers on CC - I assume that the RSS value
> > is not actually used for lookup anywhere in l3fwd.
> >
>
> As far as I can see the rss hash value is not used anywhere in l3fwd. In
> LPM/FIB this is not required at all, in EM CRC or Jenkins hash is used.
>
That's what I thought from looking at the code too. Since this is not
really a bug fix, I think it can be pushed till 21.08.
With or without the change I suggest above:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2021-05-13 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 16:53 [dpdk-dev] [PATCH] examples/l3fwd: change mq-mode on single queue devices Heinrich Kuhn
2021-05-12 16:32 ` Bruce Richardson
2021-05-12 18:43 ` Medvedkin, Vladimir
2021-05-13 9:59 ` Bruce Richardson [this message]
2021-07-30 16:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJz4a6T4GF5iswIh@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=heinrich.kuhn@netronome.com \
--cc=konstantin.ananyev@intel.com \
--cc=simon.horman@netronome.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.