Re: [PATCH] i2c: core: Add stub for i2c_verify_client() if !CONFIG_I2C

From: Wolfram Sang <wsa@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-i2c@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Tom Rix <trix@redhat.com>, Sean Nyekjaer <sean@geanix.com>
Subject: Re: [PATCH] i2c: core: Add stub for i2c_verify_client() if !CONFIG_I2C
Date: Thu, 27 May 2021 22:23:34 +0200	[thread overview]
Message-ID: <YK//xmqZCZRT1VVD@kunai> (raw)
In-Reply-To: <20210526174436.2208277-1-jic23@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 903 bytes --]

Hi Jonathan,

> Fixes: 68068fad0e1c ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
> Cc: Sean Nyekjaer <sean@geanix.com>
> Cc: Wolfram Sang <wsa@kernel.org>
> ---
> 
> Note the broken patch is only in the IIO/togreg branch at the moment.

Then the fixes tag should be removed. It is only for upstream commits.
It means we will have a merge dependency the next cycle, so I will send
my pull request early.

> 
>  include/linux/i2c.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index e8f2ac8c9c3d..aa52738b9c46 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -343,7 +343,14 @@ struct i2c_client {
>  };
>  #define to_i2c_client(d) container_of(d, struct i2c_client, dev)
>  
> +#if IS_ENABLED(CONFIG_I2C)

Hmm, can't we move this into an already existing IS_ENABLED block?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]