From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A74EC47089 for ; Thu, 27 May 2021 12:23:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CAD8613C0 for ; Thu, 27 May 2021 12:23:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235177AbhE0MZN (ORCPT ); Thu, 27 May 2021 08:25:13 -0400 Received: from mail.skyhub.de ([5.9.137.197]:33996 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234410AbhE0MZL (ORCPT ); Thu, 27 May 2021 08:25:11 -0400 Received: from zn.tnic (p200300ec2f0f0200feb4df54292f983f.dip0.t-ipconnect.de [IPv6:2003:ec:2f0f:200:feb4:df54:292f:983f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7CC271EC01DF; Thu, 27 May 2021 14:23:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1622118217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=XmPZBX9quvpk0nriJ9voXMcog/6QnU2qkiYE1ANKHdM=; b=MehT+vNxndiAuJk5SqOte+CQFxNPHQD3le5s/qF9DvFyzrQpAL/X5Rjc4LCKYcSIwmM4vf 1c+BomWYBxyeugJTfBId24lmvaidt8QLTKLZvJ5DqIUojQx6sncr/ToCW/vAGsXe+G2jsH t7VAj52oGLWysFxkc89avI71oEVvdxk= Date: Thu, 27 May 2021 14:23:35 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, tglx@linutronix.de, jroedel@suse.de, thomas.lendacky@amd.com, pbonzini@redhat.com, mingo@redhat.com, dave.hansen@intel.com, rientjes@google.com, seanjc@google.com, peterz@infradead.org, hpa@zytor.com, tony.luck@intel.com Subject: Re: [PATCH Part1 RFC v2 16/20] x86/kernel: Validate rom memory before accessing when SEV-SNP is active Message-ID: References: <20210430121616.2295-1-brijesh.singh@amd.com> <20210430121616.2295-17-brijesh.singh@amd.com> <588df124-6213-22c4-384f-49fa368bb7ed@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <588df124-6213-22c4-384f-49fa368bb7ed@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 07:12:00AM -0500, Brijesh Singh wrote: > Let me know if you still think that snp_prep_memory() helper is required. Yes, I still do think that because you can put the comment and all the manupulation of parameters in there and have a single oneliner in probe_roms.c: snp_prep_memory(...); and have the details in sev.c where they belong. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette