From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22ECFC47089 for ; Thu, 27 May 2021 12:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 057AB613CA for ; Thu, 27 May 2021 12:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235672AbhE0MrL (ORCPT ); Thu, 27 May 2021 08:47:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:59944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234699AbhE0MrK (ORCPT ); Thu, 27 May 2021 08:47:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EC70B606A5; Thu, 27 May 2021 12:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622119536; bh=t+y/6kISVhX7iAjxtBgSAvix/BBCFSFapdY31Z7RDuY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VSwD3MTJocLoRQ9cmzr2ZFelsCtrHKfm8hUEXKGGkht8M3UK/VdZFjk4nFDdliY0i UOMxIGhpqMMj81nHaDUG7QXfHSeqLUgDz2LTs4JfP31nXqSu0eXF4M30PRd54xsxco jl2ddSeAXifFJOvarcuUbvK+XrXITcAUMPOY5Hv4= Date: Thu, 27 May 2021 14:45:34 +0200 From: Greg KH To: nizamhaider786@gmail.com Cc: laforge@gnumonks.org, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] char: pcmcia: cm4000_cs: Fix failure handling Message-ID: References: <20210524230235.571-1-nizamhaider786@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210524230235.571-1-nizamhaider786@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2021 at 04:32:34AM +0530, nizamhaider786@gmail.com wrote: > From: Nijam Haider > > Handled failure cases of device_create() > > Signed-off-by: Nijam Haider > --- > V1 -> V2: Added description and changelog > --- > drivers/char/pcmcia/cm4000_cs.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/pcmcia/cm4000_cs.c b/drivers/char/pcmcia/cm4000_cs.c > index 89681f07bc78..1ed4eac6b8ef 100644 > --- a/drivers/char/pcmcia/cm4000_cs.c > +++ b/drivers/char/pcmcia/cm4000_cs.c > @@ -1783,6 +1783,7 @@ static int cm4000_probe(struct pcmcia_device *link) > { > struct cm4000_dev *dev; > int i, ret; > + struct device *dev_ret; > > for (i = 0; i < CM4000_MAX_DEV; i++) > if (dev_table[i] == NULL) > @@ -1814,8 +1815,14 @@ static int cm4000_probe(struct pcmcia_device *link) > return ret; > } > > - device_create(cmm_class, NULL, MKDEV(major, i), NULL, "cmm%d", i); > - > + dev_ret = device_create(cmm_class, NULL, MKDEV(major, i), NULL, "cmm%d", i); > + if (IS_ERR(dev_ret)) { > + dev_err(&link->dev, "device_create failed for %d\n", i); > + cm4000_release(link); > + dev_table[i] = NULL; > + kfree(dev); > + return -ENODEV; > + } As before, make different err_*: labels and jump to them when cleaning up. thanks, greg k-h