From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C511C47089 for ; Thu, 27 May 2021 13:02:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24B35610A2 for ; Thu, 27 May 2021 13:02:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236010AbhE0NE3 (ORCPT ); Thu, 27 May 2021 09:04:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:36480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235177AbhE0NE2 (ORCPT ); Thu, 27 May 2021 09:04:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A0099610A2; Thu, 27 May 2021 13:02:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622120574; bh=eA7hFQjhjlkA6FGzsMI9qG2tJxSORQ8/zD5C/vVFOsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IDA685ydk5IwY08vYougvVTSpbadl4AfWVhExFtxyasStnLxobzjttrsWWSXEvGPB BKHuGOGlowt+e8RA8eWWzkclXhCIz1cWHBKaiiIYrXuFVJEdF4zE6g0p32cmuxjnvx CcdVGDnpD+iAbK/snbwWc0MmKYL/M6Pyi3zgIQfA= Date: Thu, 27 May 2021 15:02:51 +0200 From: Greg KH To: Rob Herring Cc: Kyle Tso , Heikki Krogerus , Badhri Jagan Sridharan , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org Subject: Re: [PATCH v2] dt-bindings: connector: Replace BIT macro with generic bit ops Message-ID: References: <20210527121029.583611-1-kyletso@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 07:52:24AM -0500, Rob Herring wrote: > On Thu, May 27, 2021 at 7:41 AM Greg KH wrote: > > > > On Thu, May 27, 2021 at 08:10:29PM +0800, Kyle Tso wrote: > > > BIT macro is not defined. Replace it with generic bit operations. > > > > > > Fixes: 630dce2810b9 ("dt-bindings: connector: Add SVDM VDO properties") > > > Signed-off-by: Kyle Tso > > > --- > > > Changes since v1: > > > - re-word the commit message > > > > > > include/dt-bindings/usb/pd.h | 20 ++++++++++---------- > > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > > > diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h > > > index fef3ef65967f..cb70b4ceedde 100644 > > > --- a/include/dt-bindings/usb/pd.h > > > +++ b/include/dt-bindings/usb/pd.h > > > @@ -163,10 +163,10 @@ > > > #define UFP_VDO_VER1_2 2 > > > > > > /* Device Capability */ > > > -#define DEV_USB2_CAPABLE BIT(0) > > > -#define DEV_USB2_BILLBOARD BIT(1) > > > -#define DEV_USB3_CAPABLE BIT(2) > > > -#define DEV_USB4_CAPABLE BIT(3) > > > +#define DEV_USB2_CAPABLE (1 << 0) > > > +#define DEV_USB2_BILLBOARD (1 << 1) > > > +#define DEV_USB3_CAPABLE (1 << 2) > > > +#define DEV_USB4_CAPABLE (1 << 3) > > > > Why not just include the proper .h file instead? > > Because the DT headers can't depend on kernel headers as they get used > separately. Lame. :)