All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Haocheng Xie <xiehaocheng.cn@gmail.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	jolsa@redhat.com, namhyung@kernel.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf core: Fix some kernel-doc warnings.
Date: Wed, 26 May 2021 09:05:00 +0200	[thread overview]
Message-ID: <YK3zHAdIQZ9GPhfg@gmail.com> (raw)
In-Reply-To: <20210526033438.23640-1-xiehaocheng.cn@gmail.com>


* Haocheng Xie <xiehaocheng.cn@gmail.com> wrote:

> Fix the following W=1 kernel build warning(s):
> kernel/events/core.c:143: warning: Function parameter or member 'cpu' not described in 'cpu_function_call'
> kernel/events/core.c:11924: warning: Function parameter or member 'flags' not described in 'sys_perf_event_open'
> kernel/events/core.c:12382: warning: Function parameter or member 'overflow_handler' not described in 'perf_event_create_kernel_counter'
> kernel/events/core.c:12382: warning: Function parameter or member 'context' not described in 'perf_event_create_kernel_counter'
> 
> Signed-off-by: Haocheng Xie <xiehaocheng.cn@gmail.com>

Even with your two patches there's still W=1 warnings remaining in 
kernel/events/:

  kernel/events/hw_breakpoint.c:461: warning: Function parameter or member 'context' not described in 'register_user_hw_breakpoint'
  kernel/events/hw_breakpoint.c:560: warning: Function parameter or member 'context' not described in 'register_wide_hw_breakpoint'

Could you please fix all of them, and send them as a 3-patch series? 

Doesn't make much sense to just partially fix W=1 warnings in a subsystem.

Thanks,

	Ingo

  reply	other threads:[~2021-05-26  7:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  3:34 [PATCH] perf core: Fix some kernel-doc warnings Haocheng Xie
2021-05-26  7:05 ` Ingo Molnar [this message]
2021-05-26  9:46   ` Haocheng Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YK3zHAdIQZ9GPhfg@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=xiehaocheng.cn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.