From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00822C47088 for ; Wed, 26 May 2021 16:57:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D72B3613D7 for ; Wed, 26 May 2021 16:57:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233701AbhEZQ71 (ORCPT ); Wed, 26 May 2021 12:59:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:45372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233725AbhEZQ7X (ORCPT ); Wed, 26 May 2021 12:59:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6A9AA613E5; Wed, 26 May 2021 16:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622048271; bh=xrw5xQa0Ao9OhAkU/wgbik2nbqFDwxOpP1syqGR6CIk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pQcu+jHdCmweZ0e8P5/4hQhB0riBSStq8zh3KBBCGvz5EpTGaEKk7wuG97CNh9EzI xX3HpcwHjNrO9xrLnbDmmNSN8D1HQbIZZseciH40KbIr2hQzfpP7lrIjvXch0Djeoi gD0FiUDjb/xvmj7CGxsF/2T7So4/HtHQBCDAjaMa6ECTT5ACEXAoe/aIfN6untCXSr IEHvyBRJtdmAnbj4Z1Se4EFE8Hc6ToLoWF8sv4QWVUYq8akI1ruKULg/nkZJZ9V1VQ meVkisjoT+HnhldTd7PONdXJ5xBJSAvRoQLYZjY9+IMOgMIiu9NDVTyGx9F1SMrF2i 5FRLOqhU6e4pw== Date: Wed, 26 May 2021 09:57:49 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v6 4/6] crypto: arm64/aes-ccm - remove non-SIMD fallback path Message-ID: References: <20210526100729.12939-1-ardb@kernel.org> <20210526100729.12939-5-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210526100729.12939-5-ardb@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, May 26, 2021 at 12:07:27PM +0200, Ard Biesheuvel wrote: > AES/CCM on arm64 is implemented as a synchronous AEAD, and so it is > guaranteed by the API that it is only invoked in task or softirq > context. Since softirqs are now only handled when the SIMD is not > being used in the task context that was interrupted to service the > softirq, we no longer need a fallback path. Let's remove it. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/crypto/aes-ce-ccm-glue.c | 153 ++++---------------- > 1 file changed, 32 insertions(+), 121 deletions(-) Reviewed-by: Eric Biggers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95C60C47082 for ; Wed, 26 May 2021 18:04:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AA746113D for ; Wed, 26 May 2021 18:04:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AA746113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YrXdIeMXcjDuBdknXqVPEvYBDNnFZj36b7Y4zra/jdA=; b=mVIz+JU14mzDM9 jJ0iwI3LwYB02DZG7Gcz46GJsBOlVdzm1UZGDNKCLZeVKctFok9gizvuxXqTUgvSuLv0I7dly0HxN /k4O5p4Gb1kJUHg0pc9rzCzP0HtovyQs1agMzop3LtL4es/BR7nVPjXF5t7cXz6E/e5PJcOyl3H9o kbxYZOqEPdvj8aEKhrqmPCwCP69VxHy27S4m/upgyNIiId9BBO/LWbeEHq4PRxvS33+vNsmGyBUXK Vn6Rc26PWSBbkxWy1AbSvjxjuhdpqiM0pNJ7087+KjGInGsTEfOcKOzpz3f6J9tm2mwfwbQ7LPE/W eIbRZVpYUeeSEpB0DFOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llxqX-00GKw2-Sw; Wed, 26 May 2021 18:01:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llwqu-00FuuT-HB for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 16:57:53 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6A9AA613E5; Wed, 26 May 2021 16:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622048271; bh=xrw5xQa0Ao9OhAkU/wgbik2nbqFDwxOpP1syqGR6CIk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pQcu+jHdCmweZ0e8P5/4hQhB0riBSStq8zh3KBBCGvz5EpTGaEKk7wuG97CNh9EzI xX3HpcwHjNrO9xrLnbDmmNSN8D1HQbIZZseciH40KbIr2hQzfpP7lrIjvXch0Djeoi gD0FiUDjb/xvmj7CGxsF/2T7So4/HtHQBCDAjaMa6ECTT5ACEXAoe/aIfN6untCXSr IEHvyBRJtdmAnbj4Z1Se4EFE8Hc6ToLoWF8sv4QWVUYq8akI1ruKULg/nkZJZ9V1VQ meVkisjoT+HnhldTd7PONdXJ5xBJSAvRoQLYZjY9+IMOgMIiu9NDVTyGx9F1SMrF2i 5FRLOqhU6e4pw== Date: Wed, 26 May 2021 09:57:49 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v6 4/6] crypto: arm64/aes-ccm - remove non-SIMD fallback path Message-ID: References: <20210526100729.12939-1-ardb@kernel.org> <20210526100729.12939-5-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210526100729.12939-5-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_095752_633591_3C6897A1 X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 26, 2021 at 12:07:27PM +0200, Ard Biesheuvel wrote: > AES/CCM on arm64 is implemented as a synchronous AEAD, and so it is > guaranteed by the API that it is only invoked in task or softirq > context. Since softirqs are now only handled when the SIMD is not > being used in the task context that was interrupted to service the > softirq, we no longer need a fallback path. Let's remove it. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/crypto/aes-ce-ccm-glue.c | 153 ++++---------------- > 1 file changed, 32 insertions(+), 121 deletions(-) Reviewed-by: Eric Biggers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel