From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A4CC47088 for ; Wed, 26 May 2021 17:18:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC7A0613D2 for ; Wed, 26 May 2021 17:18:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234350AbhEZRTl (ORCPT ); Wed, 26 May 2021 13:19:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:48532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234273AbhEZRTl (ORCPT ); Wed, 26 May 2021 13:19:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B0E7611B0; Wed, 26 May 2021 17:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622049489; bh=fue/kOF/ZOdJ77PEzAFEhm+XX/PeZi69M1P5v2+QnWc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GNtglhlGxNzBlWnhUrmXDUMYf+jw6Yb9kZCSfhNTKjIMYYrFpSwiBELyDeJVhCqBM QlUpwdnA3i3wKMw/xPZIbz5WpRK2+vBFFm0FY1YEfxOuJbxGtR2kyP7tlSUJJltR2S FMJkjYncZARKnS6MtC4WS5vwk5GSMjdo39C508zlU/FFjGb1qzytdmYy/yo/PvunDU b6F2q+9W+Wbiq1w9+z7ZkOYJ2acjt68HN4BQ+8tS5pOl8QLApujRrV4Uh/x+PbswFV B6t2EaX2Sre7vkeHAzWbRzR67wwgvdVgg3ofmHde+wYYG7ULOEa1adUiluRzcb0rGW h3f2jJCEivs/A== Date: Wed, 26 May 2021 10:18:08 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v6 6/6] crypto: arm64/aes-ccm - avoid by-ref argument for ce_aes_ccm_auth_data Message-ID: References: <20210526100729.12939-1-ardb@kernel.org> <20210526100729.12939-7-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210526100729.12939-7-ardb@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, May 26, 2021 at 12:07:29PM +0200, Ard Biesheuvel wrote: > With the SIMD code path removed, we can clean up the CCM auth-only path > a bit further, by passing the 'macp' input buffer pointer by value, > rather than by reference, and taking the output value from the > function's return value. > > This way, the compiler is no longer forced to allocate macp on the > stack. This is not expected to make any difference in practice, it just > makes for slightly cleaner code. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/crypto/aes-ce-ccm-core.S | 23 ++++++++++---------- > arch/arm64/crypto/aes-ce-ccm-glue.c | 17 +++++---------- > 2 files changed, 17 insertions(+), 23 deletions(-) Reviewed-by: Eric Biggers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 146EFC47088 for ; Wed, 26 May 2021 18:23:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC274613AC for ; Wed, 26 May 2021 18:23:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC274613AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FF2DAyfqth3mTzm/+BWLfI7N50JDdlQmFshuDyY+uwE=; b=343yLTiH2FfsZm ndsI9RjjyMF0aJpAyQxmq6YpZqiOC7j9pk8CGrKXRGX7nSCZySTvPh98dmQVeqYIZFMCQAKu92SD1 e9KEKuJ4HZtPgTff3Oh2OmTYEekTc3JM0twFTslK3Bof7IRjZ+q6vMLaQOUOQwJt4I+ZbSzbFUzg1 H2+IPElJPnsTCAbksAnBvxXTSzpL046yvcfaetjJgpXI0pydHPbatZV0m6cJUq/glWZVSczSUY3+y 6v3jMuzVKL2DpYJ2fauNsvIqdgnJZnSy4/TmPvfPCvl/UT28oNFvR33EcYY8RLPKYWPY8UjuUoaNq HPzg5BJ6kykz3UAciKIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lly9M-00GT4t-0l; Wed, 26 May 2021 18:21:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llxAY-00G2x1-7I for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 17:18:11 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B0E7611B0; Wed, 26 May 2021 17:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622049489; bh=fue/kOF/ZOdJ77PEzAFEhm+XX/PeZi69M1P5v2+QnWc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GNtglhlGxNzBlWnhUrmXDUMYf+jw6Yb9kZCSfhNTKjIMYYrFpSwiBELyDeJVhCqBM QlUpwdnA3i3wKMw/xPZIbz5WpRK2+vBFFm0FY1YEfxOuJbxGtR2kyP7tlSUJJltR2S FMJkjYncZARKnS6MtC4WS5vwk5GSMjdo39C508zlU/FFjGb1qzytdmYy/yo/PvunDU b6F2q+9W+Wbiq1w9+z7ZkOYJ2acjt68HN4BQ+8tS5pOl8QLApujRrV4Uh/x+PbswFV B6t2EaX2Sre7vkeHAzWbRzR67wwgvdVgg3ofmHde+wYYG7ULOEa1adUiluRzcb0rGW h3f2jJCEivs/A== Date: Wed, 26 May 2021 10:18:08 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v6 6/6] crypto: arm64/aes-ccm - avoid by-ref argument for ce_aes_ccm_auth_data Message-ID: References: <20210526100729.12939-1-ardb@kernel.org> <20210526100729.12939-7-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210526100729.12939-7-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_101810_370994_DB526D2A X-CRM114-Status: GOOD ( 13.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 26, 2021 at 12:07:29PM +0200, Ard Biesheuvel wrote: > With the SIMD code path removed, we can clean up the CCM auth-only path > a bit further, by passing the 'macp' input buffer pointer by value, > rather than by reference, and taking the output value from the > function's return value. > > This way, the compiler is no longer forced to allocate macp on the > stack. This is not expected to make any difference in practice, it just > makes for slightly cleaner code. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/crypto/aes-ce-ccm-core.S | 23 ++++++++++---------- > arch/arm64/crypto/aes-ce-ccm-glue.c | 17 +++++---------- > 2 files changed, 17 insertions(+), 23 deletions(-) Reviewed-by: Eric Biggers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel