All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Frieder Schrempf <frieder.schrempf@kontron.de>,
	Tim Harvey <tharvey@gateworks.com>, Marek Vasut <marex@denx.de>,
	Device Tree Mailing List <devicetree@vger.kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rui Miguel Silva <rmfrfs@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Fabio Estevam <festevam@gmail.com>,
	linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH 00/23] media: imx: imx7-mipi-csis: Add i.MX8MM support
Date: Sun, 16 May 2021 01:46:58 +0300	[thread overview]
Message-ID: <YKBPYm9cnaA6X0XN@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210427110045.4cl3w7ij3w6x7rtg@pengutronix.de>

Hello,

Sorry for the late reply.

On Tue, Apr 27, 2021 at 01:00:45PM +0200, Marco Felsch wrote:
> On 21-04-26 12:35, Frieder Schrempf wrote:
> > On 21.04.21 17:27, Tim Harvey wrote:
> > > On Mon, Apr 12, 2021 at 7:31 PM Laurent Pinchart wrote:
> > > > 
> > > > Hello,
> > > > 
> > > > This patch series adds support for the CSIS found in the NXP i.MX8MM SoC
> > > > to the imx7-mipi-csis driver.
> > > > 
> > > > The CSIS is an IP core from Samsung, integrated in different NXP SoCs.
> > > > The driver currently supports v3.3 of the CSIS, found in SoCs from the
> > > > i.MX6 and i.MX7 families. This series extends the driver to support
> > > > v3.6.3 of the IP, found in i.MX8MM and other members of the i.MX8
> > > > family.
> > > > 
> > > > The first 21 patches are miscellaneous cleanups and improvements. Please
> > > > see individual patches for details.
> > > > 
> > > > Patch 22/23 extends the imx7-mipi-csis DT bindings with i.MX8MM support.
> > > > Support for other members of the i.MX8 family will come later, and for
> > > > SoCs including an ISI IP core (such as the i.MX8MP) this will require
> > > > more work to handle additional glue logic.
> > > > 
> > > > Patch 23/23 finaly extends the imx7-mipi-csis driver accordingly.
> > > > 
> > > > The changes in the integration of the CSIS between i.MX7 and i.MX8, as
> > > > described in the DT bindings, have been found through reading of
> > > > reference manuals and BSP source code, with different sources of
> > > > information contradicting each other. A confirmation from NXP would be
> > > > nice (in particular regarding the clocks).
> > > > 
> > > > Laurent Pinchart (23):
> > > >    media: imx: imx7_mipi_csis: Fix logging of only error event counters
> > > >    media: imx: imx7_mipi_csis: Count the CSI-2 debug interrupts
> > > >    media: imx: imx7_mipi_csis: Update ISP_CONFIG macros for quad pixel
> > > >      mode
> > > >    media: imx: imx7_mipi_csis: Move static data to top of
> > > >      mipi_csis_dump_regs()
> > > >    media: imx: imx7_mipi_csis: Minimize locking in get/set format
> > > >    media: imx: imx7_mipi_csis: Don't set subdev data
> > > >    media: imx: imx7-mipi-csis: Reorganize code in sections
> > > >    media: imx: imx7_mipi_csis: Set the CLKSETTLE register field
> > > >    media: imx: imx7_mipi_csis: Drop unused csis_hw_reset structure
> > > >    media: imx: imx7_mipi_csis: Store CSI-2 data type in format structure
> > > >    media: imx: imx7_mipi_csis: Drop csi_state phy field
> > > >    media: imx: imx7_mipi_csis: Rename mipi_sd to sd
> > > >    media: imx: imx7_mipi_csis: Rename csi_state flag field to state
> > > >    media: imx: imx7_mipi_csis: Turn csi_state irq field into local
> > > >      variable
> > > >    media: imx: imx7_mipi_csis: Don't pass pdev to mipi_csis_parse_dt()
> > > >    media: imx: imx7_mipi_csis: Pass csi_state to mipi_csis_subdev_init()
> > > >    media: imx: imx7_mipi_csis: Drop csi_state pdev field
> > > >    media: imx: imx7_mipi_csis: Make csi_state num_clocks field unsigned
> > > >    media: imx: imx7_mipi_csis: Reorganize csi_state structure
> > > >    media: imx: imx7_mipi_csis: Reorganize mipi_csis_probe()
> > > >    media: imx: imx7_mipi_csis: Reject invalid data-lanes settings
> > > >    dt-bindings: media: nxp,imx7-mipi-csi2: Add i.MX8MM support
> > > >    media: imx: imx7_mipi_csis: Add i.MX8MM support
> > > > 
> > > >   .../bindings/media/nxp,imx7-mipi-csi2.yaml    | 108 +-
> > > >   drivers/staging/media/imx/imx7-mipi-csis.c    | 943 ++++++++++--------
> > > >   2 files changed, 622 insertions(+), 429 deletions(-)
> > > 
> > > Laurent,
> > > 
> > > Thank you for your work on this!
> > > 
> > > I have an IMX8MM board supporting CSI and a couple of devices to test with:
> > > - Sony IMX477 12.3MP sensor (do not see any mainline support but there
> > > are some hits on the net as this is a RPi camera)
> > > - Sony IMX219 8MP sensor (should be supported by drivers/media/i2c/imx219.c)
> > > - Auvidea B10x HDMI to CSI-2 bridge (Toshiba TC358743XBG HDMI to CSI-2
> > > (MIPI)- 2D+C) (should be supported by drivers/media/i2c/tc358743.c)
> > > 
> > > Can you summarize the state of IMX8MM CSI capture in mainline? I
> > > suppose the MIPI power domain is still an issue? Anything else that
> > > would keep me from testing the above devices?
> > 
> > Just in case it might help you: I tested the previous version of Laurent's
> > patches (not on the mailing list) against mainline v5.10 with Lucas'
> > power-domain patches.
> > 
> > It should work fine in general. Here are some notes about the problems I
> > encountered: https://patchwork.kernel.org/project/linux-media/cover/20210215042741.28850-1-laurent.pinchart@ideasonboard.com/
> 
> Is there also any ongoing work for the DPHY driver?

I'm still working on the CSI bridge side. Aside from power domains,
there's no big blocker. I managed to get it working fine with a few
different sensors. It still fails with an MT9M114 for a reason I don't
understand at this point, but I don't think that's an upstreaming
blocker.

I'll try to post patches in the not too distant future.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2021-05-15 22:47 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13  2:29 [PATCH 00/23] media: imx: imx7-mipi-csis: Add i.MX8MM support Laurent Pinchart
2021-04-13  2:29 ` [PATCH 01/23] media: imx: imx7_mipi_csis: Fix logging of only error event counters Laurent Pinchart
2021-04-26 11:01   ` Frieder Schrempf
2021-05-15 21:54     ` Laurent Pinchart
2021-04-13  2:29 ` [PATCH 02/23] media: imx: imx7_mipi_csis: Count the CSI-2 debug interrupts Laurent Pinchart
2021-04-26 11:39   ` Frieder Schrempf
2021-04-13  2:29 ` [PATCH 03/23] media: imx: imx7_mipi_csis: Update ISP_CONFIG macros for quad pixel mode Laurent Pinchart
2021-04-26 11:41   ` Frieder Schrempf
2021-04-13  2:29 ` [PATCH 04/23] media: imx: imx7_mipi_csis: Move static data to top of mipi_csis_dump_regs() Laurent Pinchart
2021-04-26 11:46   ` Frieder Schrempf
2021-04-13  2:29 ` [PATCH 05/23] media: imx: imx7_mipi_csis: Minimize locking in get/set format Laurent Pinchart
2021-04-13  2:29 ` [PATCH 06/23] media: imx: imx7_mipi_csis: Don't set subdev data Laurent Pinchart
2021-04-13  2:29 ` [PATCH 07/23] media: imx: imx7-mipi-csis: Reorganize code in sections Laurent Pinchart
2021-04-13  2:29 ` [PATCH 08/23] media: imx: imx7_mipi_csis: Set the CLKSETTLE register field Laurent Pinchart
2021-04-13  2:30 ` [PATCH 09/23] media: imx: imx7_mipi_csis: Drop unused csis_hw_reset structure Laurent Pinchart
2021-04-13  2:30 ` [PATCH 10/23] media: imx: imx7_mipi_csis: Store CSI-2 data type in format structure Laurent Pinchart
2021-04-13  2:30 ` [PATCH 11/23] media: imx: imx7_mipi_csis: Drop csi_state phy field Laurent Pinchart
2021-04-13  2:30 ` [PATCH 12/23] media: imx: imx7_mipi_csis: Rename mipi_sd to sd Laurent Pinchart
2021-04-13  2:30 ` [PATCH 13/23] media: imx: imx7_mipi_csis: Rename csi_state flag field to state Laurent Pinchart
2021-04-13  2:30 ` [PATCH 14/23] media: imx: imx7_mipi_csis: Turn csi_state irq field into local variable Laurent Pinchart
2021-04-13  2:30 ` [PATCH 15/23] media: imx: imx7_mipi_csis: Don't pass pdev to mipi_csis_parse_dt() Laurent Pinchart
2021-04-13  2:30 ` [PATCH 16/23] media: imx: imx7_mipi_csis: Pass csi_state to mipi_csis_subdev_init() Laurent Pinchart
2021-04-13  2:30 ` [PATCH 17/23] media: imx: imx7_mipi_csis: Drop csi_state pdev field Laurent Pinchart
2021-04-13  2:30 ` [PATCH 18/23] media: imx: imx7_mipi_csis: Make csi_state num_clocks field unsigned Laurent Pinchart
2021-04-13  2:30 ` [PATCH 19/23] media: imx: imx7_mipi_csis: Reorganize csi_state structure Laurent Pinchart
2021-04-13  2:30 ` [PATCH 20/23] media: imx: imx7_mipi_csis: Reorganize mipi_csis_probe() Laurent Pinchart
2021-04-13  2:30 ` [PATCH 21/23] media: imx: imx7_mipi_csis: Reject invalid data-lanes settings Laurent Pinchart
2021-04-13  2:30 ` [PATCH 22/23] dt-bindings: media: nxp,imx7-mipi-csi2: Add i.MX8MM support Laurent Pinchart
2021-04-13 16:00   ` Rob Herring
2021-04-18 20:15   ` [PATCH v1.1 " Laurent Pinchart
2021-04-13  2:30 ` [PATCH 23/23] media: imx: imx7_mipi_csis: " Laurent Pinchart
2021-04-27 10:57   ` Marco Felsch
2021-05-15 22:10     ` Laurent Pinchart
2021-04-15  9:27 ` [PATCH 00/23] media: imx: imx7-mipi-csis: " Rui Miguel Silva
2021-04-18 20:21   ` Laurent Pinchart
2021-04-18 20:14 ` [PATCH 24/23] media: imx: imx7_mipi_csis: Update MAINTAINERS Laurent Pinchart
2021-04-18 22:22   ` Rui Miguel Silva
2021-04-21 15:27 ` [PATCH 00/23] media: imx: imx7-mipi-csis: Add i.MX8MM support Tim Harvey
2021-04-26 10:35   ` Frieder Schrempf
2021-04-27 11:00     ` Marco Felsch
2021-05-15 22:46       ` Laurent Pinchart [this message]
2021-05-04 15:59 ` [PATCH 00/23] media: imx: imx7-mipi-csis: Add i.MX8MM support / imx8mq support Martin Kepplinger
2021-05-15 22:55   ` Laurent Pinchart
2021-05-18 14:39     ` Martin Kepplinger
2021-05-19  1:14       ` Laurent Pinchart
2021-05-19  9:33         ` Martin Kepplinger
2021-05-19 15:21         ` Martin Kepplinger
2021-05-19 15:46           ` Laurent Pinchart
2021-05-20 10:54             ` Martin Kepplinger
2021-05-20 12:37               ` Laurent Pinchart
2021-05-21  9:25                 ` Martin Kepplinger
2021-05-21  9:43                   ` Laurent Pinchart
2021-05-21 11:02                     ` Martin Kepplinger
2021-05-21 13:36                       ` Laurent Pinchart
2021-05-25  7:32                         ` Martin Kepplinger
2021-05-25 11:25                           ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKBPYm9cnaA6X0XN@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=marex@denx.de \
    --cc=p.zabel@pengutronix.de \
    --cc=rmfrfs@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=slongerbeam@gmail.com \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.